From ef1715e9ee622bf5655558ba593b6aa6f9488e6d Mon Sep 17 00:00:00 2001 From: Dan Stillman Date: Thu, 22 Jun 2017 05:48:11 -0400 Subject: [PATCH] Fix "Generate Report from Collection" when sorting by creator or date --- components/zotero-protocol-handler.js | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/components/zotero-protocol-handler.js b/components/zotero-protocol-handler.js index 8df84f065..b5fffde46 100644 --- a/components/zotero-protocol-handler.js +++ b/components/zotero-protocol-handler.js @@ -383,8 +383,8 @@ function ZoteroProtocolHandler() { valB = Zotero.Items.getSortTitle(valB); } else if (sorts[index].field == 'date') { - var itemA = Zotero.Items.getByLibraryAndKey(a.libraryID, a.key); - var itemB = Zotero.Items.getByLibraryAndKey(b.libraryID, b.key); + var itemA = Zotero.Items.getByLibraryAndKey(params.libraryID, a.key); + var itemB = Zotero.Items.getByLibraryAndKey(params.libraryID, b.key); valA = itemA.getField('date', true, true); valB = itemB.getField('date', true, true); } @@ -392,8 +392,8 @@ function ZoteroProtocolHandler() { // slightly less broken. To do this right, real creator // sorting needs to be abstracted from itemTreeView.js. else if (sorts[index].field == 'firstCreator') { - var itemA = Zotero.Items.getByLibraryAndKey(a.libraryID, a.key); - var itemB = Zotero.Items.getByLibraryAndKey(b.libraryID, b.key); + var itemA = Zotero.Items.getByLibraryAndKey(params.libraryID, a.key); + var itemB = Zotero.Items.getByLibraryAndKey(params.libraryID, b.key); valA = itemA.getField('firstCreator'); valB = itemB.getField('firstCreator'); }