suzanne.soy/zotero
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Closes #669 by supporting encode/decode of non-ASCII (e.g. accented) characters in COinS tags

Browse Source
This commit is contained in:
Sean Takats 2007-06-20 15:53:25 +00:00
parent 22c2fe8dde
commit f1ff4ca2a9
1 changed files with 7 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
chrome/content/zotero/xpcom/ingester.js
View File

@ -259,6 +259,9 @@ Zotero.OpenURL = new function() {
} }
// encode ctx_ver (if available) and identifiers // encode ctx_ver (if available) and identifiers
// TODO identifiers may need to be encoded as follows:
// rft_id=info:doi/<the-url-encoded-doi>
// rft_id=http://<the-rest-of-the-url-encoded-url>
if(version == "0.1") { if(version == "0.1") {
var co = ""; var co = "";
@ -378,7 +381,7 @@ Zotero.OpenURL = new function() {
// get type // get type
for each(var part in coParts) { for each(var part in coParts) {
if(part.substr(0, 12) == "rft_val_fmt=") { if(part.substr(0, 12) == "rft_val_fmt=") {
var format = unescape(part.substr(12)); var format = decodeURIComponent(part.substr(12));
if(format == "info:ofi/fmt:kev:mtx:journal") { if(format == "info:ofi/fmt:kev:mtx:journal") {
item.itemType = "journalArticle"; item.itemType = "journalArticle";
break; break;
@ -417,7 +420,7 @@ Zotero.OpenURL = new function() {
for each(var part in coParts) { for each(var part in coParts) {
var keyVal = part.split("="); var keyVal = part.split("=");
var key = keyVal[0]; var key = keyVal[0];
var value = unescape(keyVal[1].replace(/\+|%2[bB]/g, " ")); var value = decodeURIComponent(keyVal[1].replace(/\+|%2[bB]/g, " "));
if(!value) { if(!value) {
continue; continue;
} }
@ -600,9 +603,9 @@ Zotero.OpenURL = new function() {
function _mapTag(data, tag, version) { function _mapTag(data, tag, version) {
if(data) { if(data) {
if(version == "0.1") { if(version == "0.1") {
return "&"+tag+"="+escape(data); return "&"+tag+"="+encodeURIComponent(data);
} else { } else {
return "&rft."+tag+"="+escape(data); return "&rft."+tag+"="+encodeURIComponent(data);
} }
} else { } else {
return ""; return "";