From f3daf6b4bc727eadd0b6951534255ee7d26cb793 Mon Sep 17 00:00:00 2001 From: Simon Kornblith Date: Thu, 13 Aug 2015 19:48:23 -0400 Subject: [PATCH] Always capture up/down when QuickFormat reference panel is open It was annoying if you pressed the up key too many times and the cursor moved. --- chrome/content/zotero/integration/quickFormat.js | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/chrome/content/zotero/integration/quickFormat.js b/chrome/content/zotero/integration/quickFormat.js index 18792cb5a..0f7db1e5a 100644 --- a/chrome/content/zotero/integration/quickFormat.js +++ b/chrome/content/zotero/integration/quickFormat.js @@ -1084,7 +1084,7 @@ var Zotero_QuickFormat = new function () { selection.addRange(nodeRange); } - } else if(keyCode === event.DOM_VK_UP) { + } else if(keyCode === event.DOM_VK_UP && referencePanel.state === "open") { var selectedItem = referenceBox.selectedItem; var previousSibling; @@ -1104,9 +1104,9 @@ var Zotero_QuickFormat = new function () { visibleItem = visibleItem.previousSibling; } referenceBox.ensureElementIsVisible(visibleItem); - event.preventDefault(); }; - } else if(keyCode === event.DOM_VK_DOWN) { + event.preventDefault(); + } else if(keyCode === event.DOM_VK_DOWN && referencePanel.state === "open") { if((Zotero.isMac ? event.metaKey : event.ctrlKey)) { // If meta key is held down, show the citation properties panel var bubble = _getSelectedBubble(); @@ -1126,8 +1126,8 @@ var Zotero_QuickFormat = new function () { if(nextSibling){ referenceBox.selectedItem = nextSibling; referenceBox.ensureElementIsVisible(nextSibling); - event.preventDefault(); }; + event.preventDefault(); } } else { _resetSearchTimer();