suzanne.soy/zotero
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
9,744 Commits 11 Branches 258 Tags 98 MiB
13f788f3f1
Commit Graph

7713 Commits

Author SHA1 Message Date
Dan Stillman
531170353b Fix bidirectional relations on Duplicate Item 2017-10-01 22:04:11 -04:00
Dan Stillman
c0143300c4 Fix additional refresh bug when Advanced Search window is open 
Follow-up to 89babf8832
 2017-10-01 00:23:37 -04:00
Dan Stillman
699d5634e9 Add deprecation warning for itemTreeView::saveSelection() 2017-09-30 23:46:43 -04:00
Dan Stillman
4eb18e5eba Make missing row in itemTreeView::getSelectedItems() non-fatal 
This might help avoid the search bar brokenness that people are seeing
(and that we can't reproduce), though the same problem might just cause
a later error.
 2017-09-30 23:45:00 -04:00
Dan Stillman
f75d7313dd Update locales from Transifex 2017-09-30 19:33:30 -04:00
Dan Stillman
dec6b864c9 Revert Create Bib/Doc Prefs font size change from db496e13c2 
The font size is already controlled by the main font size pref, so this
was just making the font disproportionally bigger.
 2017-09-30 19:08:05 -04:00
Dan Stillman
52bbb79fd0 Remove citeproc-prereqs, which isn't necessary anymore 2017-09-30 19:07:29 -04:00
Dan Stillman
e62433edfb Fix citeproc-js in Firefox 56 
Our retrieveLocale() implementation was broken by
https://bugzilla.mozilla.org/show_bug.cgi?id=1319111
 2017-09-30 04:01:28 -04:00
Dan Stillman
89babf8832 Fix refresh problems when Advanced Search is open, and maybe other times 2017-09-29 04:24:49 -04:00
Dan Stillman
48d4d2d5a5 Standardize connector server behavior for saves to read-only libraries 
Return a 500 for read-only libraries for all save modes. Read-only views
within editable libraries will save to the library root.

Addresses #185, RIS/BibTeX interception to read-only view behaves
differently from save button
 2017-09-27 17:39:18 -04:00
Adomas Venčkauskas
7a062a7493 Remove connector proxy code 
Observing requests, auto-redirecting and learning proxies no longer
relevant on this codebase (and interferes with Scaffold).
 2017-09-25 14:57:02 +03:00
Dan Stillman
da21c9c47b Remove old archive.org relations 
These aren't allowed by the API and were breaking syncing (and haven't
been exposed anywhere for years anyway).
 2017-09-22 16:58:16 -04:00
Adomas Venčkauskas
42e2f229c0 Apply linux tab fixes to all tabs (e.g. tabs in zotero plugins) 2017-09-22 13:10:27 +03:00
Dan Stillman
19447e7b90 Fix RIS/BibTeX import errors when in library root 2017-09-22 04:12:21 -04:00
Dan Stillman
a455a72534 Remove invalid relations mangled during import 
Not sure if this occurred for our own translators, but it addresses
items created from #1282.
 2017-09-22 01:22:33 -04:00
Dan Stillman
0d3d4323b5 Fix relations import via translators 
Fixes #1282
 2017-09-22 01:02:50 -04:00
Dan Stillman
10cae22c55 Restrict relation predicates to letters and colons for now 2017-09-22 01:01:52 -04:00
Dan Stillman
241e596680 Update citeproc-js to 1.1.178 2017-09-21 15:47:41 -04:00
Dan Stillman
d81e2a5cf0 Fix sync errors from remote item referencing deleted local collection 2017-09-20 05:33:44 -04:00
Dan Stillman
85d7c01c85 Fix getAsync() integer warning when clicking on related item 2017-09-20 03:36:16 -04:00
Dan Stillman
c7639f328f Fix editing in classic citation window (broken by 2901174ba3) 
This is (hopefully) a better fix for selection issues than 2901174ba3. A
reference to the collectionTreeView is stored in a `view` property on
the collectionTreeRow, and when an itemTreeView is initialized and
passed a collectionTreeRow it assigns itself to an `itemTreeView`
property on the row's view.
 2017-09-20 03:36:16 -04:00
Dan Stillman
365e58249d Check for invalid certificate in Zotero.HTTP.request() 
We were checking for this in the sync API client, but that didn't apply
to Amazon S3 for ZFS.
 2017-09-20 00:49:10 -04:00
Dan Stillman
a858368642 Revert "Use eraseTx() instead of erase() when deleting saved search" 
eraseTx() isn't actually valid in this context.

This reverts commit 103c16a563.
 2017-09-19 23:47:03 -04:00
Dan Stillman
8efbfb7c74 Close import progress window on error 
Fixes https://github.com/retorquere/zotero-better-bibtex/issues/719
 2017-09-19 02:35:04 -04:00
Dan Stillman
afc7afeb9c Fix error deleting collection after emptying trash 
Follow-up to c442daedce
Fixes #1317
 2017-09-18 17:03:12 -04:00
Dan Stillman
49506b6d94 Fix non-integer warning when purging ids from sourceList.persist 2017-09-18 17:02:25 -04:00
Dan Stillman
d83d70eb5c Update locate engine download code 
Asyncify, make JSON load failures not fatal, and simplify icon download
code (which also fixes download of CrossRef icon, which was failing for
some reason).
 2017-09-18 02:31:13 -04:00
Dan Stillman
6d53839fbc Add sniffer entry for .ico files 2017-09-18 02:26:31 -04:00
Dan Stillman
d2a33f2613 Update submodules 2017-09-18 01:37:26 -04:00
Dan Stillman
8ebff89c1c Update locales from Transifex 2017-09-18 01:36:39 -04:00
Dan Stillman
fb61819f6b Update automatic trash emptying after 3872e646ac 
And restore 'limit' parameter used for auto-empty
 2017-09-16 00:51:51 -04:00
Dan Stillman
e25af42ef3 Fix sync event listener after 3872e646ac 2017-09-15 21:02:38 -04:00
Dan Stillman
cc04ddbe4d Fix test failure after 8215ba7a1d 2017-09-15 20:42:17 -04:00
Dan Stillman
3872e646ac Speed up emptying trash 
Shows a progress meter, which allows for larger chunks and fewer
refreshes, avoids unnecessary updating of parent items that are
being deleted anyway, and skip re-sorting of modified items in the
trash.

Closes #1292, Emptying trash is slow
 2017-09-15 20:23:01 -04:00
Dan Stillman
7935d01a1c Update locales from Transifex 2017-09-15 00:51:19 -04:00
Dan Stillman
8215ba7a1d Crash Zotero on note-saving error 
Closes #1277, Crash note if not saving properly
 2017-09-15 00:46:29 -04:00
Dan Stillman
18c62be6a4 Fix display of data dir in migration error message 
When migrating prefs from Zotero for Firefox, the prefs specified a
custom data dir, and that directory was missing, the "Previous
directory:" line was blank.
 2017-09-14 18:49:01 -04:00
Dan Stillman
9395af86f7 Fix "SyntaxError: unterminated string literal" on first run 
This could happen when migrating prefs from Firefox when the prefs.js
file included a corrupted line.
 2017-09-14 18:48:00 -04:00
Dan Stillman
103c16a563 Use eraseTx() instead of erase() when deleting saved search 2017-09-13 01:02:07 -04:00
Dan Stillman
c442daedce Update collection cache after "Delete collection and items…" 
Fixes #1314
 2017-09-13 01:01:36 -04:00
Dan Stillman
5ec7c97f30 Add debugging for userID change 2017-09-12 16:22:46 -04:00
Dan Stillman
892d4fb5da Merge new English strings 2017-09-12 02:36:15 -04:00
Dan Stillman
a47c332895 Show better error message if data dir can't be created 2017-09-12 02:35:06 -04:00
Dan Stillman
1cab2ba5fa Merge new English strings 2017-09-11 03:54:42 -04:00
Dan Stillman
e9439c978b Allow setting data directory via -datadir command-line flag 
Can be an absolute path or 'profile' to use 'zotero' subdirectory of
profile directory as in earlier versions (but which won't be treated as
a legacy location eligible for migration)

Closes #1305
 2017-09-11 03:52:51 -04:00
Dan Stillman
33128d1f59 Filter 'XPCOMUtils.jsm' lines from stack traces 2017-09-11 03:52:50 -04:00
Dan Stillman
c6e6cb639c Update locales from Transifex 2017-09-10 20:34:20 -04:00
Dan Stillman
64e840e418 Continue after failure in Add Item by Identifier 
This should give better feedback when some identifiers fail, but for now
restore 4.0 behavior.

Also add items by identifier in order, not reverse order
 2017-09-10 03:54:26 -04:00
Dan Stillman
2901174ba3 Fix intermittent item selection failure 2017-09-10 03:18:59 -04:00
Dan Stillman
d271683968 Bypass cache by default in Zotero.Utilities.Internal.saveURI() 2017-09-07 23:55:45 -04:00
Dan Stillman
5248b08de0 Remove debug lines 2017-09-02 01:39:09 -04:00
Dan Stillman
1100015d2c Don't purge data tables until after schema update 
It's no longer necessary to do this before syncing, since tags and
creators aren't first-class objects.
 2017-09-02 01:13:34 -04:00
Dan Stillman
69c27cd8a7 Fix potential failure with full-text phrase search 
Phrase searches weren't scoped to the current library, so they could
return unloaded items in other libraries and cause the search to fail.
 2017-09-02 01:13:33 -04:00
Dan Stillman
fd5c48ac51 Simplify Zotero.ItemTreeView.prototype.getSortedItems() 2017-09-01 13:22:46 -04:00
Dan Stillman
ed6d628f4e Fix Create Bib for saved searches 2017-09-01 13:22:46 -04:00
Dan Stillman
01ecff8e2b Fix regression in 05d74c4cac 2017-08-30 18:47:21 -04:00
Dan Stillman
05d74c4cac Don't load note/attachments counts as primary data 
Zotero.Item::numNotes()/numAttachments() now require 'childItems' to
have been loaded.

Fixes #1301, Slow startup with many items in trash
 2017-08-30 18:08:25 -04:00
Dan Stillman
94c4445475 Fix restart error moving away from note that hadn't finished loading 2017-08-30 18:08:24 -04:00
Dan Stillman
000e7f9744 Update locales from Transifex 2017-08-29 10:23:36 -04:00
Frank Bennett
b0c0cd6e0c Expose styleEngine in csledit.js, for Abbreviation Filter 2017-08-24 23:26:03 +09:00
Dan Stillman
a15b23e353 Update citeproc-js to 1.1.177 2017-08-23 11:02:19 +02:00
Dan Stillman
f4b73d22b8 Fix error relocating to filename with different Unicode normalization 2017-08-23 11:02:05 +02:00
Dan Stillman
e632f1c84d Update locales from Transifex 2017-08-22 12:27:21 +02:00
Dan Stillman
1d19811bd2 Disable strict mode in citeproc-js for now 2017-08-22 12:18:48 +02:00
Dan Stillman
879ed11b69 Update citeproc-js to 1.1.175 2017-08-22 12:18:29 +02:00
Dan Stillman
2919486818 Don't keep checking for lost Z4Fx data directory 2017-08-19 23:47:54 +02:00
Dan Stillman
f45d56113a Remove unnecessary log line 2017-08-19 23:36:39 +02:00
Dan Stillman
0391569f4d Only prompt for recently updated Z4Fx data directories 2017-08-19 23:31:39 +02:00
Dan Stillman
267e3165a2 Add prompt to revert to Zotero for Firefox data directory 
For people affected by migration bugs prior to 5.0.15
 2017-08-19 23:22:07 +02:00
Dan Stillman
d368c4019a Fix data directory migration if only Firefox profile directory 2017-08-19 15:58:42 +02:00
Dan Stillman
6673c64ac6 Fix accessDate when translators set CURRENT_TIMESTAMP 
(But it also seems like we always do that automatically for web
translators, so I'm not sure why so many translators set that.)
 2017-08-19 15:21:57 +02:00
Dan Stillman
2d9284ba26 Update locales from Transifex 2017-08-19 14:45:57 +02:00
Dan Stillman
de36a6e833 Make sure rootDocument is set in Zotero.Translate.Web.setDocument() 
For non-browser documents that we wrap, defaultView.top.document can be
undefined without being inaccessible.

Fixes regression from dae0986b9b
 2017-08-19 05:23:38 +02:00
Dan Stillman
871cbae499 Update citeproc-js to 1.1.174 2017-08-19 05:23:38 +02:00
Dan Stillman
7386b376f3 Fix linked attachment base directory handling at drive root 
The first letter of the relative path was being removed on save if the
base directory was set to the drive root (e.g. D:\ instead of D:\foo).
 2017-08-18 16:06:56 +02:00
Dan Stillman
a4a786bac6 Update locales from Transifex 2017-08-17 16:58:26 +02:00
Dan Stillman
1efe54e896 Fix #1286, Show proper error messages for OS.File errors 2017-08-17 15:43:54 +02:00
Dan Stillman
da2dedf7af Use passed URL rather than doc.location in translator processDocuments 
Outside of page contexts (e.g., from an XHR with responseType =
'document'), document.location is null.
 2017-08-16 17:58:59 +02:00
Dan Stillman
d1de8b751a Update locales from Transifex 2017-08-16 01:46:05 +02:00
Dan Stillman
065bac3b8a Avoid XML Parsing Error for WebDAV requests that don't return Content-Type 
If responseType isn't set and the response doesn't include a
Content-Type header, Firefox tries to parse the file as XML, and if the
file isn't XML it logs an "XML Parsing Error", which includes the
username and password.
 2017-08-16 01:07:10 +02:00
Dan Stillman
db8bb3484d Update password-hiding logic for malformed-XML XHR errors in reports 2017-08-16 00:41:38 +02:00
Dan Stillman
b171b15d87 Don't log WebDAV Authorization header 2017-08-16 00:41:38 +02:00
Adomas Venčkauskas
dae0986b9b Fix a cross-origin frame access error in Translate.Web.setDocument 2017-08-15 15:36:26 +03:00
Adomas Venčkauskas
a5a7df328a Changes imports from connector to save to selected collection 
Closes #1289
 2017-08-15 11:35:53 +03:00
Dan Stillman
c31f0b6b5c Fix <label class="text-link"/> in basic viewer (e.g., Add-ons pane) 
I'm not sure when this stopped working, or whether the Add-ons pane was
in the basic viewer before, but that fixes it.
 2017-08-15 00:36:43 +02:00
Dan Stillman
8797c7f680 Fix error refreshing missing citation without name part 
https://forums.zotero.org/discussion/66789/
 2017-08-14 21:24:31 +02:00
Dan Stillman
a24f16eb85 Don't look up library name for each downloaded file 2017-08-13 03:26:23 +02:00
Dan Stillman
b0826fd91d Update locales from Transifex 2017-08-13 03:09:36 +02:00
Dan Stillman
c9b9d4127d Fix first-run error with some upgrades after 39bfeac86c 2017-08-13 03:00:57 +02:00
Dan Stillman
6bcf92db46 Fix "Open in Library" from Quick Format popup if main window is closed 
Possible now on macOS
 2017-08-12 02:50:27 +02:00
Dan Stillman
c59ae5cf40 Add Zotero.openMainWindow() 
Opens the main Zotero window if it's not open, which is now possible on
macOS.
 2017-08-12 02:49:36 +02:00
Dan Stillman
2770860968 Don't update storage version if file sync is stopped 
Otherwise subsequent syncs won't download the remaining files until
there's a remote storage change.
 2017-08-11 22:29:40 +02:00
Dan Stillman
9069559050 Improve logic for determining whether to check for files to download 
This should fix cases of files not being downloaded after interrupted
syncs until the next time files were changed remotely.
 2017-08-11 22:29:40 +02:00
Dan Stillman
c768d48454 Merge new English strings 2017-08-11 19:15:54 +02:00
Dan Stillman
4c13d51f24 Show files remaining in library in sync button tooltip 2017-08-11 18:25:08 +02:00
Dan Stillman
0df967418b Fix error handling for HTTP.request() with responseType: 'document' 2017-08-11 18:25:08 +02:00
Dan Stillman
9202ab8b3c Download missing attachments as needed even in at-sync-time mode 2017-08-11 16:06:06 +02:00
Dan Stillman
3a2f0e6929 Fix URL opening in some places (since 21cc9f16bf) 2017-08-11 11:51:02 +02:00
Dan Stillman
65d63fad37 Fix opening of some links in About pane 2017-08-10 04:51:58 +02:00
Dan Stillman
21cc9f16bf Move ZoteroPane.launchURL() to Zotero.launchURL() 
And add deprecation warning to ZoteroPane.launchURL()
 2017-08-10 04:49:57 +02:00
Dan Stillman
678a6e15cc Better Unicode path comparison in WebDAV.purgeOrphanedStorageFiles() 2017-08-10 04:41:16 +02:00
Dan Stillman
83fe445f8f Fix error message in WebDAV purgeOrphanedStorageFiles() 2017-08-10 03:59:55 +02:00
Dan Stillman
39bfeac86c Choose most recently used data directory when upgrading to 5.0 
Previously, if someone was upgrading from Zotero for Firefox to 5.0 but
at some point had installed Zotero Standalone and told it not to share
the data directory, 5.0 would use the data directory from the Zotero
profile directory, and people would end up with an empty database with a
Zotero Quick Start Guide from years ago.

This checks for the database with the most recent mtime and uses that
data directory instead. In the Firefox profile, that can be either the
default 'zotero' subdirectory or a custom data directory. If one of the
Firefox locations is used, Zotero prefs are read from Firefox, because
it means that Zotero for Firefox was being used (because if Zotero
Standalone had been in use it would've needed a custom data dir setting
pointing at the Firefox database).
 2017-08-10 03:31:56 +02:00
Dan Stillman
d3833b8afd Ignore stored-file path with no 'storage:' 
There was a report of an imported file with a relative path, probably
from some ancient bug (in our code or a plugin's)
 2017-08-09 02:41:07 +02:00
Dan Stillman
126fb86957 Update locales from Transifex 2017-08-09 02:38:26 +02:00
Dan Stillman
a02eb3c328 Don't stop after one uploaded full-text batch 2017-08-09 02:04:04 +02:00
Dan Stillman
945da5e008 Fix spacing of note editor and parent row in conflict resolution window 2017-08-09 02:04:04 +02:00
Dan Stillman
aea378f105 Fix spacing of full-text index state row 2017-08-09 02:04:04 +02:00
Dan Stillman
782e798973 Merge new English strings 2017-08-09 02:04:03 +02:00
Dan Stillman
07ce273333 Show "Queued" in right pane for unprocessed full-text and allow indexing 2017-08-09 02:01:33 +02:00
Dan Stillman
fffa1badd4 Stop storage requests on shutdown 2017-08-09 02:01:33 +02:00
Dan Stillman
9920a845c6 Don't initialize storage requests until they start 2017-08-09 02:01:33 +02:00
Dan Stillman
6232c83b4b Merge new English strings 2017-08-05 19:47:59 +02:00
Dan Stillman
a0a2502947 Allow debug output logging to be enabled after later restart 
With the new system, it wasn't possible through the UI to generate debug
output for another action that happened after a restart, since it just
restarted immediately. This adds a prompt after selecting the menu
option that allows for restarting now, restarting later, or cancelling.
 2017-08-05 19:44:58 +02:00
Dan Stillman
b3b9cac078 Fix "Copy as HTML" Quick Copy setting 2017-08-05 03:13:33 +02:00
Dan Stillman
34e23937a1 Remove pointless Bluebird lines from various stack traces 2017-08-05 01:09:57 +02:00
Dan Stillman
7b0ed6da81 Don't unlink account on key info request connection failure 
This can happen when the computer is offline but that hasn't been
detected for some reason.
 2017-08-05 01:07:49 +02:00
Dan Stillman
198fb28e20 Resolve schema update promise even if repository update fails 2017-08-04 16:48:21 +02:00
Dan Stillman
2b3f6b4f1f Update locales from Transifex 2017-08-04 00:42:32 +02:00
Adomas Venčkauskas
492293ef84 Fix a wrong cookieSandbox condition for /connector/saveSnapshot 2017-08-02 15:43:55 +03:00
Dan Stillman
03f8c5fa99 Merge new English strings 2017-07-31 05:47:03 -04:00
Dan Stillman
c6ab18634d Improve data directory startup error handling 
Better instructions and behavior if the data directory is inaccessible
or missing, including automatically detecting a directory at the default
location if the configured directory is missing and offering to use the
default instead. Together, this means that if, say, security software
prevents Zotero from accessing the data directory within the Firefox
profile, it will suggest that the user move it to ~/Zotero and then
prompt to use that directory.
 2017-07-31 05:42:16 -04:00
Dan Stillman
cd86cfca98 Update locales from Transifex 2017-07-30 15:32:18 -04:00
Dan Stillman
33eb31d6e2 Fix typo from 991967d5b 2017-07-30 15:25:10 -04:00
Dan Stillman
5123c21e0d Don't close Zotero on macOS when window is closed 
Keep the application open with limited menus, including a Window ->
Zotero option bound to (Cmd-0) that can be used to reopen the main
window.

This allows Zotero to use almost no CPU (instead of a few percentage
points when the window is open, even when hidden with Cmd-H, though it'd
be nice to fix that) and still allow saves from the connector.

There might be some things that aren't being destroyed properly when the
window is closed or other bugginess, but it seems to work pretty well.
 2017-07-30 07:52:58 -04:00
Dan Stillman
a8ba2fac33 Don't rely on last browser window to open prefs from menu 2017-07-30 07:42:56 -04:00
Dan Stillman
ee0b4f5d0d Use nsIWindowWatcher in Zotero.openInViewer() 
Instead of getting the last browser window
 2017-07-30 07:37:34 -04:00
Dan Stillman
991967d5bc Refactor and improve target selection in connector server 
Fall back to lastViewedFolder if no active Zotero pane
 2017-07-30 07:34:22 -04:00
Dan Stillman
a92acfe7c4 Fix 2x icons in Timeline 2017-07-30 03:58:11 -04:00
Dan Stillman
ac7c22a7c6 Fix searches for PowerPoint files 
This also adds a mechanism for indicating that DB userdata upgrades
after a certain version are minor and shouldn't show "Upgrading
database…" or create a pre-upgrade backup.
 2017-07-30 00:06:59 -04:00
Dan Stillman
9652b9f553 Fix logged errors and debug messages in timeline 2017-07-29 22:17:08 -04:00
Dan Stillman
168e4e4b45 Default month/day to 01 in Timeline if missing 
This causes any item with just a year to show up at the start of the
year (instead of just not showing up, which I think was the case
before). Unfortunately they can then go out of view, and it's not
possible to scroll to view more, though that could probably be fixed.
 2017-07-29 22:17:08 -04:00
Dan Stillman
fba412fe4a Hide broken Timeline copyright image (listed in About pane anyway) 2017-07-29 22:17:04 -04:00
Dan Stillman
23d4992265 Fix Zotero.Utilities.Internal.getAsyncInputStream(), used by Timeline 2017-07-29 22:11:56 -04:00
Dan Stillman
a6564e92d7 Update proxy authentication URLs 
And try all, since it doesn't do any of this unless there's a PAC file,
it's not actually a network request unless the site should be proxied,
and it should only make a single HEAD request unless a previous one
fails.

There's a possibility some proxies are limited to HTTP, in which case
changing these to HTTPS might stop this from working. If so, we'd need
to add back HTTP addresses.

Closes #1273
 2017-07-28 20:41:10 -04:00
Dan Stillman
ae22ce7ecd Update locales from Transifex 2017-07-28 19:34:39 -04:00
Dan Stillman
884d03b12a Remove prompt when adding style manually 
(And prompt was showing "(null)")
 2017-07-28 19:34:20 -04:00
Dan Stillman
34b99fb71c Merge new English strings 2017-07-28 19:17:11 -04:00
Dan Stillman
d252a09cd3 Update Quick Copy menu options based on current settings and URL 
Show "Copy Citation" and "Copy Bibliography" when a bib format is
selected and "Copy as BibTeX", etc., when an export is selected. If a
site-specific setting is in effect from the last active URL, use that
instead.

If no regular items are selected in bib mode, the menu options are
disabled.

This also now filters non-regular items out when in bib mode -- before
if you selected a combination it would include a bunch of 'n.d.' lines.

Closes #1155, Disable Copy Citation menu option when a translator is
selected for Quick Copy
 2017-07-28 19:11:39 -04:00
Dan Stillman
72fbee5523 Fix crash switching from Notes tab to feed item 2017-07-27 00:11:13 -04:00
Dan Stillman
c110e64293 Consider fulltextItems with SYNC_STATE_MISSING as unindexed 
The items will still match full-text word searches, but they won't match
phrase searches (because those require cache files for non-text
attachments) and the full-text won't sync to other computers, so they
should really be reindexed.
 2017-07-26 22:16:01 -04:00
Dan Stillman
67ccb632b4 Don't keep looking for unsynced full-text content that isn't available 
This can happen if cache files are deleted for PDF attachments or if
text files are missing.
 2017-07-26 22:16:01 -04:00
Dan Stillman
10637ca9ea Switch to OS.File for most full-text file access 2017-07-26 22:16:01 -04:00
Dan Stillman
61f8a2c3c5 Fix various problems with fulltextContent searches 
Including finding items in the wrong library and not finding any items
when paired with the checkboxes in ANY mode
 2017-07-26 22:16:01 -04:00
Dan Stillman
36371630b5 Restore auto-expanding of search matches except in My Publications 
Saved searches and the trash should automatically expand items to show
matching child items, but that was broken in d47275210.
 2017-07-26 22:16:01 -04:00
Dan Stillman
46531a4c69 Remove non-matching parent items when deleting items from trash 
Fixes #866, Trash doesn't refresh properly when emptying deleted
attachments
 2017-07-26 22:16:01 -04:00
Dan Stillman
e475b22f1d Add intl.accept_languages from Mozilla language packs 2017-07-25 16:27:31 -04:00
Dan Stillman
d8b201487d Allow clearing global prefs 2017-07-25 15:44:49 -04:00
Dan Stillman
c6e4722289 Update locales from Transifex 2017-07-25 15:32:41 -04:00
Dan Stillman
521f291b84 Fix PluralForm support 
The library was using the plural rule defined in the built-in
intl.properties, but that was always en-US in the standalone app.
 2017-07-25 15:20:23 -04:00
Dan Stillman
3bb8b5d24d Merge new English strings 2017-07-25 03:08:43 -04:00
Dan Stillman
d01366a2f1 Remove line from Report Errors about messages possibly unrelated to Zotero 2017-07-25 03:01:45 -04:00
Dan Stillman
c2bb4ac10b Move debug output logging to the Help menu 
Adds a submenu for quickly generating and submitting debug output, with
a button to copy the Debug ID to the clipboard and a one-click option to
restart with logging enabled. Debug output can also now be viewed in
real-time using the new debug output viewer window (previously available
only via a command-line flag).

The locale switcher has moved to the top of the Advanced prefpane (where
Debug Output Logging used to go) in a Miscellaneous section, and there's
a new "Advanced Configuration" section (mirroring Thunderbird) at the
bottom for "Config Editor".

Closes #1108
 2017-07-25 03:00:39 -04:00
Dan Stillman
e3947e7b45 Debug output viewer tweaks 
- Decrease font size
- Do a better job of pinning to bottom
- Disable submit button when clearing output
- Filter ANSI color codes from slow lines
 2017-07-25 02:41:50 -04:00
Dan Stillman
eb1cecf404 "Submit Feedback…" -> "Discussion Forums" 2017-07-25 02:30:28 -04:00
Dan Stillman
a9594360cd Deprecate Zotero.Utilities.Internal.quitZotero() in favor of quit() 2017-07-25 02:29:26 -04:00
Dan Stillman
695dd4e65d Don't omit first line in debug output when submitting 2017-07-24 22:49:17 -04:00
Dan Stillman
6ae2b58d3f Update submodules 2017-07-24 08:59:23 -04:00
Dan Stillman
d5759e3724 Update locales from Transifex 2017-07-24 08:58:31 -04:00
Dan Stillman
34d039ba48 Fix a whole mess of issues with data directory migration 
- If an error occurred while moving the database file, the data
  directory could end up pointing to the new, empty directory after a
  restart
- The error message for a full failure was missing the second half that
  actually explained that you were supposed to move the data directory
- The check for different-drive migrations didn't work if the new
  directory didn't exist (at least on macOS), swallowed some errors, and
  interfered with manual migrations from the prefs
- The manual migration button would say that the new directory wasn't
  empty even if it just contained .DS_Store
- Don't show "Database migration in progress" after not restarting after
  a migration failure

Additionally, after a full failure the migration is now attempted on
every restart and displays a warning each time, since otherwise people
will never move their directories out of the Firefox profile (which is
when it's going to fail the most, due to security software).
 2017-07-24 08:51:02 -04:00
Dan Stillman
05ea309e2e Use proper locale format for dates in items list 
2addf6b27b fixed the date order used when automatic locale detection was
enabled, but this fixes the format (e.g., dots instead of slashes). It
should now match the item pane. I'm not sure why we weren't doing this
before, but hopefully we didn't have a good reason.
 2017-07-23 15:12:09 -04:00
Dan Stillman
a9f0096929 Update locales from Transifex 2017-07-23 01:11:26 -04:00
Dan Stillman
db496e13c2 Increase font size and decrease style list height in doc prefs 
On macOS this shows all default styles without a scroll bar.
 2017-07-23 00:57:04 -04:00
Dan Stillman
ef71a2c77c Use HTTPS for Google Scholar in Retrieve Metadata for PDF 2017-07-23 00:57:04 -04:00
Dan Stillman
225215842d Fix auto-syncing of unchecked groups after object change 2017-07-21 19:39:37 -04:00
Dan Stillman
6d2c72fb54 Fix revealing parent directory of missing file 
Updates Zotero.File.getClosestDirectory() to take a path rather than an
nsIFile
 2017-07-21 18:33:36 -04:00
Dan Stillman
b033dedddc Fix broken WebDAV orphaned-file purging after 39a8e8fb0c 2017-07-21 08:39:43 -04:00
Dan Stillman
efe8b65f84 Update non-English locales 2017-07-21 07:54:45 -04:00
Dan Stillman
faecefa375 Rename/reorganize Advanced prefs buttons 
- Move csledit and cslpreview to a Tools section of the Cite pane as
  Style Editor and Style Preview
- Rename "Open about:config" to "Config Editor"
- Hide about:memory unless devtools.errorconsole.enabled is enabled,
  which isn't particularly appropriate and maybe we can find something
  better, but about:memory doesn't really need to be visible by default

Closes #1264
 2017-07-21 07:53:50 -04:00
Dan Stillman
33b40829b8 Add locale switcher to Advanced prefs 
Closes https://www.zotero.org/trac/ticket/1733 (!)
 2017-07-21 07:51:57 -04:00
Dan Stillman
2addf6b27b Get Zotero.locale from loaded locale, not from pref 
It was previously set from general.useragent.locale, but that's not used
by default, meaning that date interpretation and some other things might
have been incorrect for everyone who didn't set a locale explicitly and
toggle matchOS...
 2017-07-21 07:51:57 -04:00
gracile-fr
2bd3aa9669 Remove reference to Actions menu (to Report Error) 
"Report Errors" menu item was in Actions (gear) menu, which has been
hidden in 5.0 (cf. 82292eef77). It is now
accessible from the Help menu.
Adjust Report Error instructions accordingly.
 2017-07-21 07:44:24 -04:00
Adomas Venčkauskas
40c84ecbc0 Report automaticSnapshots pref to connector. 
Part of zotero/zotero-connectors#151
 2017-07-21 11:36:36 +03:00
Dan Stillman
39a8e8fb0c Send Content-Type: text/xml header for WebDAV PROPFIND 2017-07-21 04:05:12 -04:00
Dan Stillman
a7be5444ea Fix tag selector search (broken in 6de7fdedf) 2017-07-20 16:51:50 -04:00
Dan Stillman
6de7fdedf9 Take tag selector out of the tab order, for now 
This restores the 4.0 behavior. It's not ideal, but neither is having to
tab through thousands of items to get to the items pane (unless you
toggle the tag selector closed first). Hopefully we can come up with a
better solution to make the tags accessible.
 2017-07-20 03:46:56 -04:00
Dan Stillman
c39bdaa25b Update locales from Transifex 2017-07-20 03:46:56 -04:00
Dan Stillman
cbc05baf02 Fix error on connector ping before site-specific Quick Copy load 2017-07-20 03:46:56 -04:00
Adomas Venčkauskas
ece3491e21 Connector server: respond with collection editability status 2017-07-19 11:40:55 +03:00
Dan Stillman
97d46b79f1 Update locales from Transifex 2017-07-19 04:08:26 -04:00
Dan Stillman
a158e8a71b Alter Quick Copy preferences text 
Closes #1022

Could try to explain site-specific settings, but it's somewhat
complicated (requires the Zotero Connector, uses the last active tab
regardless of drag destination), so maybe enough to explain on the
linked documentation page.
 2017-07-19 03:57:39 -04:00
Dan Stillman
b3ce918dfb Sort export translators in Quick Copy settings drop-downs 2017-07-19 03:39:51 -04:00
Dan Stillman
6d265f448f Restore site-specific Quick Copy settings 
Using the last URL passed by a connector

Closes https://github.com/zotero/zotero-connectors/issues/145
 2017-07-19 03:39:27 -04:00
Dan Stillman
2928752d19 Clear attachment data change marker when loading primary data 
Fixes a regression from ef7da3486a in which attachment data still shows
as changed after a save.
 2017-07-18 18:50:28 -04:00
Dan Stillman
cff84a71ed Simplify an array check 2017-07-18 17:32:38 -04:00
Dan Stillman
df353bdc05 Optimistic updates for item tags box 
Add/update/remove rows immediately and save after. If there's an error
during saving, reload the pane.
 2017-07-18 17:32:38 -04:00
Dan Stillman
ef7da3486a New state-handling approach for item tag changes 
If this works out I think we'll want to use this approach for
all data layer changes.

Previously, an unsaved change on an object would update its state
immediately, which was fine for synchronous code but breaks down if a
save involves multiple asynchronous calls, because modifying state after
the relevant data has been saved to the DB but before the `_changed`
object has been cleared would mean that new changes would be lost. Now,
changes are written to _changedData, and a get for the data first checks
_changedData before checking the state property (e.g., _tags) directly.
The changedData property is cleared as it's written, and once the object
is saved, the reload updates the state property with the new data.
 2017-07-18 17:31:40 -04:00
Dan Stillman
09a859d7e3 Allow an array of strings in Zotero.Item::setTags() 
New tags will all be of type 0 (manual)
 2017-07-18 17:21:36 -04:00
Dan Stillman
3715c8da1b Fix use of multiple search translators 
It was stopping after the first translator, which meant that some ISBN
lookups failed if the ISBN wasn't in Library of Congress.

Regression from 6da0845f4b, which hopefully didn't have a good reason
for this
 2017-07-18 07:13:03 -04:00
Dan Stillman
5268060802 Move Tools -> Options to Edit -> Preferences on Windows 
Closes #1167
 2017-07-18 04:14:17 -04:00
Dan Stillman
76030d2c4a Fix tag selector font on Windows 2017-07-18 04:14:17 -04:00
Adomas Venčkauskas
6d7dcc44bc Add connector endpoint to retrieve proxies. Closes #1265 2017-07-18 10:25:54 +03:00
Dan Stillman
cf5a943ec6 Update locales from Transifex 2017-07-17 18:25:21 -04:00
Dan Stillman
78dd1e132e Fix calculation of last WebDAV orphaned-file-purge time 
Purging was happening after every download.
 2017-07-17 16:53:11 -04:00
Dan Stillman
ba514b80d9 Add "Remove All Tags…" option to item tags box context menu 2017-07-17 16:34:52 -04:00
Dan Stillman
918ae23418 Increase default window size to 1000x600 
(Plus a little, I think)
 2017-07-17 16:34:52 -04:00
Adomas Venčkauskas
f829e4d6cc Fix an integration.js typo. Closes #1263 2017-07-14 13:40:44 +03:00
Dan Stillman
7ef7a84122 Update locales from Transifex 2017-07-14 05:12:28 -04:00
Dan Stillman
0f965b0de6 Fix collection context-menu options broken in 02774ac6f 
E.g., selective sync
 2017-07-14 01:06:57 -04:00
Dan Stillman
57881ff587 Fix restoring after closing from full-screen mode on macOS 2017-07-13 18:27:06 -04:00
Dan Stillman
ea513edf73 Prevent infinite loop if search points to itself 2017-07-13 18:07:58 -04:00
Dan Stillman
0513cd0eef "Report Errors to Zotero…" -> "Report Errors…" 2017-07-13 17:41:35 -04:00
Dan Stillman
0c49350cdf Fix startup error from empty 'collection' search condition 2017-07-13 16:10:33 -04:00
Dan Stillman
542d68cc4c Update locales from Transifex 2017-07-13 03:38:21 -04:00
Dan Stillman
df24917c2f Fix #1260, Windows Application (menu) key doesn't work in items pane 2017-07-13 03:26:28 -04:00
Dan Stillman
2d8132b6c8 Log URL for snapshot save timeouts 2017-07-13 02:33:28 -04:00
Dan Stillman
1247896d70 Fix crash from tag name collision with Object properties in tag selector 2017-07-13 01:19:15 -04:00
Dan Stillman
4ffbf6fca5 Use DOM_VK_* codes in itemTreeView keypress listener 2017-07-13 01:19:15 -04:00
Dan Stillman
dd5d3a8668 Fix blank window when opening ZotFile's zotero://open-pdf links 
Fixes https://github.com/jlegewie/zotfile/issues/272
 2017-07-12 18:25:49 -04:00
Dan Stillman
752e25e282 Fix id-not-an-integer warning from Show in Library 2017-07-12 15:44:49 -04:00
Dan Stillman
02774ac6fe Fix collection-menu selection via right-click->drag->release or keyboard 2017-07-12 15:43:20 -04:00
Dan Stillman
aad12db2ff Fix 'too many terms in compound SELECT' sync error 2017-07-12 04:21:52 -04:00
Dan Stillman
8f2508e167 Fix alignment of "What's New" in About window 2017-07-12 03:38:14 -04:00
Dan Stillman
e841d62360 Update locales from Transifex 2017-07-12 03:27:10 -04:00
Dan Stillman
fd2ba1d5b7 Fix file sync error on Windows from attachment paths with invalid characters 
We filter these now, but upgraded databases with bad paths could still
exist and cause errors.
 2017-07-12 02:58:25 -04:00
Dan Stillman
a62161dfc1 Add unused Zotero.Prefs.resetBranch() 
I wrote this for account unlinking (since nsIPrefBranch.resetBranch()
isn't implemented) but decided we didn't want to delete all prefs for
that.
 2017-07-12 01:20:55 -04:00
Dan Stillman
a7021f80ca Remove unused skipDefaultData property 2017-07-12 01:20:18 -04:00
Dan Stillman
efae7073f2 Avoid log message about json.collections being unknown after e683b2be0 2017-07-12 01:19:53 -04:00
Dan Stillman
d1d62184be Fix potential error loading support links 
From ZOTERO_CONFIG not being defined. I can't reproduce this, but I've
seen it in the logs.
 2017-07-12 01:18:41 -04:00
Dan Stillman
62fa86af82 Fix error on account unlink, and delete more files 
Delete everything from data directory except for PDF tools
 2017-07-12 01:16:25 -04:00
Dan Stillman
d2421825c9 Fix #1256, Report saving is broken 2017-07-11 06:14:21 -04:00
Dan Stillman
b53e5b96ef Update locales from Transifex 2017-07-11 04:54:53 -04:00
Dan Stillman
a982bd056d Zotero.Item::_collections is always an array 2017-07-11 04:46:09 -04:00
Dan Stillman
18f3c2cfb0 Fix "destFile is not defined" file sync error 2017-07-11 04:37:23 -04:00
Dan Stillman
375b4341a6 Remove debug lines 2017-07-11 04:29:36 -04:00
Dan Stillman
701a46ba84 Batch object deletions during syncing 2017-07-11 04:28:40 -04:00
Dan Stillman
fd7c2a6f6f Try harder to prevent sync-in-progress messages 2017-07-11 02:42:00 -04:00
Dan Stillman
c701f34aaa Fix array length check in Item.setType() 2017-07-11 02:41:41 -04:00
Dan Stillman
e683b2be07 Fix a potential sync error with child attachments 
If a standalone attachment existed in a collection and then was added to
a parent (e.g., via Create Parent Item), and attachment metadata was
also changed at the same time (e.g., due to file syncing), the
'collection item must be top level' trigger could throw on another
syncing computer. To work around this, remove collections first, then
make changes to the parentItemID columns, and then add new collections.
 2017-07-11 02:35:11 -04:00
Dan Stillman
3272387afe Increase snapshot save timeout to 30 seconds 
We should maybe have a shorter timeout in the connector to show an error
and avoid showing the save-to-server dialog, but let's err on the side
of not cancelling saves.
 2017-07-09 23:31:25 -04:00
Dan Stillman
32dedc6fb4 Cancel snapshot saves after 15 seconds 
Otherwise a save could go on forever and the connector will never show
an error, and if you quit Zotero the connector will show the
save-to-server dialog (though the connector should have its own
timeout).
 2017-07-09 23:17:30 -04:00
Dan Stillman
e551777989 Vacuum database automatically on successful integrity check 
Firefox does this for Places, so we might as well too.
 2017-07-09 18:17:15 -04:00
Dan Stillman
6ffd7b11cb Update locales from Transifex 2017-07-09 18:09:38 -04:00
Dan Stillman
55b2dc39bf Fix Firefox 55 breakage (and remove unnecessary locale lookups) 
We were manually looking up the current locale in various places and
passing it to nsIStringBundleService::createBundle(), but that hasn't
even been a supported argument for years. (I assume it was a long time
ago?)
 2017-07-09 06:59:50 -04:00
Dan Stillman
59edca783e Allow dragging onto welcome text 2017-07-09 05:49:02 -04:00
Dan Stillman
91512469d5 Make About window narrower 2017-07-08 21:32:07 -04:00
Dan Stillman
2ca10b3d54 Update non-English strings 2017-07-08 19:14:34 -04:00
Dan Stillman
a7e2e73e51 Update About dialog 
- Replace Developers section with text that links to RRCHNM, the credits
page, and Get Involved.
- Remove dedicated zotero.org link
- Only show link underlines on hover
 2017-07-08 19:11:45 -04:00
Dan Stillman
73ac74332c Update locales from Transifex 2017-07-08 17:49:42 -04:00
Dan Stillman
2ba773d612 Additional checks for stopped sync 2017-07-07 19:05:22 -04:00
Dan Stillman
043c0ac6b7 Update locales from Transifex 2017-07-07 18:29:38 -04:00
Dan Stillman
de3b47fd78 Add "Delete Automatic Tags in This Library…" option to tag selector menu 
I think it might be worth having a tag management window that lets you
view tags as a grid, sort by column (e.g., type), select ranges, delete,
consolidate, etc., but until then, this fulfills a popular request.
 2017-07-07 18:19:12 -04:00
Dan Stillman
941ae5499c Use spread operator in flattenArguments 2017-07-07 18:19:12 -04:00
Dan Stillman
f2af77498b Allow single string in Zotero.Utilities.pluralize() 
Zotero.Utilities.pluralize(5, 'tag') will produce 'tags' automatically
 2017-07-07 18:19:12 -04:00
Dan Stillman
e2d7c7e999 Fix full-text sync tests after 1da18e4ca7 2017-07-07 06:23:27 -04:00
Dan Stillman
c55cacfb5a Update 2x icon styles 2017-07-07 05:31:37 -04:00
Dan Stillman
3b2d7eb970 Log errors from Zotero.serial() 
And output errors in concurrentCaller if not otherwise logged
 2017-07-07 05:31:37 -04:00
Dan Stillman
71fb054efe Update deprecated openPreferences() call 2017-07-07 05:31:37 -04:00
Dan Stillman
cb913ffccb Update non-English strings 2017-07-07 05:31:36 -04:00
Dan Stillman
1da18e4ca7 Add "Stop Sync" button 
Stops all syncing (not just file syncing like in 4.0) as soon as
possible.
 2017-07-07 05:28:20 -04:00
Dan Stillman
7729dcafc0 Update non-English strings 2017-07-07 03:41:50 -04:00
Dan Stillman
b07fdc6335 Add intro text to middle pane when My Library is empty 
This replaces the Quick Start Guide item in earlier versions.

Also increases size of My Publications intro text when the window is
wider.
 2017-07-07 03:41:50 -04:00
Adomas Venčkauskas
1ddb38036e Moving Utilities.itemToServerJSON() to the connector codebase 
See Zotero.Item.toJSON() for similar functionality
 2017-07-06 13:38:00 +03:00
Dan Stillman
f7c1c56d7d Use 'async' configOptions property to indicate promisified translators 
Instead of >"2017-07-05"

Addresses https://github.com/zotero/translators/issues/1353
 2017-07-05 15:29:13 -04:00
Dan Stillman
5ff5ea88fb Fix error in export options window if translator has no options 2017-07-05 15:25:41 -04:00
Dan Stillman
53c3f62f1e Fix overlapping lines in attachment box with empty title 2017-07-05 11:33:24 -04:00
Dan Stillman
198bd70b59 Make 909b4b31c8 apply to search translators too, and fix tests 
Addresses https://github.com/zotero/translators/issues/1353
 2017-07-05 09:15:12 -04:00
Dan Stillman
909b4b31c8 Assume import translators updated after today are async 
See https://github.com/zotero/translators/issues/1353 for details.

minVersion is problematic for various reasons, so this is safer.
 2017-07-05 08:54:27 -04:00
Dan Stillman
d73fc63273 Do a manual check from the repo when enabling auto translator/style updates 2017-07-05 05:45:30 -04:00
Dan Stillman
d40822c540 Fix streaming server connection when auto-sync is on with no credentials 2017-07-05 05:45:00 -04:00
Dan Stillman
22e99a421c Update locales from Transifex 2017-07-05 05:17:18 -04:00
Dan Stillman
86cf7cbd07 Update translators/styles at startup and on push notifications 
Previously, if a translator or style was fixed, people didn't get the
fix until their client checked the repository for updates, which could
take up to 24 hours. Now, in addition to checking once a day, we check
every time Zotero is started and also when we receive a notification
from the streaming server, which happens immediately after a translators
or style is updated on GitHub. To avoid DDoSing ourselves, the
notification includes a random delay (within a given period) before the
update is triggered by the client.

The streaming server connection is now made when either "Automatically
check for updated translators and styles" or "Sync automatically" is
enabled. It can be disabled via the extensions.zotero.streaming.enabled
pref.
 2017-07-04 18:46:30 -04:00
Dan Stillman
b476c7c7c5 Update locales from Transifex 2017-07-03 03:11:18 -04:00
Dan Stillman
c867b3bb85 Fix WebSocket reconnect delay 
Only reset delay generator after regular message, not on connect,
because a subscription failure happens after a connect. Also cancel
reconnect if auto-sync is disabled during the failure delay.
 2017-07-02 01:44:22 -04:00
Dan Stillman
2efd7121b8 Only skip retry for WebSocket errors between 4400 and 4499 2017-07-02 01:32:47 -04:00
Dan Stillman
72feaab6f4 Update locales from Transifex 2017-07-01 07:07:31 -04:00
Dan Stillman
dc89cfb3ba Clean up Sync -> Reset pane 
- Hide radio buttons for now, since there's only one option in each
section
- Tweak text for file sync history reset
 2017-07-01 06:58:56 -04:00
Dan Stillman
88088c68db Add Sync.Storage.Local.updateSyncStates() 
This speeds up updating of sync states, particularly after resetting
file sync history.
 2017-07-01 06:31:46 -04:00
Dan Stillman
b72f1c2a08 Don't calculate total file size for every uploaded attachment 
This required checking the file size of every file (including auxiliary
snapshot files) in every attachment to be uploaded, and it was an
estimate anyway, because snapshots are compressed, so we kept track of
the compression ratio, but there was no particular reason to think later
files would have the same ratio... In any case, we're not currently
displaying file sync progress in 5.0 anyway, and while we should, we can
probably just show a count of attachments remaining.
 2017-07-01 06:31:46 -04:00
Dan Stillman
9a3ff2d244 Add .contentType and .charset options for importFromFile() 
And use them in new importTextAttachment() and importHTMLAttachment()
test support functions. These can be used to avoid needing a hidden
browser for determining the character set of the imported text
documents.
 2017-07-01 06:31:46 -04:00
Dan Stillman
b633038bf9 Close directory iterator in Attachments.hasMultipleFiles() 
This was leaving a file descriptor to the directory open during file
syncing.
 2017-06-30 18:08:46 -04:00
Dan Stillman
22eab3e09d Don't leave file descriptor open in md5Async() 
This could cause "Too many open files" errors during file syncing
 2017-06-30 17:54:33 -04:00
Dan Stillman
536d7254fb Detect full disk during data migration on Windows (hopefully) 2017-06-30 16:59:33 -04:00
Dan Stillman
010bf3b8f9 Fix "not a directory" file sync error 2017-06-30 16:59:17 -04:00
Dan Stillman
16b2e82f74 Update non-English strings 2017-06-29 04:11:22 -04:00
Dan Stillman
aca774e132 Move connector install option to Tools menu 
And rename from "Install Browser Connectors…" to "Install Browser Connector"
 2017-06-29 04:08:32 -04:00
Dan Stillman
2119b5ab75 Update non-English strings 2017-06-27 16:26:48 -04:00
Dan Stillman
f6ac1732f2 "Install Browser Extensions" -> "Install Browser Connectors" 
And change link from /extensions to /download/connectors
 2017-06-27 16:26:13 -04:00
Dan Stillman
a56af4a101 Merge new English string 2017-06-27 01:10:27 -04:00
Dan Stillman
9b54ca9ca7 Show error and doc prefs if style can't be found or retrieved 
Previously a 404 downloading the file would prevent opening the doc
prefs window.
 2017-06-27 01:09:01 -04:00
Dan Stillman
a15261b3b3 Don't enforce Host header in translation server 
Fixes #1251
Fixes zotero/translation-server#48
 2017-06-26 19:04:24 -04:00
Dan Stillman
b2eea914e4 Update locales from Transifex 2017-06-26 19:00:08 -04:00
Dan Stillman
1d564970dc Add "Install Browser Extensions…" menu option 2017-06-26 18:49:31 -04:00
Dan Stillman
9372979fb5 Allow Zotero.Server requests with Host: localhost 
Previously only Host: 127.0.0.1 was allowed. (The check prevents a DNS
rebinding attack.)

This allows requests to translation-server using localhost
(zotero/translation-server#48).

Fixes #125
 2017-06-26 07:52:23 -04:00
Dan Stillman
df2216960b Fix permissions errors in child translators in translation-server 2017-06-26 07:21:18 -04:00
Adomas Venčkauskas
2414ec6472 Fix a debug log line 2017-06-26 09:49:41 +03:00
Dan Stillman
56f9f04340 Partial fix for CSL JSON export in translation-server 
Zotero.Item doesn't exist in translation-server

Addresses zotero/translation-server#12
 2017-06-25 04:38:50 -04:00
Dan Stillman
145a45e8e1 Support false as deprecated translate() argument 2017-06-24 19:24:29 -04:00
Dan Stillman
8f63a5e20d Check for Zotero.Prefs.getAsync() explicitly, not with isConnector 
translation-server doesn't have Zotero.Prefs.getAsync() and isn't a
connector
 2017-06-24 19:23:02 -04:00
Dan Stillman
2ab46d3697 Update citeproc-js to 1.1.171 2017-06-24 01:24:11 -04:00
Dan Stillman
d8f8d8a3f8 Fix infinite loop restoring from trash if item has itself as relation 2017-06-24 01:23:39 -04:00
Dan Stillman
e89778c1ab Remove some code that's unnecessary now that we're Fx52+ everywhere 2017-06-23 05:03:11 -04:00
Dan Stillman
92435f398d "A new database file has been created" -> "A new database has been created" 2017-06-21 17:03:38 -04:00
Dan Stillman
79b98ddc54 Tweak incompatible-DB error text 2017-06-21 17:02:01 -04:00
Dan Stillman
f2cc2204c9 Fix for some child items not showing up 
https://forums.zotero.org/discussion/66140/5-0-beta-missing-item-attachments
 2017-06-21 06:50:35 -04:00
Dan Stillman
38652f9362 Merge new English strings 2017-06-20 23:12:15 -04:00
Dan Stillman
abf08deb9d Update broken string in ancient-database dialog 2017-06-20 22:54:05 -04:00
Dan Stillman
3259b63081 Fix error from f3b461ae1d when no duplicate items found 2017-06-20 05:58:12 -04:00
Dan Stillman
041f79379c Fix getAsync() integer warning when highlighting item collections 2017-06-20 05:48:38 -04:00
Dan Stillman
f3b461ae1d Don't use DB transaction when loading Duplicates Items 
This should help avoid some timeouts when clicking into that view.
 2017-06-20 05:48:38 -04:00
Dan Stillman
a2d874c8bc Don't schedule feed checks during tests 
Tests create lots of fake feeds with invalid URLs, so auto-updating
would otherwise hang and block the explicit feed updates done by other
tests.
 2017-06-20 05:48:38 -04:00
Adomas Venčkauskas
dcfddac519 Refactor Connector.callMethod calls to use the promisified form 2017-06-19 14:58:59 +03:00
Dan Stillman
7c020da594 Don't run feeds update until after schema update promise 
And tweak feed scheduling in general
 2017-06-19 01:25:03 -04:00
Dan Stillman
1372949523 Don't initialize DB backup idle observer until after schema init 2017-06-19 00:49:34 -04:00
Dan Stillman
b590c43edb Disable reset translators/styles buttons while in progress 
We should have a better progress notification, but this is better than
nothing.
 2017-06-19 00:43:24 -04:00
Dan Stillman
444d77958d Retry objects from sync queue on first sync of session and manual sync 
Previously they were retried only on a backoff schedule and after a
client upgrade, but that would make it difficult to report errors
(because you'd see the error but it would then go away if you clicked
Sync again).
 2017-06-18 15:37:26 -04:00
Dan Stillman
15a0f3bbe3 Add getKeys() method to API Client 2017-06-18 09:11:21 -04:00
Dan Stillman
47741e75fa Restore locally deleted collections and searches that changed remotely 
Also restore items that were in the collections
 2017-06-18 09:11:21 -04:00
Dan Stillman
24b43ae3a7 "Zotero Standalone" -> "Zotero" in a couple messages 2017-06-17 23:05:39 -04:00
Dan Stillman
6144c8f969 On missing data dir, remove "Restart Later" for "Use Default" option 2017-06-17 22:30:09 -04:00
Dan Stillman
13283b008d Missing data directory tweaks 
- Fix "Locate" button
- Don't offer "Restart Later" option after selecting new location
- Show "Quit" instead of "OK"
 2017-06-17 22:14:02 -04:00
Dan Stillman
859c506913 Never auto-select new groups, since they always come from syncs 
Fixes test failure from 2e74cd7831
 2017-06-16 05:59:44 -04:00
Dan Stillman
2e74cd7831 Don't select new feeds or groups during sync 2017-06-16 05:40:04 -04:00
Dan Stillman
c6cb46907e Disable full-text content processor during sync and on pref off 
Turning off full-text content syncing now stops the background processor
 2017-06-16 04:49:57 -04:00
Dan Stillman
2f93065986 Fix skipClientDateModifiedUpdate DataObject save option 2017-06-16 01:56:43 -04:00
Dan Stillman
8de0b024f0 Fix one cause of "operation timed out" during sync 
Remove some unnecessary transactions in Sync.Data.Local
 2017-06-16 01:53:55 -04:00
Dan Stillman
5c45652887 Try to reduce impact of full-text content processor 
- Don't start checking for idle until UI is ready + 30 seconds
- Increase idle delay from 5 seconds to 30 seconds
- Increase interval from 100 ms to 200 ms
 2017-06-15 18:22:51 -04:00
Dan Stillman
97bac9fadc Move start page URL to config 2017-06-15 02:39:34 -04:00
Dan Stillman
d9eb8ff3c3 Fix "o is undefined" sync error 2017-06-14 07:53:06 -04:00
Dan Stillman
1bb6217ec1 Disable debug output for Zotero.Date.strToDate() 
Too messy, and unlikely that we need it in submitted output
 2017-06-14 03:37:03 -04:00
Dan Stillman
4032edcf7d Ignore note markup conflicts without cache when text content matches 2017-06-14 03:37:03 -04:00
Dan Stillman
ccb30351c0 Fix incorrect purging of files on WebDAV 2017-06-14 03:20:23 -04:00
Dan Stillman
700aa5377b Don't repeat filenames in results from WebDAV _deleteStorageFiles() 2017-06-14 03:20:23 -04:00
Dan Stillman
db6e9841db Only purge orphaned WebDAV files if downloads completed successfully 2017-06-14 02:38:48 -04:00
Dan Stillman
d2d5896b0b Sort groups in Libraries to Sync window 2017-06-13 21:30:25 -04:00
Dan Stillman
88089e290d Update locales from Transifex 2017-06-13 18:03:59 -04:00
Adomas Venčkauskas
a17b486e4b Don't auto-migrate data dir if target on a different drive 
See https://forums.zotero.org/discussion/comment/277632/#Comment_277632
 2017-06-13 17:17:34 -04:00
Dan Stillman
98544edde5 Better logging when revealing attachment in filesystem 2017-06-08 14:13:24 -04:00
Dan Stillman
8913178cf2 Better logging for getAsync() non-integer errors 2017-06-08 14:13:24 -04:00
Dan Stillman
b5424b4a71 Fix context menu options for multi-item selection (broken in 5d16352f57) 2017-06-07 11:50:06 -04:00
Dan Stillman
75ddd879bc Update citeproc-js to 1.1.170 2017-06-06 04:35:38 -04:00
Dan Stillman
b79ecfb5fe Temporarily disable test for non-integer getAsync() 2017-06-05 03:00:15 -04:00
Dan Stillman
71d636e8fb Make non-integer id passed to getAsync() non-fatal for now 
Follow-up to 4e1937680f
 2017-06-04 21:35:54 -04:00
Dan Stillman
4b0e2a9554 Fix separate note window (regression from 4e1937680f) 2017-06-02 10:36:44 -04:00
Dan Stillman
05ff16c17f Fix some breakage from 013dc958b3 2017-06-01 15:39:42 -04:00
Tom Najdek
506b35840e Add a shutdown hook in Zotero.Prefs to unregister observer 
* Without this, preference change observers stack, triggering multiple
  times if Zotero is re-initialized multiple times within the same
  browser instance (like in tests)
 2017-06-01 11:36:17 -04:00
Tom Najdek
14bf3184bb Fixes and tweaks to make tests work with babelized code 
* Use mocha, chai & sinon from the npm. As of sinon 2.0
  sinon-as-promised is no longer required so it is removed
* Tweak code to re-use the same loader with the same environment
  throghout the code
* Introduce browserify step for testing tools that only provide
  node-compatible libraries (sinon, chai-as-promised)
* Introduce copy step for test data to resolve multiple issues with
  tests depending on files not being symlinks
* Re-introduce custom implementation of setTimeout to resolve issues
  with few tests
* Re-introduce custom Bluebird Promises config & monkey patch
 2017-06-01 11:36:16 -04:00
Dan Stillman
a55852ea1c Log Zotero.alert() calls to the terminal 2017-05-31 00:43:57 -04:00
Dan Stillman
61452a835b Fix auto-restore of automatic backup on DB corruption error 2017-05-31 00:43:57 -04:00
Dan Stillman
013dc958b3 Restore cleaner error and item-selection button for note-too-long error 2017-05-31 00:10:00 -04:00
Dan Stillman
5d16352f57 Don't show "Remove Item from Collection" for child items 
Test forthcoming once tests are working again
 2017-05-27 18:38:28 -04:00
Dan Stillman
aa05920117 Don't break getLocaleCollation() in Firefox <54 (after a73b2403b) 2017-05-27 05:38:29 -04:00
Dan Stillman
d6c36ae9a3 Update help URLs and move to config file 2017-05-27 05:32:01 -04:00
Dan Stillman
a73b2403b0 Fix getLocaleCollation() in Firefox 54 2017-05-27 05:32:01 -04:00
Dan Stillman
d5a8a3420d Additional locale service updates for Firefox 54 compatibility 
Follow-up to 0ac37ab65a
 2017-05-26 01:37:54 -04:00
Dan Stillman
7fc188b172 Fix crashing for some actions in duplicate items 
Necessary after more strict error handling in c4411e1ad3
 2017-05-24 18:24:26 -04:00
Dan Stillman
8bc76dd2db Restore logging of unhandled errors from Bluebird (since 9aa057edee) 2017-05-24 18:24:26 -04:00
Dan Stillman
aa321f3495 Add example async/await to test Babel transform 2017-05-24 00:59:45 -04:00
Dan Stillman
6afc58a629 Move require() into ZoteroContext and fix Bluebird module path 2017-05-24 00:58:41 -04:00
Dan Stillman
319edae7f2 Update citeproc-js to 1.1.169 2017-05-23 17:39:10 -04:00
Tom Najdek
9aa057edee Introduce a build system 
* Add a multi-process, gulp-based build system to support es6 features,
  async/await, jsx and scss
* Add a package.json to support dependency management and allow starting
  the build process via npm
* Replace embedded Bluebird library with npm-installed one
* Add react, react-dom and web-library
* Introduce a custom require() loader in include.js as well as a minimal
  local require() implementation in various other places
 2017-05-23 17:02:50 +01:00
Dan Stillman
e1fb28faa9 Convert some object ids from strings to integers after 4e1937680 2017-05-23 02:10:26 -04:00
Dan Stillman
4e1937680f Throw error if non-number is passed to Zotero.DataObjects.getAsync() 
Previously, if an id was psased as a string and the id existed in the
cache, an error wouldn't be thrown, but if there id wasn't in the cache
(e.g., because it was in an unloaded library) it would. This requires an
integer in all cases.

Note that, among other things, any code that gets ids from object keys
will need to convert them to integers before passing to getAsync().
 2017-05-23 02:04:58 -04:00
Dan Stillman
265df6d48c Skip edit check if skipAll is passed to object save 2017-05-22 17:29:56 -04:00
Dan Stillman
0ac37ab65a Firefox 54 compatiblity for locale service 
Services.locale.getApplicationLocale() -> getAppLocale()
(nsILocaleService -> mozILocaleService)

It's possible this will fix some of the locale resolution problems in
Standalone:

"This is actually a meaningful change because the old one was actually
using OS locale for platforms other than Windows. The new one is using
the app locale for all platforms." [1]

[1] https://bugzilla.mozilla.org/show_bug.cgi?id=1346674#c0
 2017-05-22 06:09:25 -04:00
Dan Stillman
1b8704f133 Firefox 54 compatibility: File.createFromFileName() returns a promise 2017-05-22 06:04:27 -04:00
Dan Stillman
a3eea03a38 Firefox 54 compatibility: rename "new" and "delete" XBL methods 2017-05-22 06:03:14 -04:00
Dan Stillman
ddc9989d82 Fix refresh when opening related-item box in note editor 2017-05-19 12:36:03 -04:00
Dan Stillman
1cbc2440ec Make a missing related item not fatal 
Since item relations are synced with individual items, an item can exist
before the item it's related to has been downloaded.
 2017-05-19 12:11:58 -04:00
Dan Stillman
fc4eb5308f Remove related-item relations when deleting item 2017-05-19 12:11:51 -04:00
Dan Stillman
8edd8830da Remove reference to 'publications' library type in URI.getLibraryPath() 2017-05-19 12:11:21 -04:00
Dan Stillman
90a27f8d4b Add Zotero.URI.getURIItemLibraryKeyFromDB() 
Allows getting libraryID and key without relying on library data being
loaded (e.g., at startup)
 2017-05-19 12:11:21 -04:00
Dan Stillman
5873e554f1 Allow functions for testing and repair in DB integrity checks 
This can be used for things that can't be checked or repaired with SQL
alone, or that are too difficult to do that way.
 2017-05-19 12:11:14 -04:00
Dan Stillman
caf61bec2f Use COUNT(*) > 1 for DB integrity check queries 2017-05-19 06:33:03 -04:00
Dan Stillman
cf125435fb Update citeproc-js to 1.1.167 2017-05-19 04:51:20 -04:00
Dan Stillman
74fe4b31f9 Merge locales from Transifex 2017-05-17 21:41:40 -04:00
Dan Stillman
05dcc11a8d Update localized string name 
Most localizations still say "Firefox" for this string, so this will
clear those.
 2017-05-17 21:41:40 -04:00
Dan Stillman
d9fbccca67 Add item sanity check to note editor 
When refreshing the note editor, store the associated itemID on the
textbox, and check it when saving to make sure it's for the expected
note. This might prevent weird situations (which I can't reproduce, but
there was a report in the forums [1]) where something goes wrong and the
note doesn't refresh when selecting a new item, and then one note's
content is saved over another's.

[1] https://forums.zotero.org/discussion/65708/
 2017-05-17 21:41:40 -04:00
Dan Stillman
c4411e1ad3 Crash app if there's an error selecting an item 2017-05-17 21:41:39 -04:00
Adomas Venčkauskas
182cf67a97 Fix wrong localization arg passing 2017-05-15 18:26:41 +03:00
Dan Stillman
7e95f8fc51 Use proper alerts for export errors 2017-05-14 05:07:18 -04:00
Dan Stillman
e1986b460e Fix failed export due to missing attachment path 2017-05-14 05:06:37 -04:00
Dan Stillman
eb42152c42 UI fixes for read-only notes 
- Don't show toolbar in read-only note editor
- Get rid of "undefined" button in CR window
- Better padding/alignment in CR window
 2017-05-12 20:01:47 -04:00
Dan Stillman
be7cc45c0e Better debug logging for CR error 2017-05-12 17:53:19 -04:00
Dan Stillman
a92d469466 Remove accidental 'false' in 20121b9b9 2017-05-12 06:16:29 -04:00
Dan Stillman
20121b9b97 Fix tag selector tests (broken in 5963c02db) 2017-05-12 06:13:02 -04:00
Dan Stillman
5963c02dbb Fix "Display All Tags in This Library" (broken in fe186333b) 2017-05-12 05:37:46 -04:00
Dan Stillman
9de6a55bce Better approach to opening files after on-demand downloads 
Follow-up to 44507ce20b
 2017-05-11 01:26:46 -04:00
Dan Stillman
b3acb12973 Don't show Modified if attachment is missing 2017-05-11 01:07:21 -04:00
Dan Stillman
44507ce20b Prevent conflicting file downloads on double double-click 2017-05-11 01:05:55 -04:00
Dan Stillman
60810ea0a0 Fix access date without time coming from sync 2017-05-11 00:44:37 -04:00
Dan Stillman
a207e388db Fix attachment download progress pies 2017-05-10 23:27:28 -04:00
Dan Stillman
5b5da4140b Display connection error when linking sync account 2017-05-10 02:32:21 -04:00
Dan Stillman
b60fdacd3f Fix whitespace and description in build_typeSchemaData.html 2017-05-08 18:51:50 -04:00
Adomas Venčkauskas
e1f09d4655 Remove unneeded connector files, update connectorTypeSchemaData.js 
Addresses zotero/zotero-connectors#121
 2017-05-08 14:38:03 +03:00
Adomas Venčkauskas
dbeecb9b0a Make itemFromCSLJSON independent of Zotero.Item existance. 
Addresses !zotero/zotero-connectors#121"
 2017-05-08 09:24:34 +03:00
Adomas Venčkauskas
746171ab78 Fix doc.prefs.noteType handling with NaN values 2017-05-08 09:24:34 +03:00
Dan Stillman
6fa84a58df Update locales from Transifex 2017-05-08 00:12:09 -04:00
Dan Stillman
c0a47713f3 Remove extra argument in removeAttribute() 2017-05-07 23:45:33 -04:00
Dan Stillman
4273f14fe1 Optimize items list refreshing 
When refreshing, keep the previous list intact, removing only the items
that aren't in the new list and sorting only the newly added items.
 2017-05-07 23:36:28 -04:00
Dan Stillman
e0e22225bc Fix entering date without time into Accessed 
https://forums.zotero.org/discussion/65560/5-0-beta-accessed-field-changes-dates
 2017-05-05 17:59:53 -04:00
Adomas Venčkauskas
b679adad45 Potential bugfixery for #1218 2017-05-05 14:53:55 +03:00
Dan Stillman
7a51f5e3cc Update citeproc-js to 1.1.165 2017-05-05 05:20:03 -04:00
Dan Stillman
4ef39107f3 Update locales from Transifex 2017-05-05 05:14:15 -04:00
Adomas Venčkauskas
b80cdb2915 A couple more changes to document prefs dialog 2017-05-05 11:19:34 +03:00
Dan Stillman
43d12ee3b7 Remove debugging 2017-05-05 03:27:15 -04:00
Dan Stillman
40da5f61a0 Still process downloads if uploads fail for a library 2017-05-05 03:26:29 -04:00
Dan Stillman
021cfa8b3b Better debug output for objects in sync queue skipped for uploading 2017-05-05 01:38:09 -04:00
Dan Stillman
2f0391fb9c Clean up some comments and debug lines 2017-05-05 01:06:00 -04:00
Dan Stillman
a1bd2bace5 Remove objects from sync queue if missing from response 
While objects in the sync queue that fail to save should remain in the
queue, objects that just don't exist remotely need to be removed, or
else they'll be retried forever.
 2017-05-05 01:04:16 -04:00