suzanne.soy/zotero
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
6,332 Commits 11 Branches 258 Tags 98 MiB
2f79cb221f
Commit Graph

4110 Commits

Author SHA1 Message Date
Dan Stillman
0f2e24dc5c Log state check errors (and other logError calls) to debug output 2014-10-03 16:05:14 -04:00
Dan Stillman
cb707a55c8 Fix breakage from 10ba5e31d 2014-09-20 16:34:36 -04:00
Dan Stillman
b0550273ae Update another version 2014-09-19 20:43:50 -04:00
Dan Stillman
f09871a1ee Convert additional for..in loops to for loops in getDisplayTitle() 2014-09-19 20:39:23 -04:00
Dan Stillman
10ba5e31d6 Fix error from letter items with more than 10 recipients 
https://forums.zotero.org/discussion/40218/
 2014-09-19 20:37:59 -04:00
Dan Stillman
ce6cba7974 Don't log stack trace for getString() failure unless unexpected 2014-09-19 15:52:53 -04:00
Dan Stillman
fd31e41e2f Add localization todos 2014-09-18 17:41:46 -04:00
Dan Stillman
57ec10dfd4 Remove unnecessary var 2014-09-18 17:35:25 -04:00
Dan Stillman
48955c8983 Check ext length explicitly in createShortened when checking path length 2014-09-18 17:34:10 -04:00
Dan Stillman
2a986c8635 Don't match extension in createShortened() for dot-files (.hidden) 2014-09-18 17:23:57 -04:00
Dan Stillman
5a8de7054c Ignore case when extracting extension in Zotero.File.createShortened() 2014-09-18 16:54:05 -04:00
Dan Stillman
f5b5617885 Improve long-filename handling during syncing 
This will hopefully fix some remaining issues with long filenames during
syncing, particularly on Linux with encrypted filenames (which have a
filename length of 143).

(This may have reintroduced some edge case bugs, so it needs some
testing.)
 2014-09-18 16:23:49 -04:00
Dan Stillman
4464e8ed9e Additional debugging for formatStringFromName error 2014-09-16 15:46:13 -04:00
Dan Stillman
61d7bd852b Debugging for strange Zotero.getString() error 2014-09-11 21:07:19 -04:00
Simon Kornblith
55f86f4295 Fix error handling for saveItems 2014-09-05 00:28:34 -04:00
Dan Stillman
9cd7423dd7 Change cert error message URL to https:// 2014-09-02 23:28:20 -04:00
Simon Kornblith
431185cc3a Merge pull request #531 from aurimasv/high-contrast 
Use Mozilla's colors for itembox and tagbox background
 2014-09-01 23:30:35 -04:00
Simon Kornblith
57da88ac3d Fix == use 2014-09-01 23:19:12 -04:00
Simon Kornblith
9146fb03d9 Merge pull request #536 from adam3smith/coinsfix 
test for presence of author's firstName before using it
 2014-09-01 23:18:39 -04:00
adam3smith
17c0f44e66 fix indenting 2014-09-01 19:25:10 -05:00
Simon Kornblith
9c3ec6f0be Fix DataCite under Fx 32 2014-09-01 20:00:31 -04:00
Simon Kornblith
79ed7e503e Fix MODS under Fx 32 2014-09-01 19:29:45 -04:00
Simon Kornblith
a09ff9c9ec Don't unwrap objects passed to chrome 
Unwrapping objects also waives the Xray wrappers for contained objects,
which we need.
 2014-09-01 18:42:24 -04:00
adam3smith
f973897d76 test for presence of author's firstName before using it 2014-09-01 14:31:51 -05:00
Simon Kornblith
5857368131 Update citeproc-js to 1.0.539 2014-09-01 15:04:52 -04:00
Dan Stillman
14a5643f38 Update submodules, repotime, versions 2014-09-01 14:56:01 -04:00
Simon Kornblith
ee35f7df41 Small fix to copyObject 2014-09-01 12:26:36 -04:00
Aurimas Vinckevicius
dc5ccffe43 Use Mozilla's colors for itembox and tagbox background 
This way, the colors play nicely with Windows themes (e.g. high contrast)
Re https://forums.zotero.org/discussion/38870/make-zotero-fully-recognize-windowsff-high-contrast-themes/ and https://twitter.com/stuffilike2know/status/504167872567189504
 2014-08-26 03:11:24 -05:00
Simon Kornblith
9219100901 Another Fx 32 translation fix 2014-07-23 18:05:56 -04:00
Aurimas Vinckevicius
638d29972c Don't ignore initial punctuation when sorting 
Also, change sorting sensitivity to "base"
Closes #514
 2014-07-23 00:18:48 -05:00
Dan Stillman
15108eea3f Fix intermittent source file deletion when dragging files in on Windows 
(at least, if this is caused by what I think it was caused by)

https://forums.zotero.org/discussion/38486/
 2014-07-20 15:56:55 -04:00
Dan Stillman
3b5bd45433 Further Windows drag-and-drop comment rewriting 2014-07-20 13:16:56 -04:00
Dan Stillman
717a440156 Clarify comment for Windows drag-and-drop mess 2014-07-20 02:50:00 -04:00
Dan Stillman
b8f69d6281 Fix Quick Copy drag to Chrome textareas on Windows 
Possibly to other places as well (but not Notepad, which doesn't work
from Firefox or Chrome either)

Unfortunately this requires going back to 'copy' cursor feedback when
dragging, even when Shift is used. We can only choose one on Windows (as
far as I can tell), and we were previously using the unadorned 'move'.
 2014-07-20 02:16:25 -04:00
Dan Stillman
7d74344b7d Restore highlighting of collection row during drag on Windows 2014-07-20 02:16:20 -04:00
Dan Stillman
813f55d024 Natural sorting of numbers ("1" < "2" < "10") 
This needs testing to see if it has any other unwanted effects.

Closes Trac ticket 1031
 2014-07-08 09:47:03 -04:00
Simon Kornblith
87a0df43d8 Fix some more Fx 32 issues 
Ref https://forums.zotero.org/discussion/37885/
 2014-07-06 14:07:00 -04:00
Simon Kornblith
d9720f18a9 Update to citeproc-js 1.0.536 2014-07-06 08:50:13 -04:00
Dan Stillman
532ebc5239 Fix for startup error w/weird locale language tags ("de-CH@currency=EUR") 
https://forums.zotero.org/discussion/37901

And just return a noop sorter on failure instead of breaking
 2014-06-27 09:36:11 -04:00
Dan Stillman
4a677240d3 Don't use Intl until Fx30, since it's missing in Iceweasel 29 
And nsICollation isn't broken on OS X until 30
 2014-06-27 01:12:25 -04:00
Dan Stillman
d66a6f6680 Ignore punctuation when sorting 
This sorts "St. A" before "St B". I don't know if we want this.
 2014-06-25 12:24:31 -04:00
Dan Stillman
979e62714c Fix startup errors in some non-English locales in Fx30 on OS X 
nsICollation broke for some locales. (Testing requires changing the
language setting in Language & Region and then restarting the computer.
The change seems to not fully go into effect until then, even though the
UI changes.) This is fixed in Nightly, but we can work around it by
using the new Intl.Collator.
 2014-06-25 12:22:04 -04:00
Dan Stillman
be49010783 Use 11 instead of 6 on invalid note font size 
Also don't validate font size until after pref field is blurred, to allow
numbers to be typed in properly
 2014-06-23 23:36:36 -04:00
Simon Kornblith
bcc7a4ae86 Missing word in comment from 8cb081a4e1 2014-06-23 22:56:08 -04:00
Simon Kornblith
8cb081a4e1 Disable argument unwrapping on Fx < 32 
This apparently breaks on Fx 24
 2014-06-23 22:55:02 -04:00
Simon Kornblith
dd5160cc73 Partially revert 76e8ea835f 
Apparently this doesn't work on Firefox 24. Sigh.
 2014-06-23 22:29:32 -04:00
Dan Stillman
f45b219792 Fix inline collection editing when clicking to another collection 
https://forums.zotero.org/discussion/37739
 2014-06-21 13:37:55 -04:00
Simon Kornblith
41e50ef669 Fix check from fc91deb69e 2014-06-21 13:27:49 -04:00
Simon Kornblith
fc91deb69e Fix more Firefox 32 issues 2014-06-21 13:25:33 -04:00
Simon Kornblith
76e8ea835f Slightly cleaner fix for #504 2014-06-21 13:16:39 -04:00
Simon Kornblith
a71f3bbdd8 Fix #504 
Determine whether to copy objects by their constructor names, since the
prototypes do not necessarily match
 2014-06-21 12:51:41 -04:00
Dan Stillman
4812ab6f93 Fixes (cosmetic) "Q.async(...)(...) is undefined" sync error 
Yield immediately so that a generator is always passed to Q.async()
 2014-06-20 03:47:04 -04:00
Dan Stillman
09e53d85d5 Revert "Revert "Use Q instead of Task.spawn to run processUpdatedXML()"" 
This reverts commit 4334260865.
 2014-06-20 03:47:01 -04:00
Dan Stillman
4334260865 Revert "Use Q instead of Task.spawn to run processUpdatedXML()" 
Fixes "Q.async(...)(...) is undefined" sync error

This reverts commit ad8b81f4c7 (which
tried to fix Fx32+ compatibility).
 2014-06-20 03:17:03 -04:00
Simon Kornblith
3a8c77e983 Fix search translation bug from 7950d3a7e2 2014-06-19 21:31:17 -04:00
Simon Kornblith
37f4e61ef2 Remove debug line 2014-06-19 20:11:46 -04:00
Simon Kornblith
7950d3a7e2 Attempt to fix #502, translation broken on Firefox 32 2014-06-19 20:07:31 -04:00
Simon Kornblith
f6dfeee210 Remove more uses of charsetDTD 2014-06-19 19:03:58 -04:00
Simon Kornblith
014c7b5b46 Fix tab mode in Aurora 
Ref https://forums.zotero.org/discussion/37608/
 2014-06-19 19:02:52 -04:00
Dan Stillman
75bdf08131 Fix event handling (e.g., Undo) in notes in Fx32 
Addresses #503
 2014-06-19 17:54:21 -04:00
Dan Stillman
c32144ddfd Fixes #503, Notes broken on Firefox 32 
Unwrap the editor object if it's wrapped
 2014-06-19 17:47:56 -04:00
Simon Kornblith
954f8bd001 Fix #496, Remove uses of nsICharsetConverterManager 
We should confirm that the manually added charsets still work on
Firefox 32 once we #502
 2014-06-19 17:31:27 -04:00
Simon Kornblith
e576416831 Remove old isFxN constants 2014-06-19 16:36:37 -04:00
Dan Stillman
b441e2cf9e Update submodules and repotime 2014-06-18 21:12:25 -04:00
Dan Stillman
ad8b81f4c7 Use Q instead of Task.spawn to run processUpdatedXML() 
With Task.spawn, regular expressions in Zotero.DB were causing "too much
recursion" errors on Windows with JIT enabled.

This requires a change to Q to allow async() to take a generator instead
of a generator-maker (which is the reason it was using Task.spawn to
begin with).
 2014-06-18 05:03:06 -04:00
Dan Stillman
fad6174e39 Fix download retrying 
Follow-up from 238a972a
 2014-06-10 03:50:41 -04:00
Dan Stillman
238a972ace Retry failed ZFS uploads and downloads automatically 
S3 upload timeouts were retried already with an exponential backoff, but
this adds retrying for other kinds of upload failures as well as failed
downloads.  If 5 consecutive failures occur a file sync error is
thrown.

Failed file sync requests to the Zotero API are not currently retried,
but S3 accounts for the majority.

The download portion of this still needs further testing.
 2014-06-09 06:47:07 -04:00
Dan Stillman
1b6dc5d681 Restore minimize/maximize buttons in note windows on Windows 
From db6ec2b160
 2014-06-05 00:54:22 -04:00
Simon Kornblith
7b7b4e6e9e Merge pull request #495 from aurimasv/Fx-connector 
Fix race condition when starting in Connector mode
 2014-06-04 17:02:28 +02:00
Aurimas Vinckevicius
e4dd38fc84 Fix race condition when starting in Connector mode 
When starting in Connector mode (i.e. Standalone is open), Zotero first starts in Full mode, looks for Standalone, then "shuts down" and restarts in Connector mode. `Zotero.shutdown()` returns a promise which is then followed up by a `Zotero.init` call. Thus, when starting in Connector mode, Zotero initialization is asynchronous and makes it possible for `Zotero_Browser.init()` to be called before `Zotero.initialized` is true, which prevents `Zotero_Browser` from initializing. Additionally, even if `Zotero_Browser.init()` is called after Zotero is initialized in Connector mode, it is possible that `Zotero_Browser.init()` will be called _after_ the "load" event for browser.xul has already fired, so `chromeLoad` is never called. This patch ensures that both of these race conditions are taken into account.
 2014-06-04 03:16:29 -05:00
Aurimas Vinckevicius
59fe54da01 Release server port when shutting down (e.g. switching to Connector mode) 2014-06-04 03:14:01 -05:00
Dan Stillman
a59f3c50ed Hack to fix "Numéro" search condition in French locale 
https://forums.zotero.org/discussion/14942/
 2014-06-03 14:17:54 -04:00
Dan Stillman
cbdc75df9a Fix search condition handling when two conditions have same translation 
This prevented one "Numéro" from working in the French locale.

Also do a proper collation sort
 2014-06-03 14:17:54 -04:00
Aurimas Vinckevicius
85c5c614ea Fix CSL-JSON date import 2014-06-02 17:25:16 -05:00
Dan Stillman
ba89dbf0ae Link translator errors to troubleshooting page instead of known issues 2014-06-02 17:00:57 -04:00
Dan Stillman
c0d6648b9e Allow inline editing of collection names 
Can be triggered by double-clicking or Return and also by F2 on
Windows/Linux

This does mean double-clicking no longer toggles the collection open and
closed. If we wanted to preserve that we could probably capture the
double-click.

Closes Trac ticket 231, only 8 years later
 2014-05-31 14:24:52 -04:00
Dan Stillman
326d2bc1e3 Enforce minimum note font size of 6px 
https://forums.zotero.org/discussion/37147/
 2014-05-31 01:42:31 -04:00
Dan Stillman
db6ec2b160 Persist single position/size for all note windows 
Previously, position/size was persisted for each item's note
individually, but that meant that there was no default position/size for
the note window and an entry was created in localstore.rdf for
every note opened in a new window. There's also a good chance people had
no idea what was going on.
 2014-05-28 14:35:05 -04:00
Dan Stillman
370fa78048 Merge pull request #489 from f-mb/csl-mapping 
Update csl mapping
 2014-05-28 02:15:47 -04:00
Dan Stillman
c986e6106b Blacklist additional errors 2014-05-26 20:09:27 -04:00
Dan Stillman
59f534d56f Error report improvements 
- Always allow "Report Errors...", even when no errors

- Show submitted diagnostic info in report

- Use white background and unitalicized text for report

- Make window larger by default
 2014-05-26 20:07:41 -04:00
Dan Stillman
072ae245d9 Use base-mapped dates for sorting (broken in dd477e15) 2014-05-26 19:13:21 -04:00
Dan Stillman
95bf52baf5 Check for NS_ERROR_STORAGE_CONSTRAINT in tag constraint error 2014-05-23 14:51:21 -04:00
Florian Martin-Bariteau
982dbeb962 Update utilities.js 2014-05-22 23:37:17 -04:00
Florian Martin-Bariteau
7b40ae2a46 Update utilities.js 2014-05-18 18:57:28 -04:00
Dan Stillman
472892b4f0 Closes #482, Include active info pane tab in tab cycle on OS X 
That was easy. (@simonster, since you disabled this originally, any reason not
to do this, other than the extra tab stop? At least in current Firefox
versions, this is the default behavior.)
 2014-05-17 04:10:37 -04:00
Dan Stillman
4305aa1356 Debugging for sync error 2014-05-16 17:57:35 -04:00
Dan Stillman
9f91d240b0 Library switcher in advanced search window 
When opening the advanced search window, the current library is
selected, and a different library can be selected to change the search
scope. If a library is read-only, the saved search button is disabled.
For saved searches, the appropriate library is selected and the
drop-down is disabled.

Also:

- Close the advanced search window after a search is saved
- The default name for saved searches ("Untitled 2", etc.) was based on
  collections rather than searches
- Once an initial search has been performed, the drop-downs and
  checkboxes now update the results
- More consistent spacing in advanced search window
- (dev) Zotero.DB.getNextName() now takes a libraryID as its first
  parameter instead of always using My Library; the old parameters are
  deprecated but still work
 2014-05-15 21:41:22 -04:00
Dan Stillman
f8798fe996 Set maximum with and chars on Name field when editing saved search 2014-05-15 21:41:22 -04:00
Dan Stillman
66ca236876 Use XUL xmlns instead of prefix in zoterosearch.xml 2014-05-15 21:41:21 -04:00
Dan Stillman
3552fe92b6 Merge pull request #479 from fbennett/preselect-csledit-style 
Preselect default Export style in csledit.xul
 2014-05-15 00:05:01 -04:00
Simon Kornblith
2a292faeaf Merge pull request #481 from aurimasv/import-network-shares 
Recognize Windows network shares on file attachment import
 2014-05-14 23:54:45 -04:00
Frank Bennett
c31a3c263b Preselect default Export style in csledit.xul 2014-05-15 12:43:50 +09:00
Dan Stillman
7ac35363e3 Clear guidance panel before adding text 
This is probably only necessary if the pref is reset manually, but this
prevents duplicate text in that situation.
 2014-05-14 17:18:54 -04:00
Dan Stillman
3ee09e8d38 Fix gray bar below Zotero pane when resizing Firebug down 
Follow-up from c1c0b42a12
 2014-05-14 17:14:45 -04:00
Aurimas Vinckevicius
e861c3e298 Fix slash direction on Windows for absolute paths 
E.g. Mendeley exports something like `C:/some/path/test.pdf`
 2014-05-13 13:30:30 -05:00
Aurimas Vinckevicius
f2a887fd24 Recognize Windows network shares on file attachment import 
Related to zotero/translators#735
 2014-05-13 12:53:38 -05:00
Dan Stillman
6cf597a08f Merge pull request #478 from fbennett/fix-csl-export-creators 
Fix dropping of creators in CSL JSON export
 2014-05-10 02:59:56 -04:00
Frank Bennett
6605486354 Use ID rather than name on getPrimaryIDForType() 
Use creator name for comparison (creatorTypeID does not exist on array-form creators)
 2014-05-09 22:29:45 +09:00
Dan Stillman
fd9452adbc Fix error when sorting by Item Type column (since dd477e15b8) 2014-05-07 13:45:20 -04:00