Switched all private calls of privileged methods to use 'this.' instead
No substantive changes
- This line, and those below, will be ignored--
M overlay.xul
M overlay.js
All the former Zotero.DB methods are now part of an instantiable Zotero.DBConnection object, and Zotero.DB is just one instance of it. Utilities can create and access a new SQLite database within the Zotero data folder by instantiating the DBConnection object:
this.DB = new Zotero.DBConnection('myutility');
Utilities have access to everything the DB layer provides, including automatic backup and restore of databases. Utility writers are on their own for schema management, at least for now.
Also:
- Cleared non-English DB restore localized strings after change.
- Disabled shutdown observer in Zotero object after moving DB backup code to DB layer
Closes#450, encyclopedia article and dictionary entry types
Language might want some special properties (Dublin Core recommends "en" or "en-us"-style values as a best practice)
Also reordered some fields
Sent as a fourth parameter to notify() -- parameter is an array of objects (in the same order as the ids) that currently contain a single property, 'old', which holds the toArray() object
Copies are not sent with 'modify' when it's only meant to refresh the UI and there's another trigger that covers the data change (e.g. removing a tag from an item sends both an item modify and an item-tag add, but the modify doesn't get a pre-change copy of the item since any consumers that care should just monitor item-tag)
Also:
- Removed Notifier.enable()/disable()
- Notifier no longer sends modify() if item already deleted
- New methods: Collection.toArray(), Zotero.Tags.toArray(tagID)
- Removed a few extraneous triggers
Simon, reopen if this doesn't fix the problem you were referring to.
(Also removes Notifier.enable()/disable() from its use in Item.erase() while we're at it.)
Also:
- Changed default Zotero pane min-height to 32px, which lets you shrink it to just the controls -- it would be better if we had a notification popup for the various non-translator save functions, since this way there's no feedback when you click the buttons, but at least it's possible. A dedicated mode with a keyboard shortcut would probably be better.
- Fixed bug (I think) whereby resizing the Z pane downward after resizing the tag selector up and then down sometimes caused the Z pane to stay at a fixed size and get pushed below the bottom
references #502, Special handling for automatic tags (support is now enabled, but not tag type is not maintained during RDF export)
references #517, ScienceDirect translator fails (I fixed the issue I had translating this page, but I think the reported error may be different)
closes#376, Bibliography export order jumbled
closes#482, Tag selector does not refresh on import/delete
closes#499, zotero RDF import of attachments has a flaw
closes#500, Improve COinS handling of other item types
- fixes an issue with importing directory hierarchy
- fixes an issue where the SpringerLink translator could fail to recognize a scrapable resource
- fixes an issue where the Nature translator could fail to retrieve an associated PDF
feel free to push the updates to the SpringerLink and Nature translators to the repository; theoretically, the RDF translator should be backwards-compatible too, but I'd like to test it with b3 before potentially breaking functionality.
And they said it would never happen.
Doesn't yet support dragging items to other windows, etc., but you can double-click to focus the item in the most recent Zotero pane. You can also save the search as...a saved search, which means that theoretically we could get rid of the now-redundant "New Saved Search" icon.
== Other/related changes ==
Search dialog:
- Better keyboard handling (focus condition menu by default, Enter to trigger command (e.g. search in the Advanced Search window), Shift-Enter to add new row)
Zotero.Search:
- Zotero.Search.clone() -- return copy of search
- Zotero.Search.getSearchConditions() now returns copy of conditions
itemTreeView:
- Always sort by the first column if no sort column set; removed isSorted() logic, since isSorted() now always returns true
- Made itemsTreeView.refresh() call rowCountChanged, since there were cases in which the tree could end up looking for nonexistent rows after they'd been removed
- selectItem() now takes a second parameter, expand, to open the selected item if it's a container
- selectItem() now tries to get the selected item at least slightly away from the bottom (since ensureRowIsVisible does only the bare minimum) and also tries to get the parent item in view when scrolling upwards to make a child item visible
- Moved getSelectedItems() logic into the treeview instead of overlay.js
Closes ##399, provide ability to view columns in middle pane for any field that shows up in all item types
Added Publisher and Date column options
Note that new columns will be out of order until Restore Natural Order is selected
Also:
- Switched around column XUL ids to make things easier
- Automatic tags now appear in orange; tooltip says either "User-added tag" or "Automatically added tag"
- New menu in tag selector to toggle automatic tags
- User and automatic tags are combined in tag selector, so renaming/deleting a tag will affect both user and automatic, regardless of view mode
- Editing a tag makes it a user tag, as does adding an identical user tag to an item (rather than creating a second one)
- ingester/export will need to be adjusted to add automatic tags
Changed:
Item.addTag(tag) => addTag(tag, type)
Item.getTags() - now returns 'id', 'tag', 'type'
Item.toArray() - tags now include 'type' property (from Item.getTags())
Tags.getID(tag) => getID(tag, type)
Tags.getAll() => getAll([types]) - types is an optional array of tagTypes to fetch; now returns objects with 'tag' and 'type' properties
Tags.getAllWithinSearch(search) => Tags.getAllWithinSearch(search, [types]) - now returns object with 'tag'/'type'
Added:
Tags.get(tagID) - returns object with 'tag' and 'type' properties
Tags.getIDs(tag) - returns all tagIDs for this tag (of all types)
Tags.getType(tag) - returns array of tag types matching given tag
For type property, 0 == user, 1 == automatic
