suzanne.soy/FreeCAD
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Fix error in up to face option

Browse Source
This commit is contained in:
wmayer 2012-11-06 20:44:31 +01:00
parent ac2f2dc20e
commit c30c06caba
1 changed files with 2 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
src/Mod/PartDesign/App/FeatureSketchBased.cpp
View File

@ -444,11 +444,13 @@ void SketchBased::getUpToFace(TopoDS_Face& upToFace,
if (remove_limits) {
// Note: Using an unlimited face every time gives unnecessary failures for concave faces
TopLoc_Location loc = upToFace.Location();
BRepAdaptor_Surface adapt(upToFace, Standard_False);
BRepBuilderAPI_MakeFace mkFace(adapt.Surface().Surface());
if (!mkFace.IsDone())
throw Base::Exception("SketchBased: Up To Face: Failed to create unlimited face");
upToFace = TopoDS::Face(mkFace.Shape());
upToFace.Location(loc);
}
// Check that the upToFace does not intersect the sketch face and
@ -462,7 +464,6 @@ void SketchBased::getUpToFace(TopoDS_Face& upToFace,
}
// We must measure from sketchshape, not supportface, here
// TODO: distSS() sometimes gives false positives for unlimited upToFaces!
BRepExtrema_DistShapeShape distSS(sketchshape, upToFace);
if (distSS.Value() < Precision::Confusion())
throw Base::Exception("SketchBased: Up to face: Must not intersect sketch!");