Commit Graph

7103 Commits

Author SHA1 Message Date
Stefan Tröger
9969aac671 fix dependent copy references
to make them work with sketches an additional Part2DObject reference needed to be created
2016-04-12 18:12:19 +02:00
blobfish
78f3e9786b Core: Gui: DAGView: using pending icon and showing valid status for tool tip 2016-04-12 18:12:19 +02:00
blobfish
e6f77dc067 Core: Gui: DAGView: add pending icon 2016-04-12 18:12:19 +02:00
Alexander Golubev
36fbf73011 PartDesign/TaskLoftParameters: Added UpdateView checkbox +cleanup 2016-04-12 18:12:19 +02:00
Alexander Golubev
efef23d8e2 PartDesign/Gui: prevent Task*PatternParameters not crash on non sketchBased features 2016-04-12 18:12:19 +02:00
Alexander Golubev
aa7d054d47 PartDesign/TaskLoftParameters: removed unused hidden widgets 2016-04-12 18:12:19 +02:00
Alexander Golubev
0ff24fd618 Part/Gui: remove ViewProviderPart::onDelete which handled unnecessary body housekeaping
Also do some headers cleanup
2016-04-12 18:12:19 +02:00
Alexander Golubev
ba57a843ad PartDesign/ViewProviderBody: reduce number of recalculations in the body 2016-04-12 18:12:19 +02:00
Alexander Golubev
3be2f99b52 PartDesign/Gui: rework of ViewProviderDatumCS 2016-04-12 18:12:19 +02:00
Alexander Golubev
fa29bfa667 PartDesign/ViewProviderDatum: minor enhancements
- added defaultSize constant
 - fixed typo in margin{g,}Factor function name
2016-04-12 18:12:19 +02:00
Alexander Golubev
d4c67c0366 GeoFeaturertDesign/Gui: Add recompute sizes and datums to the body vp 2016-04-12 18:12:19 +02:00
Alexander Golubev
0c620cc885 App/OriginFeature: a minor cleanup 2016-04-12 18:12:19 +02:00
Alexander Golubev
5918f6f264 Gui: forbid to delete OriginFeatures 2016-04-12 18:12:19 +02:00
Alexander Golubev
bceec93a92 PartDesign/Gui: rework ViewProviderDatumPlane 2016-04-12 18:12:19 +02:00
Alexander Golubev
7ac1ab6a6d PartDesign/Gui: make Datums use general material interface
- Make Datums colorable and transparent
 - Change default datums color to yellow and transparency to 60%
 - Rework Lines and Points datum view provider
 - Add ViewProviderDatum::defaultBoundBox()
2016-04-12 18:12:19 +02:00
Alexander Golubev
118f1cec6a PartDesign/App: cleanup datum's classes and headers 2016-04-12 18:12:19 +02:00
Alexander Golubev
04f3ae0605 PartDesign/CommandBody: a minor fix in MoveTip command 2016-04-12 18:12:19 +02:00
Alexander Golubev
26fb01b429 PartDesign/Gui: add origin sizing and rework datums sizing 2016-04-12 18:12:18 +02:00
Alexander Golubev
56823eeb9d App/Part: add getPartOfObject() to search a part for object 2016-04-12 18:12:18 +02:00
Alexander Golubev
1a26f7551f PartDesign: add Origin to the Body and unstrap the module from the Parts 2016-04-12 18:12:18 +02:00
Alexander Golubev
15e998e07c Gui/ViewProviderOriginFeature: remove the "New" selection model stuff
The new selection model is not usable for the OriginFeature's view
provider due to from one side it doesn't really have any subfeatures, so
it won't be really needed, and on the other side we will have to use
SoFCSelection because in that case it isn't possible to implement
highlighting in any sane way (unless we will reimplement drawing ourselfs).
2016-04-12 18:12:18 +02:00
Alexander Golubev
9292ddfa1e Gui/ViewProviderOriginGroup: prevent recalculation of origin size on ViewProviderOriginFeature changes 2016-04-12 18:12:18 +02:00
Alexander Golubev
9753f27064 Gui: refactor Plane's and Line's ViewProviders and add yet another one for OriginFeature
- Share the code of Gui::ViewProviderPlanes and Gui::ViewProviderLine
   in Gui::ViewProviderOriginFeature
 - Add support for coloring and transparencing the OriginFeatures by
   ViewProviderGeometryObject means.
2016-04-12 18:12:18 +02:00
Alexander Golubev
e8e4f31b14 Gui/SoFCSelection: added a methode for applying defaults from settings 2016-04-12 18:12:18 +02:00
Stefan Tröger
2a5d800940 fix origin plane and line viewprovider
master changed the highlight code for viewproviders, needed an adjustement after rebase
2016-04-12 18:12:18 +02:00
Alexander Golubev
cebc5860c1 Gui/ViewProviderGeoFeatureGroup: suppress DocumentObjectGroup's hide/show behavior 2016-04-12 18:12:18 +02:00
Alexander Golubev
2c2d155ee9 OriginGroup: add new abstraction layer between the Part and the GeoFeatureGroup 2016-04-12 18:12:18 +02:00
Alexander Golubev
59ca9212d6 Gui/ViewProviderDocumentObjectGroup: minor enhancements 2016-04-12 18:12:18 +02:00
Alexander Golubev
4e6298d539 Gui/ViewProviderOrigin: fix a segfault when accessed uninitialized plane's view providers when setted up lines sizes 2016-04-12 18:12:18 +02:00
Alexander Golubev
8bca27463e Part/Attacher: remove a couple of no more valid asserts 2016-04-12 18:12:18 +02:00
Alexander Golubev
797d6d3a11 App/Origin: big refactoring
- Rebase App::Origin on App::DocumentObject
 - Keep all control over the Origin structure inside the Origin and it's
   ViewProvider
 - Add OriginFeature class as common base for App::Plane and App::Line
 - Rebase App::Plane and App::Line on top of newly created class and
   move to the file.
 - Change Origin's ViewProvider API associated with temporary display
 - Lots of associated changes to files
 - Several minor fixes
 - Lots of new bugs
2016-04-12 18:12:18 +02:00
Alexander Golubev
ecbb576330 App: minor fix of spacing 2016-04-12 18:12:17 +02:00
Alexander Golubev
26bb702ff6 App: add two callback to DocumentObject to perform initialization/uninitialization inside an object
Added two callbacks to App::DocumentObject
 - setupObject()
 - unsetupObject()

All associated code was added to App::Document
Also was added a specific flag ObjectFlag::Deleted wich is set when performing the deletion.
2016-04-12 18:12:17 +02:00
Alexander Golubev
c6797b6c29 Revert "part deletion handling"
This reverts commit 6ab2002021ac1df26ebe77f488f5cd94e1df0b26.
2016-04-12 18:12:17 +02:00
Alexander Golubev
dbb5786ffd App/GeoFeatureGroup: derive from DocumentObjectGroup
Refactor GeoFeatureGroup and derive it from DocumentObjectGroup rather
than GeoFeatureObject to unify code of those two classes.
2016-04-12 18:12:17 +02:00
Alexander Golubev
76b4685b5f Commented out a portion of code cosed a segfault 2016-04-12 18:12:17 +02:00
Alexander Golubev
5016054a8b PartDesign/Body: move deletion of subobjects to view provider 2016-04-12 18:12:17 +02:00
Alexander Golubev
aa32522115 DocumentObjectGroup: fix deleting of groups in case of malformed links
This one prevents thurther object structure damage if
DocumentObjectGroup::Group connains multiple links to the same feature.
Also minorr changes:
 - Fix some spacing
 - Ask the user if he wants to delete group content
2016-04-12 18:12:17 +02:00
Alexander Golubev
abc925b62e PartDesign/Gui: Make partDesign's add sketch command Workflow-aware 2016-04-12 18:12:17 +02:00
Alexander Golubev
492f1d24a4 PartDesign/Gui: initial migration command implementation 2016-04-12 18:12:17 +02:00
Alexander Golubev
c4f094bba4 PartDesign/Gui: rename some fonctions in ReferenceSelection.cpp
e.g. getPythonStr -> buildLinkListPythonStr etc
2016-04-12 18:12:17 +02:00
Alexander Golubev
06139ee8f3 Gui/ViewProciderPart: fix XZ plane orientation
Also fix spacing and a Workbench.getValue() condition
2016-04-12 18:12:17 +02:00
Alexander Golubev
ca8be01a4b Fix a crash then sketch calls recalculation 2016-04-12 18:12:17 +02:00
Alexander Golubev
f9e67626ec PartDesign/Body: remowe Part::Feature from isAllowed() 2016-04-12 18:12:17 +02:00
Alexander Golubev
c388a84424 PartDisign/WorkflowManager: initial implementation 2016-04-12 18:12:17 +02:00
Alexander Golubev
8a2d4289f6 PartDesign/FeaturePrimitive: suppress a -Woverloaded-virtual warning 2016-04-12 18:12:17 +02:00
Alexander Golubev
c782a11aab PartDesign/Gui: Move various utility stuff from Workbench to a separate file
Also do some header cleanup.
2016-04-12 18:12:17 +02:00
Alexander Golubev
a5fcd5775e PartDesign: update body management commands according to the changes in body paradigms 2016-04-12 18:12:16 +02:00
Alexander Golubev
8b62680fe7 Sketcher: minor enhance in sketch interaction with body 2016-04-12 18:12:16 +02:00
Alexander Golubev
bf94c3ebf7 PartDesign: fix negative Offset property in pad and pocket 2016-04-12 18:12:16 +02:00
Alexander Golubev
444986e88a PartDesign/Gui: move body commands to a separate file 2016-04-12 18:12:16 +02:00
Alexander Golubev
8c5d514b18 PartDesign: Body rework - add BaseFeature property and make Tip always point to solid 2016-04-12 18:12:16 +02:00
Alexander Golubev
37320a0bfa Gui: prevent DAGView crash freecad when a document gets a circular dependency 2016-04-12 18:12:16 +02:00
Alexander Golubev
2fc5d6c818 Gui/Tree: make tree view correctly handle child order than moving them 2016-04-12 18:12:16 +02:00
Alexander Golubev
e3c00ce650 PartDesign/ViewProviderPad: removed a TODO 2016-04-12 18:12:16 +02:00
Alexander Golubev
1b1bd5f17e PartDesign/Gui: make Transformed ViewProviders use common code with other 2016-04-12 18:12:16 +02:00
Alexander Golubev
9cba6c48ea PartDesign/TaskMultiTransformParameters: fix a segfault
The segfault was caused by premature delete of object
TaskMultiTransformParameter::subFeature refered to.
Steps to reproduce:
1. Create a multitransform
2. Add a sub transfurmation to it
3. Press cancel
2016-04-12 18:12:16 +02:00
Alexander Golubev
113c10a2b7 PartDesign: make transform parameter dialogs use common base code with other dialogs
subj;
Make PasrtDesign::Transformed provide common for all features
classes interface getBaseObject() instead of specific getSupportObject ();
Refactor some TransformedParameters methods.
2016-04-12 18:12:16 +02:00
Alexander Golubev
e6a99ce96f PartDesign/Workbench: fix a crash 2016-04-12 18:12:16 +02:00
Alexander Golubev
147aff0395 PartDesign/Feature: minor gramma fix 2016-04-12 18:12:16 +02:00
Alexander Golubev
da1fb99dc5 PartDesign/ViewProvider: minor enhancements 2016-04-12 18:12:16 +02:00
Alexander Golubev
e28aaf4592 PartDesign/TaskDressUpParameters: disable edit of dressup features with broken supports
Also remove unused headers and fix spacing.

A final fixup for issues addressed in:
cb05b01 PartDesign/TaskDressUpParameters: fix a crash when editing a broken object
2016-04-12 18:12:15 +02:00
Alexander Golubev
1876c76f3c PartDesign/Gui: make DressUp view providers use the common code. 2016-04-12 18:12:15 +02:00
Alexander Golubev
55f3f52f54 PartDesign/Feature: add an optional parameter to getBaseObject() to prevent it from throwing exceptions
In most cases getBaseObject() is used with an exception handler which
only detects if it failed but not the reason. This modification allows
to use it without excess exception handlers.
Also add the same parameter to SketchBased::getVerifiedSketch().
2016-04-12 18:12:15 +02:00
Alexander Golubev
013381ccb6 PartDesign/Gui: share code for revolution and groove view providers 2016-04-12 18:12:15 +02:00
Alexander Golubev
5ee0cea467 PartDesign/Gui: start to unify view providers code
- Moved all common code for part design features view providers to a base
   class.
 - Move shared code for Sketch based features to newly created
   ViewProviderSketchBased class
 - Add ViewProviderSketchBased to initialization
 - Make Pad and Pocket ViewProviders to use the shared code
 - Minor fixes to TaskFeatureParameters and some derived classes
2016-04-12 18:12:15 +02:00
Alexander Golubev
6266d514d3 PartDesign/ViewProviderDatum: minor fix in a comment 2016-04-12 18:12:15 +02:00
Alexander Golubev
5f6f16e757 PartDesign/FeatureDressUp: implement a proper getBaseObject()
The function getBaseShape() is removed and replaced with getBaseObject()
because it doesn't make a lot of scense: getBaseShape() masked the
base's class implementation (rather than redefine a virtual) which was
better in words of code reuse.

Also BaseFeature and Base properties relations are defined now in a
little another way.
2016-04-12 18:12:15 +02:00
Alexander Golubev
9feff04aad PartDesign/TaskDressUpParameters: fix a crash when editing a broken object 2016-04-12 18:12:15 +02:00
Alexander Golubev
0ca40ed48b PartDesign/Task{Pad,Pocket}Parameters: massive refactoring
Give a massive refactoring to Task dialogs for pocket and pad.
This commit features:
 * Make Task dialogs for pocket and pad look nice in side-by side diff and
   cross import features missing in each other.
 * As a result it fixes several minor bugs.
 * Gives a rework to the UpdateUI function.
 * This one also fixes offset option support and migrates it to use unit
   framework.
2016-04-12 18:12:15 +02:00
Alexander Golubev
143760c8d3 PartDesign/ViewProviderPad: removed unfinished reimplementation of doubleClick()
This one resulted in non proper reject of pad dialog. Because the
command transaction haven't started.
2016-04-12 18:12:15 +02:00
Alexander Golubev
11a71d46e3 PartDesignGui: move signal connections in several parameter dialogs after ui initialization 2016-04-12 18:12:15 +02:00
Alexander Golubev
f16829baee PartDesignGui: Make DressUp and SketchSupport propertie dialogs use common accept() structure 2016-04-12 18:12:15 +02:00
Alexander Golubev
12742d94de PartDesign/TaskThicknessParameters: fix copy-paste mistake in dialog 2016-04-12 18:12:15 +02:00
Alexander Golubev
9db8afd716 PartDesignGui: move shared code for all dressUp features into common place.
Also this allows the old workflow for thickness and draft features.
2016-04-12 18:12:15 +02:00
Alexander Golubev
b14d7c2e14 PartDesign: move common code for TaskDlg{SketcherBased,DressUp}Parameters into new base class
Added a new class: TaskDlgFeatureBased which currently contains common
code for TaskDlgSketcherBasedParameters::reject() as well as the same
methode for TaskDlgDressUpParameters.
It's likely that other Feature task dialogs will inherit this class too.
2016-04-12 18:12:15 +02:00
Alexander Golubev
0208a3667d PartDesign/FeatureDressUp: make Base and BaseFeature properties track the same feature
Also remove reseting of read-only flag on placement properties on
removing Base feature: it doesn't make any scense for dressup features.
2016-04-12 18:12:15 +02:00
Alexander Golubev
98a0e30582 PartDesign: fix a crash in the loft 2016-04-12 18:12:14 +02:00
Alexander Golubev
86db4c3215 PartDesign/Gui: enable sketches on datum planes inside bodies 2016-04-12 18:12:14 +02:00
Alexander Golubev
e586f55fb2 PartDesign/Gui: more old workflow support
* remove an error message if adding a sketchbased feature without a body
* add champfer or fillet old workflow support

Also rework finishFeature() so at least champfer and fillet may be
inserted into any place of any apropriate body(not only the active one) of the body.
2016-04-12 18:12:14 +02:00
Alexander Golubev
a6ebfa496f PartDesign/Gui/TaskDlgSketchBasedParameters: emhance object hiding/unhiding on reject() 2016-04-12 18:12:14 +02:00
Alexander Golubev
4590305921 PartDesign/Gui: enhance the TaskFeaturePick with new cotegory of sketches: notInBody
Also add option tp show already used sketches and fix some spacing.
2016-04-12 18:12:14 +02:00
Alexander Golubev
ffc6cc2f23 Share code for finding a body containing a feature 2016-04-12 18:12:14 +02:00
DeepSOIC
16e4ce20f0 PartDesign workflow without part/body
PartDesign: make datum features work outside of body/part
PartDesign old workflow: remove a few messageboxes about no part
PartDesign: old workflow: multitransform without body

Still has visibility issues, but generally works.
2016-04-12 18:12:14 +02:00
DeepSOIC
c3da141020 Revolution: fix failure on sketch edges used as an axis
PartDesign Revolution used to fail, when an edge of a sketch was
selected as an axis of revolution. This is fixed by this commit.
Also, made it support selecting an edge from the sketch the revolution
itself is made from.
2016-04-12 18:12:14 +02:00
DeepSOIC
125dda4d70 PartDesign: Make groove work via Revolution ui
Purpose: remove duplicate code.
Remaining: wrong title and icon in task dialog.
2016-04-12 18:12:14 +02:00
DeepSOIC
9776d30b87 PartDesign: rework axis and plane comboboxes and make it work without part.
Rework combobox filling and link hadling for revolution and transformed features, in order to get rid of hard-coded item indexes and make the lists more dynamic.
2016-04-12 18:12:14 +02:00
DeepSOIC
2625233dff PartDesign: disable migration
Temporary. Later, a way to manually invoke it should be made.
2016-04-12 18:12:14 +02:00
DeepSOIC
e587cb8a5d Fix rebase mistake, application startup related
Caused docking restore problems, and probably toolbar state restoration
too.
See post 116 of thread "Test Request: Part Design Workflow" (
http://forum.freecadweb.org/viewtopic.php?f=20&t=11205&start=110#p95619
)
2016-04-12 18:12:14 +02:00
Alexander Golubev
f509e1b0f1 remove unneeded sketcher tools from part design
Previously similar patch was commited by Stefan Tröger <stefantroeger@gmx.net> but lost during rebase.
2016-04-12 18:12:14 +02:00
Stefan Tröger
a8bd2f6f7f prevent part design features from accidently cross referencing 2016-04-12 18:12:14 +02:00
Stefan Tröger
318c65eafd fix independent copy and cross reference 2016-04-12 18:12:14 +02:00
Stefan Tröger
a35c231d2a first take on enhanced feature pick task 2016-04-12 18:12:14 +02:00
blobfish
a6fe5e664a Core: Gui: DAGView: windows compile fix 2016-04-12 18:12:13 +02:00
Stefan Tröger
45aca9fb55 fix loft top face location 2016-04-12 18:12:13 +02:00
Stefan Tröger
986623f462 fix loft tool naming 2016-04-12 18:12:13 +02:00
Stefan Tröger
d2f4410c1e fix datum crash when origin is selected 2016-04-12 18:12:13 +02:00
Stefan Tröger
e876d9aa81 fix loft result orientation 2016-04-12 18:12:13 +02:00
Stefan Tröger
ef11b75c79 fix pipe tool result orientation 2016-04-12 18:12:13 +02:00
Stefan Tröger
45861b4f92 remove linear and S-shape scaling from pipe
They worked and are nice feature, but the handling with properties must be worked out better. To avoid any incompatibility due to property changes the functionality is removed now.
2016-04-12 18:12:13 +02:00
Stefan Tröger
d980952d31 fix body and part tool texts 2016-04-12 18:12:13 +02:00
blobfish
389007f17e Core: Gui: DAGView: Various changes. See Following.
Font size hack for windows DPI workaround
    Adding optional layout direction
    Basic filter framework.
    Column logic beyond just parent.
    Factor out graph and graphLink to separate source files
    Factor out rectitem to separate source files
    Rename custom rect item
2016-04-12 18:12:13 +02:00
Stefan Tröger
7d759a5793 delete features when deleting body 2016-04-12 18:12:13 +02:00
Stefan Tröger
07b7d9ff08 part deletion handling
-remove everxthing that belongs to a part on deletion
-disallow to delete the origin by the user and only remove it when Part is being deleted
2016-04-12 18:12:13 +02:00
Stefan Tröger
ecfe545b3b add part tool to task dialog for no selection 2016-04-12 18:12:13 +02:00
Stefan Tröger
0606e767cd fix pipe task dialog icon 2016-04-12 18:12:13 +02:00
Stefan Tröger
939286ca3e add shaft wizard only when building fem 2016-04-12 18:12:13 +02:00
Stefan Tröger
12c5e1f92f remove hole feature
A hole feature is something needed, however, the current implementation does not use the attacher code which would made it intuitive and compatibel to other workbench tools. A reimplementation is needed.
2016-04-12 18:12:13 +02:00
DeepSOIC
72c70bcc50 Datum UI: fixes
* fix messagebox not popping when clicking OK but status is error
* accept preselection
* unify code for all datum commands
* edit selected datum if type matches, instead of creating new one
2016-04-12 18:12:13 +02:00
DeepSOIC
a48f9a682c Sketcher: use Selection's getAsPropertyLinkSubList 2016-04-12 18:12:13 +02:00
DeepSOIC
5449001083 Selection: add getAsPropertyLinkSubList method
Got tired of collecting selection into such properties over and over.
2016-04-12 18:12:13 +02:00
DeepSOIC
03e354f7ac PartDesign: fix porting procedure...
...that caused an assert in attacher that back/front subshape strings
were used for attachment to App::Plane.
2016-04-12 18:12:13 +02:00
DeepSOIC
4e57b1a2ec Datum UI: fixes
* fix highlighting of reference buttons when active
* fix selection of whole objects
* fix some other logic
2016-04-12 18:12:13 +02:00
Stefan Tröger
de0768af80 fix crash on datum point preselect
It is unclear why the coordinates are NULL. This fix prevents the crash but does not fix the reason why this unnormality occurs.
2016-04-12 18:12:13 +02:00
Stefan Tröger
7deb6393cc no temporaries at by reference parameter 2016-04-12 18:12:12 +02:00
Stefan Tröger
4e295c03ed fix crash in boolean op if no base feature exists 2016-04-12 18:12:12 +02:00
DeepSOIC
98717f010a Attacher: proximity modes
The modes that base on distToShape:
* a line that connects the closest points,
* the actual points
2016-04-12 18:12:12 +02:00
DeepSOIC
a3d9907e8c PartDesign: adapt Datum UI to work using Attacher
* adapt
* introduce mode selection
* kill selection gate to allow selecting whole objects (selection gate
should be reintroduced to disallow references between parts, no
restrictions is a temporary state)
* prevent auto-switchover to next ref after an explicit push of a button
* fix highlighting of buttons when selecting corresponding reference
* allow creation of a feature, even if no mode fits references. With a
warning.
2016-04-12 18:12:12 +02:00
DeepSOIC
a5d38c9a99 PartDesign: patch old partdesign porting for changes in Datums 2016-04-12 18:12:12 +02:00
DeepSOIC
9e440b955c PartDesign: transfer Datums to become AttachableObjects
Crude and quick, needs cleanup.
2016-04-12 18:12:12 +02:00
DeepSOIC
40592e6055 Attacher: line and point AttachEngines. Other changes.
* propose attachment modes
* refactor setUp and Copy
* split off postprocessing from 3D to reuse in 1D and 0D calculations
* AttachableObject: fix error printout in onChange
* AttachableObject: no more defaults to Attacher3D
* implementation of lines and points attachment (some of the proposed modes).
* refactor getShapeType, add getShapeType(obj, sub); add a flag to eRefType enum, indicating that referenced thing is a whole object that has placement.
* change readLinks to be static, and obtain shape types in the process.
* test mode enums lengths equality
* extend ObjectXY to work on conics.
* Fix upside-down sketches attached as TangentPlane on most shapes.
* Fix crash when a shape of unlisted type is in the links.
* fix attaching to datum lines go crazy because of infinities.
* abs->fabs
* support for App::Line
* Add namespace qualifiers to TYPESYSTEM_SOURCE-like stuff
2016-04-12 18:12:12 +02:00
blobfish
1284810891 Core: Gui: DAGView: Misc fixes, see following
adding dagVisible and test filter(disabled)
    highlight connectors
    fix for double click crash.
    adding visible isolation on right click
    forgot to remove new icons from scene
2016-04-12 18:12:12 +02:00
DeepSOIC
4800957858 Attacher: change Part2DObject's MapMode default to mmDeactivated, and set mode to mmFlatFace only when reading files of old format.
PartDesign, Sketcher: set mapping mode when setting support

Mapping mode mmFlatFace is no longer default, so an explicit assignment
is required.
2016-04-12 18:12:12 +02:00
DeepSOIC
fa441a9623 PropertyLinkSubList, Sketcher: move legacy Support readout from PropertyContainer to Part2DObject 2016-04-12 18:12:12 +02:00
DeepSOIC
ad01411efc Attacher: fix crash of suggestor on compounds 2016-04-12 18:12:12 +02:00
DeepSOIC
34784b2d29 PartDesign: Fix revolution
It failed to close task if starting a body.
2016-04-12 18:12:12 +02:00
DeepSOIC
f688546106 InvoluteGear: positionBySupport 2016-04-12 18:12:12 +02:00
DeepSOIC
acac286cd0 Sketch: expose positionBySupport python func 2016-04-12 18:12:12 +02:00
DeepSOIC
4cc9b32e32 PartDesign: accomodating to sketch's multisupport
* FeatureSketchBased getSupportFace check for mapping mode
* Fixes failure to place sketches on DatumPlanes
2016-04-12 18:12:12 +02:00
DeepSOIC
2a390660c8 Sketcher: minimalistic UI for new attachment engine 2016-04-12 18:12:12 +02:00
DeepSOIC
42ecc24ec5 Sketcher: new attachment engine 2016-04-12 18:12:12 +02:00
DeepSOIC
061747f367 Sketcher: change Support from PropertyLinkSub to PropertyLinkSubList
Note: may fail to build after this commit...
2016-04-12 18:12:12 +02:00
DeepSOIC
ac5730996d PropertyLinkSubList: make it backwards-compatible with PropertyLinkSub
To assist porting Sketch's Support property from linkSub to linkSubList.
Includes file reading backwards compatibility.
2016-04-12 18:12:11 +02:00
DeepSOIC
eccff10d90 PartDesign: fix refuse to pad
When something was depending on a sketch (another sketch, for example),
padding (revolving, pocketing, etc) it was impossible. This is fixed.

Also, padding or revolving a single sketch twice was allowed (with a
warning msg displayed).
2016-04-12 18:12:11 +02:00
Alexander Golubev
445c26f658 PartDesign/Body: make insert/removeFeature treat NULL in a less special way 2016-04-12 18:12:11 +02:00
Alexander Golubev
bf58a7be2a PartDesign: make MoveFeatureInTree command use new insert functions 2016-04-12 18:12:11 +02:00
Alexander Golubev
9c113357c5 PartDesign: add migrating sketch support to MoveFeature command 2016-04-12 18:12:11 +02:00
Alexander Golubev
03d3f45277 PartDesign/Workbench: make a message more translation-frendly 2016-04-12 18:12:11 +02:00
Alexander Golubev
ad461fc472 PartDesign: fix spacing in several files 2016-04-12 18:12:11 +02:00
Alexander Golubev
7e1a76eb37 PartDesign/Workbench: move fix of sketch support into separate function
Outside PartDesign sketches can have no support plane for them. But
PartDesign doesn't allow that.
Move the code for migration of "free" sketches of planes
into a separate fuction so it may be reused.
2016-04-12 18:12:11 +02:00
Alexander Golubev
7c2413b0aa PartDesign/Body: add methodes to insert features into specific place
Add a Body::insertFeature() methodes as well as python API for it.
2016-04-12 18:12:11 +02:00
DeepSOIC
ec2bbc4c34 Loft: fix build with MSVC2013 2016-04-12 18:12:11 +02:00
DeepSOIC
4b48362ec6 PartDesign: refactor positionBySketch
Rename it to positionByPrevious. Rewrite.
Rewrite SketchBased::transformPlacement.
2016-04-12 18:12:11 +02:00
DeepSOIC
03be8e1bba PartDesign: tidy up sketch support and base feature confusion
Not complete, transformPlacement and positionBySketch are pending...
2016-04-12 18:12:11 +02:00
Alexander Golubev
b67c8bd34d PartDesign/FeatureDraft: fix a wronly placed NOT 2016-04-12 18:12:11 +02:00
Alexander Golubev
b9f4e10fa5 PartDesign: fix a couple of crashes
The first crash was reported here:
http://forum.freecadweb.org/viewtopic.php?f=20&t=11205&start=50#p91052

The second one accures then moving a feature from a body without solid
features.
2016-04-12 18:12:11 +02:00
Stefan Tröger
08e4151ea1 make hole feature work again 2016-04-12 18:12:11 +02:00
Stefan Tröger
7f80e711f6 better active part and document tip handling 2016-04-12 18:12:10 +02:00
Stefan Tröger
d435e15a97 make part design loft functional 2016-04-12 18:12:10 +02:00
Stefan Tröger
987880fffa add loft viewprovider 2016-04-12 18:12:10 +02:00
Stefan Tröger
c82e4117e9 add feature loft 2016-04-12 18:12:10 +02:00
Alexander Golubev
f4a5bf6acd PartDesign: remove Body::isFeature() because it's the same as BodyBase::hasFeature() 2016-04-12 18:12:10 +02:00
DeepSOIC
36fe5994b9 Revolution: fix crash when selecting stuff during task 2016-04-12 18:12:10 +02:00
Danny Lepage
8aecb00a8d Fix Debug Assert in CmdPartDesignDuplicateSelection::activated
Under Windows, "Edit/Duplicate selected object" raised a
Debug Assertion Failed "Expression: sequence not ordered".
2016-04-12 18:12:10 +02:00
Danny Lepage
63bdbe5561 Fix Boolean operation tooltip text.
As reported by triplus
2016-04-12 18:12:10 +02:00
DeepSOIC
578f038cf9 Fix programming error in DatumCS 2016-04-12 18:12:10 +02:00
DeepSOIC
7653d2d48f Fix build on Windows 2016-04-12 18:12:10 +02:00
DeepSOIC
a362829d1e Add QAbstractEventDispatcher to Qt4All.h 2016-04-12 18:12:10 +02:00
blobfish
54a3336af5 Core: Gui: DAGView: Basic Functionality 2016-04-12 18:12:10 +02:00
blobfish
a85328c546 Core: Gui: DAGView design 2016-04-12 18:12:10 +02:00
blobfish
1586399c80 Core: Gui: DAGView: adding icons 2016-04-12 18:12:10 +02:00
blobfish
3e65723472 Core: Gui: DAGView: skeleton implemented
Need to enable through parameter BaseApp/Preferences/DAGView
2016-04-12 18:12:10 +02:00
blobfish
6349a3d478 Core: Gui: DAGView design 2016-04-12 18:12:09 +02:00
Stefan Tröger
ab2cc10ac7 add missing return value 2016-04-12 18:12:09 +02:00
Stefan Tröger
c0e850cd0d remove import dependency on assembly workbench 2016-04-12 18:12:09 +02:00
Stefan Tröger
84cd1588d0 Update pipe icon and add it to the taskwatcher 2016-04-12 18:12:09 +02:00
Stefan Tröger
20d551bc88 fix part and body search for invalid objects 2016-04-12 18:12:09 +02:00
Stefan Tröger
3aae4ce011 respect part design placement rules in pipe 2016-04-12 18:12:09 +02:00
Stefan Tröger
620b2bb5d7 simple bugfixes 2016-04-12 18:12:09 +02:00
Stefan Tröger
68ee7f4f27 add two scaling modes 2016-04-12 18:12:09 +02:00
Stefan Tröger
df386cc3c1 make multisection work 2016-04-12 18:12:09 +02:00
Stefan Tröger
d796ca2bf9 better pipe view handling 2016-04-12 18:12:09 +02:00
Stefan Tröger
a727a9b93d prevent inverted pipes and correct camera adjustment 2016-04-12 18:12:09 +02:00
Stefan Tröger
342ba89afd generalize preview mode 2016-04-12 18:12:09 +02:00
Stefan Tröger
68d172687b implement faster pipes with inner wires 2016-04-12 18:12:09 +02:00
Stefan Tröger
0db83e816a allow sketches with inner wires as pipe profiles 2016-04-12 18:12:09 +02:00
Stefan Tröger
9c4e1070eb add options for pipe tool 2016-04-12 18:12:09 +02:00
Stefan Tröger
e7803eca61 add basic part design pipe infrastructure 2016-04-12 18:12:09 +02:00
Stefan Tröger
0f30096cec make new document views obey the scene graph children stacking 2016-04-12 18:12:08 +02:00
Stefan Tröger
54646ef5bd fix wrong torus addition 2016-04-12 18:12:08 +02:00
Stefan Tröger
a8f27937de fix sketch editing within transformed parts 2016-04-12 18:12:08 +02:00
Stefan Tröger
e7284ecde8 fix crash on cancel primitive 2016-04-12 18:12:08 +02:00
Stefan Tröger
6347fe8c86 make origin work correct with multiple parts 2016-04-12 18:12:08 +02:00
Stefan Tröger
ec68192fcf fix primitive following cs in edit mode and add python console output when closing the task 2016-04-12 18:12:08 +02:00
Stefan Tröger
a19eaf201e add command for adding a new part
note that the icon is a placeholder as currently parts have a system icon which can not be set for commands
2016-04-12 18:12:08 +02:00
Stefan Tröger
d8a0e398a9 make origin lines usable in groove 2016-04-12 18:12:08 +02:00
Stefan Tröger
ec125cf9f2 make origin lines usable in revolution 2016-04-12 18:12:08 +02:00
Stefan Tröger
c5ae4530ab add primitive preview visualization 2016-04-12 18:12:08 +02:00
Stefan Tröger
0a82185b66 add more point possibilities for cs references 2016-04-12 18:12:08 +02:00
Stefan Tröger
4087ffaef7 make datum feedback more prominent 2016-04-12 18:12:08 +02:00
Stefan Tröger
d3a7e9a928 fix selection error on datum exception
and add user feedback for failed selections
2016-04-12 18:12:08 +02:00
Stefan Tröger
7cb6606dc2 add remaining coordinate system selections 2016-04-12 18:12:08 +02:00
Stefan Tröger
96584f776a viewprovider for coordinate system update 2016-04-12 18:12:08 +02:00
Stefan Tröger
42264b43ca add a few coordinate system reference systems 2016-04-12 18:12:08 +02:00
Stefan Tröger
c3f35d9f05 add part design thickness 2016-04-12 18:12:08 +02:00
Stefan Tröger
7971bdbb8e delete primitive if initial task is canceled 2016-04-12 18:12:07 +02:00
Stefan Tröger
fc1e8b8d17 allow to add faces to fillet and chamfer 2016-04-12 18:12:07 +02:00
Stefan Tröger
329064d671 don't create unneeded second body if part is created 2016-04-12 18:12:07 +02:00
Stefan Tröger
49973895f9 fix primitive offset setting issues 2016-04-12 18:12:07 +02:00
Stefan Tröger
6067c64060 allow subtractive primitive only if base available 2016-04-12 18:12:07 +02:00