suzanne.soy/anaphoric

Add anaphoric map and filter #10

Merged

goderich merged 1 commits from main into main

2021-07-29 01:46:35 +01:00

goderich commented

2021-07-10 08:39:37 +01:00

(Migrated from github.com)

I've added documentation and tests, as per your request. I've also changed the heading in the documentation to a more general 'Anaphoric macros', now that it's not just conditionals.

Please let me know if I need to fix anything else in the code or the documentation.

I just realized that I've left the README unchanged, so maybe it needs to be updated as well?

I've added documentation and tests, as per your request. I've also changed the heading in the documentation to a more general 'Anaphoric macros', now that it's not just conditionals. Please let me know if I need to fix anything else in the code or the documentation. I just realized that I've left the README unchanged, so maybe it needs to be updated as well?

SuzanneSoy (Migrated from github.com) approved these changes 2021-07-11 22:12:17 +01:00

scribblings/anaphoric.scrbl

SuzanneSoy (Migrated from github.com) commented

2021-07-11 19:06:40 +01:00

@defform[[(amap body lst)]]{

proc would suggest that an expression returning a procedure is needed, but this is a macro taking an expression which produces the desired result directly.

```suggestion @defform[[(amap body lst)]]{ ``` `proc` would suggest that an expression returning a procedure is needed, but this is a macro taking an expression which produces the desired result directly.

SuzanneSoy (Migrated from github.com) commented

2021-07-11 19:07:50 +01:00

@defform[[(afilter body lst)]]{

proc would suggest that an expression returning a procedure is needed, but this is a macro taking an expression which produces the desired result directly.

```suggestion @defform[[(afilter body lst)]]{ ``` `proc` would suggest that an expression returning a procedure is needed, but this is a macro taking an expression which produces the desired result directly.

SuzanneSoy (Migrated from github.com) commented

2021-07-11 19:10:54 +01:00

  @racketblock[(amap (string-append (string-upcase it) "!")
                     '("apple" "banana"))]

quick indentation fix :)

```suggestion @racketblock[(amap (string-append (string-upcase it) "!") '("apple" "banana"))] ``` quick indentation fix :)

SuzanneSoy (Migrated from github.com) commented

2021-07-11 19:11:37 +01:00

 as wrapping the @racketid[body] in a @racket[lambda] with an @racket[it] parameter. Unlike @racket[map], @racket[amap]

```suggestion as wrapping the @racketid[body] in a @racket[lambda] with an @racket[it] parameter. Unlike @racket[map], @racket[amap] ```

SuzanneSoy (Migrated from github.com) commented

2021-07-11 19:13:07 +01:00

 @racket[amap] works with nested function calls:

seems slightly clearer (otherwise nested functions could be understood as (lambda (foo) (lambda (bar) …)))

```suggestion @racket[amap] works with nested function calls: ``` seems slightly clearer (otherwise nested functions could be understood as `(lambda (foo) (lambda (bar) …))`)

SuzanneSoy (Migrated from github.com) commented

2021-07-11 19:36:25 +01:00

  @racketblock[(amap (* it it) '(1 2 3))]

quick indentation fix

```suggestion @racketblock[(amap (* it it) '(1 2 3))] ``` quick indentation fix

SuzanneSoy (Migrated from github.com) commented

2021-07-11 19:39:12 +01:00

 in the @racketid[body], and maps it over the list @racketid[lst]. Effectively the same

```suggestion in the @racketid[body], and maps it over the list @racketid[lst]. Effectively the same ```

SuzanneSoy (Migrated from github.com) commented

2021-07-11 19:47:19 +01:00

 in the @racketid[body], and filters the list @racketid[lst] using it. Effectively the same

```suggestion in the @racketid[body], and filters the list @racketid[lst] using it. Effectively the same ```

SuzanneSoy (Migrated from github.com) commented

2021-07-11 19:48:11 +01:00

 as wrapping the body in a @racket[lambda] with an @racket[it] parameter.

```suggestion as wrapping the body in a @racket[lambda] with an @racket[it] parameter. ```

SuzanneSoy (Migrated from github.com) commented

2021-07-11 19:50:15 +01:00

 @racket[afilter] works with nested function calls:

```suggestion @racket[afilter] works with nested function calls: ```

SuzanneSoy (Migrated from github.com) commented

2021-07-11 19:50:23 +01:00

  @racketblock[(afilter ((* it it) . > . 50) lst)]

```suggestion @racketblock[(afilter ((* it it) . > . 50) lst)] ```

test/afilter-test.rkt

SuzanneSoy (Migrated from github.com) commented

2021-07-11 19:57:39 +01:00

 "Nested function call.")

```suggestion "Nested function call.") ```

goderich commented

2021-07-12 04:21:03 +01:00

(Migrated from github.com)

@jsmaniac Thank you, I've integrated all your suggestions and squashed them into one commit!

@jsmaniac Thank you, I've integrated all your suggestions and squashed them into one commit!

SuzanneSoy commented

2021-07-29 01:58:34 +01:00

(Migrated from github.com)

Sorry about the delay in merging this, getting GitHub Actions to work instead of Travis was quite a bit of work! Thanks a lot for the contribution :)

Sorry about the delay in merging this, getting GitHub Actions to work instead of Travis was quite a bit of work! Thanks a lot for the contribution :)

goderich commented

2021-07-29 07:15:00 +01:00

(Migrated from github.com)

No worries, thanks for welcoming me! :)

No worries, thanks for welcoming me! :)

Sign in to join this conversation.

No reviewers

No Label

No Milestone

No project

No Assignees

1 Participants

Notifications

Due Date

The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: suzanne.soy/anaphoric#10

No description provided.