add and-let #5

2018-01-26T03:52:45Z

AlexKnauth commented

2018-01-26 03:52:45 +00:00

(Migrated from github.com)

;; maybe-append : [Maybe [Listof X]] [Maybe [Listof X]] -> [Maybe [Listof X]]
(define (maybe-append x y)
  (and-let [x x] [y y] (append x y)))

;; maybe-map : [X -> [Maybe Y]] [Listof X] -> [Maybe [Listof Y]]
(define (maybe-map f xs)
  (cond
    [(empty? xs) '()]
    [else
     (and-let [f-fst (f (first xs))]
              [f-rst (maybe-map f (rest xs))]
              (cons f-fst f-rst))]))

``` ;; maybe-append : [Maybe [Listof X]] [Maybe [Listof X]] -> [Maybe [Listof X]] (define (maybe-append x y) (and-let [x x] [y y] (append x y))) ;; maybe-map : [X -> [Maybe Y]] [Listof X] -> [Maybe [Listof Y]] (define (maybe-map f xs) (cond [(empty? xs) '()] [else (and-let [f-fst (f (first xs))] [f-rst (maybe-map f (rest xs))] (cons f-fst f-rst))])) ```

codecov-io commented

2018-01-26 04:34:56 +00:00

(Migrated from github.com)

Codecov Report

Merging #5 into master will increase coverage by 0.48%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master       #5      +/-   ##
==========================================
+ Coverage   89.33%   89.81%   +0.48%     
==========================================
  Files          16       17       +1     
  Lines         422      442      +20     
==========================================
+ Hits          377      397      +20     
  Misses         45       45

Impacted Files	Coverage Δ
scribblings/anaphoric.scrbl	`100% <ø> (ø)`	⬆️
main.rkt	`100% <100%> (ø)`	⬆️
and-let.rkt	`100% <100%> (ø)`

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update affa5e1...8cec548. Read the comment docs.

# [Codecov](https://codecov.io/gh/jsmaniac/anaphoric/pull/5?src=pr&el=h1) Report > Merging [#5](https://codecov.io/gh/jsmaniac/anaphoric/pull/5?src=pr&el=desc) into [master](https://codecov.io/gh/jsmaniac/anaphoric/commit/affa5e15a0e8dd488b835a77332d3d09bca3b03a?src=pr&el=desc) will **increase** coverage by `0.48%`. > The diff coverage is `100%`. [![Impacted file tree graph](https://codecov.io/gh/jsmaniac/anaphoric/pull/5/graphs/tree.svg?token=w3WpsCdEtS&src=pr&width=650&height=150)](https://codecov.io/gh/jsmaniac/anaphoric/pull/5?src=pr&el=tree) ```diff @@ Coverage Diff @@ ## master #5 +/- ## ========================================== + Coverage 89.33% 89.81% +0.48% ========================================== Files 16 17 +1 Lines 422 442 +20 ========================================== + Hits 377 397 +20 Misses 45 45 ``` | [Impacted Files](https://codecov.io/gh/jsmaniac/anaphoric/pull/5?src=pr&el=tree) | Coverage Δ | | |---|---|---| | [scribblings/anaphoric.scrbl](https://codecov.io/gh/jsmaniac/anaphoric/pull/5/diff?src=pr&el=tree#diff-c2NyaWJibGluZ3MvYW5hcGhvcmljLnNjcmJs) | `100% <ø> (ø)` | :arrow_up: | | [main.rkt](https://codecov.io/gh/jsmaniac/anaphoric/pull/5/diff?src=pr&el=tree#diff-bWFpbi5ya3Q=) | `100% <100%> (ø)` | :arrow_up: | | [and-let.rkt](https://codecov.io/gh/jsmaniac/anaphoric/pull/5/diff?src=pr&el=tree#diff-YW5kLWxldC5ya3Q=) | `100% <100%> (ø)` | | ------ [Continue to review full report at Codecov](https://codecov.io/gh/jsmaniac/anaphoric/pull/5?src=pr&el=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/jsmaniac/anaphoric/pull/5?src=pr&el=footer). Last update [affa5e1...8cec548](https://codecov.io/gh/jsmaniac/anaphoric/pull/5?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).

SuzanneSoy (Migrated from github.com) reviewed 2018-01-27 10:39:01 +00:00

and-let.rkt

						
				@ -0,0 +2,4 @@

				(provide and-let)

				(require syntax/parse/define "if-let.rkt" (for-syntax racket/base))

SuzanneSoy (Migrated from github.com) commented

2018-01-27 10:39:01 +00:00

Thanks for the PR!

I'm adding a aand form too, to keep the symmetry with other forms (if-let / aif, etc.), and I'll merge in 5 minutes.

Just out of curiosity, is there any specific reason for using syntax/parse/define instead of syntax/parse, since you are not using define-simple-macro?

Thanks for the PR! I'm adding a `aand` form too, to keep the symmetry with other forms (`if-let` / `aif`, etc.), and I'll merge in 5 minutes. Just out of curiosity, is there any specific reason for using `syntax/parse/define` instead of `syntax/parse`, since you are not using define-simple-macro?

AlexKnauth (Migrated from github.com) reviewed 2018-01-27 14:39:05 +00:00

and-let.rkt

						
				@ -0,0 +2,4 @@

				(provide and-let)

				(require syntax/parse/define "if-let.rkt" (for-syntax racket/base))

AlexKnauth (Migrated from github.com) commented

2018-01-27 14:39:05 +00:00

No, there isn’t. A previous version of this PR used define-syntax-parser, and I didn’t think to change the require back.

No, there isn’t. A previous version of this PR used `define-syntax-parser`, and I didn’t think to change the require back.

SuzanneSoy (Migrated from github.com) reviewed 2018-01-27 14:52:42 +00:00

and-let.rkt

						
				@ -0,0 +2,4 @@

				(provide and-let)

				(require syntax/parse/define "if-let.rkt" (for-syntax racket/base))

SuzanneSoy (Migrated from github.com) commented

2018-01-27 14:52:42 +00:00

Merged, thanks for the clarification :) !

Sign in to join this conversation.

No reviewers

No Label

No Milestone

No project

No Assignees

1 Participants

Notifications

Due Date

The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: suzanne.soy/anaphoric#5