suzanne.soy/phc-adt
1
0
Fork 0
Code Issues 11 Pull Requests 1 Actions Packages Projects Releases Wiki Activity

Handle Integer instead of Fixnum for hash-code computation. #19

Open
samth wants to merge 1 commits from samth/master into main
pull from: samth/master
merge into: suzanne.soy:main
Conversation 3 Commits 1 Files Changed 1 +3 -3
samth commented 2019-11-06 18:29:54 +00:00 (Migrated from github.com)
Copy Link

Now that these are type checked by Typed Racket in 7.5, it's a
problem that the documentation doesn't promise that these will be a
Fixnum. Switch to using Integer, and change the use of fxxor to
match.

Now that these are type checked by Typed Racket in 7.5, it's a problem that the documentation doesn't promise that these will be a Fixnum. Switch to using Integer, and change the use of fxxor to match.
samth commented 2019-11-06 20:42:29 +00:00 (Migrated from github.com)
Copy Link

I think the test failure is because you'd need to merge the similar PR in jsmaniac/typed-struct-props.

I think the test failure is because you'd need to merge the similar PR in jsmaniac/typed-struct-props.
SuzanneSoy commented 2019-11-11 22:38:58 +00:00 (Migrated from github.com)
Copy Link

Hi, thanks for the fix. I have a bunch of packages that I need to update, so I'm not surprised the tests fail. I'll try to find some time in the coming weeks to update all that stuff… my bad, sorry!

Hi, thanks for the fix. I have a bunch of packages that I need to update, so I'm not surprised the tests fail. I'll try to find some time in the coming weeks to update all that stuff… my bad, sorry!
samth commented 2019-11-11 23:09:54 +00:00 (Migrated from github.com)
Copy Link

I think just merging this PR will fix the build problem and also fix a number of packages that depend on your code.

I think just merging this PR will fix the build problem and also fix a number of packages that depend on your code.
This pull request has changes conflicting with the target branch.
  • phc-adt-lib/phc-adt/node-low-level.hl.rkt
View command line instructions.

Checkout

From your project repository, check out a new branch and test the changes.
git fetch -u origin samth/master:samth/master
git checkout samth/master

Merge

Merge the changes and update on Gitea.
git checkout main
git merge --no-ff samth/master
git checkout main
git merge --ff-only samth/master
git checkout samth/master
git rebase main
git checkout main
git merge --no-ff samth/master
git checkout main
git merge --squash samth/master
git checkout main
git merge --ff-only samth/master
git checkout main
git merge samth/master
git push origin main
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
bug

   
doc

   
duplicate

   
enhancement

   
help wanted

   
invalid

   
question

   
test

   
wontfix
No Label
bug
doc
duplicate
enhancement
help wanted
invalid
question
test
wontfix
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
1 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: suzanne.soy/phc-adt#19
No description provided.
Delete Branch "samth/master"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?