suzanne.soy/racket
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Cleanup FIXME comments

Browse Source
This commit is contained in:
Asumu Takikawa 2013-05-22 22:47:48 -04:00
parent 6f86c66199
commit 384e1392bd
2 changed files with 1 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
pkgs/typed-racket-pkgs/typed-racket-lib/typed-racket/base-env/class-prims.rkt
View File

@ -162,7 +162,6 @@
;; Listof<Clause> -> Hash<Identifier, Names> ;; Listof<Clause> -> Hash<Identifier, Names>
;; Extract names from init, public, etc. clauses ;; Extract names from init, public, etc. clauses
;; FIXME: deal with internal vs. external names
(define (extract-names clauses) (define (extract-names clauses)
(for/fold ([clauses (make-immutable-free-id-table)]) (for/fold ([clauses (make-immutable-free-id-table)])
([clause clauses]) ([clause clauses])
@ -283,8 +282,7 @@
#:literals (define-values super-new) #:literals (define-values super-new)
;; if it's a method definition for a declared method, then ;; if it's a method definition for a declared method, then
;; mark it as something to type-check ;; mark it as something to type-check
;; FIXME: this needs to handle external/internal names too ;; FIXME: this needs to track augments, etc.
;; FIXME: this needs to track privates, augments, etc.
[(define-values (id) . rst) [(define-values (id) . rst)
#:when (memf (λ (n) (free-identifier=? #'id n)) #:when (memf (λ (n) (free-identifier=? #'id n))
(append (stx-map stx-car (dict-ref name-dict #'public '())) (append (stx-map stx-car (dict-ref name-dict #'public '()))

7
pkgs/typed-racket-pkgs/typed-racket-lib/typed-racket/typecheck/check-class-unit.rkt
View File

@ -367,11 +367,6 @@
;; -> List<Id> List<Type> List<Id> List<Type> ;; -> List<Id> List<Type> List<Id> List<Type>
;; Construct mappings to put into the lexical type-checking environment ;; Construct mappings to put into the lexical type-checking environment
;; from the class local accessor mappings ;; from the class local accessor mappings
;;
;; FIXME: the types we put here are fine in the expected
;; case, but not if the class doesn't have an annotation.
;; Then we need to hunt down annotations in a first pass.
;; (should probably do this in expected case anyway)
(define (local-tables->lexical-env internal-external-mapping (define (local-tables->lexical-env internal-external-mapping
local-method-table methods method-names local-method-table methods method-names
local-field-table fields field-names local-field-table fields field-names
@ -763,8 +758,6 @@
(for/or ([m (in-set required)]) (for/or ([m (in-set required)])
(and (not (set-member? actual m)) m))) (and (not (set-member? actual m)) m)))
(when missing (when missing
;; FIXME: make this a delayed error? Do it for every single
;; name separately?
(tc-error/expr "class definition missing ~a ~a" msg missing))) (tc-error/expr "class definition missing ~a ~a" msg missing)))
;; Set<Symbol> Set<Symbol> String -> Void ;; Set<Symbol> Set<Symbol> String -> Void