suzanne.soy/racket
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

adjust the installer dialog so that it prints a "completed"

Browse Source 
message at the end of the transcript and so that it shuts down
the installation custodian (which means that any threads or
anything like that that the .plt file's code may have created
will die, plus that the "abort installation" button will now
be greyed out)

closes PR 13122
This commit is contained in:
Robby Findler 2012-09-19 06:00:26 -05:00
parent 51d41c6cfe
commit f1dd6be88b
2 changed files with 11 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
collects/setup/plt-installer-unit.rkt
View File

@ -38,9 +38,9 @@
(stretchable-height #f)
(alignment '(center center)))]
[kill-button (make-object button%
(string-constant plt-installer-abort-installation)
button-panel
(lambda (b e) (kill)))]
(string-constant plt-installer-abort-installation)
button-panel
(lambda (b e) (kill)))]
[done (make-object button% (string-constant close) button-panel (lambda (b e) (done-callback)))]
[output (make-output-port
#f
@ -102,9 +102,11 @@
(parameterize ([current-eventspace orig-eventspace])
(queue-callback
(lambda ()
(fprintf output "\nInstallation complete.\n")
(set! completed-successfully? #t)
((on-installer-run))
(cleanup-thunk))))
(cleanup-thunk)
(custodian-shutdown-all installer-cust))))
(send done enable #t)))))))))

5
doc/release-notes/drracket/HISTORY.txt
View File

@ -13,6 +13,11 @@
word-wrapping (this avoids some performance problems when very
large values are rendered there)
. Adjust the Install .plt File dialog so that it cleans up after the
end of an installation (specifically, it shuts down the custodian
that was running the installation process), which also causes the
Abort button to be disabled.
------------------------------
Version 5.3
------------------------------