suzanne.soy/scribble-math
1
0
Fork 0
Code Issues 8 Pull Requests 3 Actions Packages Projects Releases Wiki Activity

Make make lint not automatically fix lint

Browse Source 
Summary: Looks like there was lint, but `make lint` wasn't failing on it
because it would just automatically fix it! This removes the `--fix`
from `eslint` and fixes the lint.

Test Plan:
 - `make lint`

Auditors: kevinb
This commit is contained in:
Emily Eisenberg 2016-04-15 12:08:14 -07:00
parent 965b8a6164
commit ccd8f40028
2 changed files with 7 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
Makefile
View File

@ -17,7 +17,7 @@ setup:
npm install npm install
lint: katex.js server.js cli.js $(wildcard src/*.js) $(wildcard test/*.js) $(wildcard contrib/*/*.js) $(wildcard dockers/*/*.js) lint: katex.js server.js cli.js $(wildcard src/*.js) $(wildcard test/*.js) $(wildcard contrib/*/*.js) $(wildcard dockers/*/*.js)
./node_modules/.bin/eslint --fix $^ ./node_modules/.bin/eslint $^
build/katex.js: katex.js $(wildcard src/*.js) build/katex.js: katex.js $(wildcard src/*.js)
$(BROWSERIFY) $< --standalone katex > $@ $(BROWSERIFY) $< --standalone katex > $@

11
test/katex-spec.js
View File

@ -421,12 +421,13 @@ describe("A parser with limit controls", function() {
it("should have the rightmost limit control determine the limits property " + it("should have the rightmost limit control determine the limits property " +
"of the preceding op node", function() { "of the preceding op node", function() {
var parsedInput = getParsed("\\int\\nolimits\\limits_2^2");
expect(parsedInput[0].value.base.value.limits).toBe(true);
parsedInput = getParsed("\\int\\limits_2\\nolimits^2"); var parsedInput = getParsed("\\int\\nolimits\\limits_2^2");
expect(parsedInput[0].value.base.value.limits).toBe(false); expect(parsedInput[0].value.base.value.limits).toBe(true);
});
parsedInput = getParsed("\\int\\limits_2\\nolimits^2");
expect(parsedInput[0].value.base.value.limits).toBe(false);
});
}); });
describe("A group parser", function() { describe("A group parser", function() {