v3 finish builds/find_spec tests

This commit is contained in:
carlad 2015-08-24 13:27:27 +02:00
parent 517b3b60ef
commit 11f5f2cb66

View File

@ -2,7 +2,7 @@ require 'spec_helper'
describe Travis::API::V3::Services::Builds::Find do describe Travis::API::V3::Services::Builds::Find do
let(:repo) { Repository.by_slug('svenfuchs/minimal').first } let(:repo) { Repository.by_slug('svenfuchs/minimal').first }
let(:build) { repo.builds.first } let(:build) { repo.builds.last }
let(:parsed_body) { JSON.load(body) } let(:parsed_body) { JSON.load(body) }
describe "fetching builds on a public repository by slug" do describe "fetching builds on a public repository by slug" do
@ -26,8 +26,27 @@ describe Travis::API::V3::Services::Builds::Find do
example { expect(last_response).to be_ok } example { expect(last_response).to be_ok }
example { expect(parsed_body).to be == { example { expect(parsed_body).to be == {
"@type" => "builds", "@type" => "builds",
"@href" => "/v3/repo/#{repo.id}/builds", "@href" => "/v3/repo/#{repo.id}/builds?limit=1",
"builds" => { "@pagination" => {
"limit" => 1,
"offset" => 0,
"count" => 3,
"is_first" => true,
"is_last" => false,
"next" => {
"@href" => "/v3/repo/1/builds?limit=1&offset=1",
"offset" => 1,
"limit" =>1},
"prev" =>nil,
"first" => {
"@href" => "/v3/repo/1/builds?limit=1",
"offset" => 0,
"limit" => 1 },
"last" => {
"@href" => "/v3/repo/1/builds?limit=1&offset=2",
"offset" => 2,
"limit" => 1 }},
"builds" => [{
"@type" => "build", "@type" => "build",
"@href" => "/v3/build/#{build.id}", "@href" => "/v3/build/#{build.id}",
"id" => build.id, "id" => build.id,
@ -37,6 +56,7 @@ describe Travis::API::V3::Services::Builds::Find do
"event_type" => "push", "event_type" => "push",
"previous_state" => "passed", "previous_state" => "passed",
"started_at" => "2010-11-12T13:00:00Z", "started_at" => "2010-11-12T13:00:00Z",
"finished_at" => nil,
"repository" => { "repository" => {
"@type" => "repository", "@type" => "repository",
"@href" => "/v3/repo/1", "@href" => "/v3/repo/1",
@ -47,7 +67,7 @@ describe Travis::API::V3::Services::Builds::Find do
"@href" => "/v3/repo/1/branch/master", "@href" => "/v3/repo/1/branch/master",
"name" => "master", "name" => "master",
"last_build" => { "last_build" => {
"@href"=>"/v3/build/62" }}, "@href"=>"/v3/build/#{build.id}" }},
"commit" => { "commit" => {
"@type" => "commit", "@type" => "commit",
"id" => 5, "id" => 5,
@ -55,303 +75,303 @@ describe Travis::API::V3::Services::Builds::Find do
"ref" => "refs/heads/master", "ref" => "refs/heads/master",
"message" => "unignore Gemfile.lock", "message" => "unignore Gemfile.lock",
"compare_url" => "https://github.com/svenfuchs/minimal/compare/master...develop", "compare_url" => "https://github.com/svenfuchs/minimal/compare/master...develop",
"committed_at" => "2010-11-12T12:55:00Z"}}, "committed_at" => "2010-11-12T12:55:00Z"}}],
}} }}
end end
#
# describe "missing repository" do describe "builds on missing repository" do
# before { get("/v3/repo/999999999999999") } before { get("/v3/repo/999999999999999/builds") }
# example { expect(last_response).to be_not_found } example { expect(last_response).to be_not_found }
# example { expect(parsed_body).to be == { example { expect(parsed_body).to be == {
# "@type" => "error", "@type" => "error",
# "error_type" => "not_found", "error_type" => "not_found",
# "error_message" => "repository not found (or insufficient access)", "error_message" => "repository not found (or insufficient access)",
# "resource_type" => "repository" "resource_type" => "repository"
# }} }}
# end end
#
# describe "public repository, private API" do describe "builds on public repository, private API" do
# before { Travis.config.private_api = true } before { Travis.config.private_api = true }
# before { get("/v3/repo/#{repo.id}") } before { get("/v3/repo/#{repo.id}/builds") }
# after { Travis.config.private_api = false } after { Travis.config.private_api = false }
# example { expect(last_response).to be_not_found } example { expect(last_response).to be_not_found }
# example { expect(parsed_body).to be == { example { expect(parsed_body).to be == {
# "@type" => "error", "@type" => "error",
# "error_type" => "not_found", "error_type" => "not_found",
# "error_message" => "repository not found (or insufficient access)", "error_message" => "repository not found (or insufficient access)",
# "resource_type" => "repository" "resource_type" => "repository"
# }} }}
# end end
#
# describe "private repository, not authenticated" do describe "builds on private repository, not authenticated" do
# before { repo.update_attribute(:private, true) } before { repo.update_attribute(:private, true) }
# before { get("/v3/repo/#{repo.id}") } before { get("/v3/repo/#{repo.id}/builds") }
# before { repo.update_attribute(:private, false) } before { repo.update_attribute(:private, false) }
# example { expect(last_response).to be_not_found } example { expect(last_response).to be_not_found }
# example { expect(parsed_body).to be == { example { expect(parsed_body).to be == {
# "@type" => "error", "@type" => "error",
# "error_type" => "not_found", "error_type" => "not_found",
# "error_message" => "repository not found (or insufficient access)", "error_message" => "repository not found (or insufficient access)",
# "resource_type" => "repository" "resource_type" => "repository"
# }} }}
# end end
#
# describe "private repository, private API, authenticated as user with access" do describe "builds private repository, private API, authenticated as user with access" do
# let(:token) { Travis::Api::App::AccessToken.create(user: repo.owner, app_id: 1) } let(:token) { Travis::Api::App::AccessToken.create(user: repo.owner, app_id: 1) }
# let(:headers) {{ 'HTTP_AUTHORIZATION' => "token #{token}" }} let(:headers) {{ 'HTTP_AUTHORIZATION' => "token #{token}" }}
# before { Permission.create(repository: repo, user: repo.owner, pull: true) } before { Permission.create(repository: repo, user: repo.owner, pull: true) }
# before { repo.update_attribute(:private, true) } before { repo.update_attribute(:private, true) }
# before { get("/v3/repo/#{repo.id}", {}, headers) } before { get("/v3/repo/#{repo.id}/builds?limit=1", {}, headers) }
# after { repo.update_attribute(:private, false) } after { repo.update_attribute(:private, false) }
# example { expect(last_response).to be_ok } example { expect(last_response).to be_ok }
# example { expect(parsed_body).to be == { example { expect(parsed_body).to be == {
# "@type" => "repository", "@type" => "builds",
# "@href" => "/v3/repo/#{repo.id}", "@href" => "/v3/repo/1/builds?limit=1",
# "@permissions" => { "@pagination" => {
# "read" => true, "limit" => 1,
# "enable" => false, "offset" => 0,
# "disable" => false, "count" => 3,
# "create_request" => false}, "is_first" => true,
# "id" => repo.id, "is_last" => false,
# "name" => "minimal", "next" => {
# "slug" => "svenfuchs/minimal", "@href" => "/v3/repo/1/builds?limit=1&offset=1",
# "description" => nil, "offset" => 1,
# "github_language" => nil, "limit" => 1 },
# "active" => true, "prev" => nil,
# "private" => true, "first" => {
# "owner" => { "@href" => "/v3/repo/1/builds?limit=1",
# "@type" => "user", "offset" => 0,
# "@href" => "/v3/user/#{repo.owner_id}", "limit" => 1 },
# "id" => repo.owner_id, "last" => {
# "login" => "svenfuchs" }, "@href" => "/v3/repo/1/builds?limit=1&offset=2",
# "last_build" => { "offset" => 2,
# "@type" => "build", "limit" => 1 }},
# "@href" => "/v3/build/#{repo.last_build_id}", "builds" => [{
# "id" => repo.last_build_id, "@type" => "build",
# "number" => "2", "@href" => "/v3/build/#{build.id}",
# "state" => "passed", "id" => build.id,
# "duration" => nil, "number" => "3",
# "started_at" => "2010-11-12T12:30:00Z", "state" => "configured",
# "finished_at" => "2010-11-12T12:30:20Z"}, "duration" => nil,
# "default_branch" => { "event_type" => "push",
# "@type" => "branch", "previous_state" => "passed",
# "@href" => "/v3/repo/#{repo.id}/branch/master", "started_at" => "2010-11-12T13:00:00Z",
# "name" => "master", "finished_at" =>nil,
# "last_build" => { "repository" => {
# "@type" => "build", "@type" => "repository",
# "@href" => "/v3/build/#{repo.last_build.id}", "@href" => "/v3/repo/1",
# "id" => repo.last_build.id, "id" => 1,
# "number" => "3", "slug" => "svenfuchs/minimal"},
# "state" => "configured", "branch" => {
# "duration" => nil, "@type" => "branch",
# "event_type" => "push", "@href" => "/v3/repo/1/branch/master",
# "previous_state" => "passed", "name" => "master",
# "started_at" => "2010-11-12T13:00:00Z", "last_build" => {
# "finished_at" => nil}} "@href" => "/v3/build/#{build.id}"}},
# }} "commit" => {
# end "@type" => "commit",
# "id" => 5,
# describe "private repository, private API, authenticated as user without access" do "sha" => "add057e66c3e1d59ef1f",
# let(:token) { Travis::Api::App::AccessToken.create(user: User.find(2), app_id: 1) } "ref" => "refs/heads/master",
# let(:headers) {{ 'HTTP_AUTHORIZATION' => "token #{token}" }} "message" => "unignore Gemfile.lock",
# before { repo.update_attribute(:private, true) } "compare_url" => "https://github.com/svenfuchs/minimal/compare/master...develop",
# before { get("/v3/repo/#{repo.id}", {}, headers) } "committed_at" => "2010-11-12T12:55:00Z"}}]
# before { repo.update_attribute(:private, false) } }}
# example { expect(last_response).to be_not_found } end
# example { expect(parsed_body).to be == {
# "@type" => "error", describe "builds on private repository, private API, authenticated as user without access" do
# "error_type" => "not_found", let(:token) { Travis::Api::App::AccessToken.create(user: User.find(2), app_id: 1) }
# "error_message" => "repository not found (or insufficient access)", let(:headers) {{ 'HTTP_AUTHORIZATION' => "token #{token}" }}
# "resource_type" => "repository" before { repo.update_attribute(:private, true) }
# }} before { get("/v3/repo/#{repo.id}/builds", {}, headers) }
# end before { repo.update_attribute(:private, false) }
# example { expect(last_response).to be_not_found }
# describe "private repository, authenticated as internal application with full access" do example { expect(parsed_body).to be == {
# let(:app_name) { 'travis-example' } "@type" => "error",
# let(:app_secret) { '12345678' } "error_type" => "not_found",
# let(:sign_opts) { "a=#{app_name}" } "error_message" => "repository not found (or insufficient access)",
# let(:signature) { OpenSSL::HMAC.hexdigest('sha256', app_secret, sign_opts) } "resource_type" => "repository"
# let(:headers) {{ 'HTTP_AUTHORIZATION' => "signature #{sign_opts}:#{signature}" }} }}
# before { Travis.config.applications = { app_name => { full_access: true, secret: app_secret }}} end
#
# describe "builds on private repository, authenticated as internal application with full access" do
# before { repo.update_attribute(:private, true) } let(:app_name) { 'travis-example' }
# before { get("/v3/repo/#{repo.id}", {}, headers) } let(:app_secret) { '12345678' }
# before { repo.update_attribute(:private, false) } let(:sign_opts) { "a=#{app_name}" }
# let(:signature) { OpenSSL::HMAC.hexdigest('sha256', app_secret, sign_opts) }
# let(:headers) {{ 'HTTP_AUTHORIZATION' => "signature #{sign_opts}:#{signature}" }}
# example { expect(last_response).to be_ok } before { Travis.config.applications = { app_name => { full_access: true, secret: app_secret }}}
# example { expect(parsed_body).to be == {
# "@type" => "repository",
# "@href" => "/v3/repo/#{repo.id}", before { repo.update_attribute(:private, true) }
# "@permissions" => { before { get("/v3/repo/#{repo.id}/builds?limit=1", {}, headers) }
# "read" => true, before { repo.update_attribute(:private, false) }
# "enable" => true,
# "disable" => true,
# "create_request" => true}, example { expect(last_response).to be_ok }
# "id" => repo.id, example { expect(parsed_body).to be == {
# "name" => "minimal", "@type" => "builds",
# "slug" => "svenfuchs/minimal", "@href" => "/v3/repo/1/builds?limit=1",
# "description" => nil, "@pagination" => {
# "github_language" => nil, "limit" => 1,
# "active" => true, "offset" => 0,
# "private" => true, "count" => 3,
# "owner" => { "is_first" => true,
# "@type" => "user", "is_last" => false,
# "@href" => "/v3/user/#{repo.owner_id}", "next" => {
# "id" => repo.owner_id, "@href" => "/v3/repo/1/builds?limit=1&offset=1",
# "login" => "svenfuchs" }, "offset" => 1,
# "last_build" => { "limit" => 1 },
# "@type" => "build", "prev" => nil,
# "@href" => "/v3/build/#{repo.last_build_id}", "first" => {
# "id" => repo.last_build_id, "@href" => "/v3/repo/1/builds?limit=1",
# "number" => "2", "offset" => 0,
# "state" => "passed", "limit" => 1 },
# "duration" => nil, "last" => {
# "started_at" => "2010-11-12T12:30:00Z", "@href" => "/v3/repo/1/builds?limit=1&offset=2",
# "finished_at" => "2010-11-12T12:30:20Z"}, "offset" => 2,
# "default_branch" => { "limit" => 1 }},
# "@type" => "branch", "builds" => [{
# "@href" => "/v3/repo/#{repo.id}/branch/master", "@type" => "build",
# "name" => "master", "@href" => "/v3/build/#{build.id}",
# "last_build" => { "id" => build.id,
# "@type" => "build", "number" => "3",
# "@href" => "/v3/build/#{repo.last_build.id}", "state" => "configured",
# "id" => repo.last_build.id, "duration" => nil,
# "number" => "3", "event_type" => "push",
# "state" => "configured", "previous_state" => "passed",
# "duration" => nil, "started_at" => "2010-11-12T13:00:00Z",
# "event_type" => "push", "finished_at" =>nil,
# "previous_state" => "passed", "repository" => {
# "started_at" => "2010-11-12T13:00:00Z", "@type" => "repository",
# "finished_at" => nil}} "@href" => "/v3/repo/1",
# }} "id" => 1,
# end "slug" => "svenfuchs/minimal"},
# "branch" => {
# describe "private repository, authenticated as internal application with full access, but scoped to a different org" do "@type" => "branch",
# let(:app_name) { 'travis-example' } "@href" => "/v3/repo/1/branch/master",
# let(:app_secret) { '12345678' } "name" => "master",
# let(:sign_opts) { "a=#{app_name}:s=travis-pro" } "last_build" => {
# let(:signature) { OpenSSL::HMAC.hexdigest('sha256', app_secret, sign_opts) } "@href" => "/v3/build/#{build.id}"}},
# let(:headers) {{ 'HTTP_AUTHORIZATION' => "signature #{sign_opts}:#{signature}" }} "commit" => {
# before { Travis.config.applications = { app_name => { full_access: true, secret: app_secret }}} "@type" => "commit",
# "id" => 5,
# before { repo.update_attribute(:private, true) } "sha" => "add057e66c3e1d59ef1f",
# before { get("/v3/repo/#{repo.id}", {}, headers) } "ref" => "refs/heads/master",
# before { repo.update_attribute(:private, false) } "message" => "unignore Gemfile.lock",
# "compare_url" => "https://github.com/svenfuchs/minimal/compare/master...develop",
# example { expect(last_response).to be_not_found } "committed_at" => "2010-11-12T12:55:00Z"}}]
# example { expect(parsed_body).to be == { }}
# "@type" => "error", end
# "error_type" => "not_found",
# "error_message" => "repository not found (or insufficient access)", describe "builds on private repository, authenticated as internal application with full access, but scoped to a different org" do
# "resource_type" => "repository" let(:app_name) { 'travis-example' }
# }} let(:app_secret) { '12345678' }
# end let(:sign_opts) { "a=#{app_name}:s=travis-pro" }
# let(:signature) { OpenSSL::HMAC.hexdigest('sha256', app_secret, sign_opts) }
# describe "private repository, authenticated as internal application with full access, scoped to the right org" do let(:headers) {{ 'HTTP_AUTHORIZATION' => "signature #{sign_opts}:#{signature}" }}
# let(:app_name) { 'travis-example' } before { Travis.config.applications = { app_name => { full_access: true, secret: app_secret }}}
# let(:app_secret) { '12345678' }
# let(:sign_opts) { "a=#{app_name}:s=#{repo.owner_name}" } before { repo.update_attribute(:private, true) }
# let(:signature) { OpenSSL::HMAC.hexdigest('sha256', app_secret, sign_opts) } before { get("/v3/repo/#{repo.id}/builds", {}, headers) }
# let(:headers) {{ 'HTTP_AUTHORIZATION' => "signature #{sign_opts}:#{signature}" }} before { repo.update_attribute(:private, false) }
# before { Travis.config.applications = { app_name => { full_access: true, secret: app_secret }}}
# example { expect(last_response).to be_not_found }
# example { expect(parsed_body).to be == {
# before { repo.update_attribute(:private, true) } "@type" => "error",
# before { get("/v3/repo/#{repo.id}", {}, headers) } "error_type" => "not_found",
# before { repo.update_attribute(:private, false) } "error_message" => "repository not found (or insufficient access)",
# "resource_type" => "repository"
# }}
# example { expect(last_response).to be_ok } end
# example { expect(parsed_body).to be == {
# "@type" => "repository", describe "builds on private repository, authenticated as internal application with full access, scoped to the right org" do
# "@href" => "/v3/repo/#{repo.id}", let(:app_name) { 'travis-example' }
# "@permissions" => { let(:app_secret) { '12345678' }
# "read" => true, let(:sign_opts) { "a=#{app_name}:s=#{repo.owner_name}" }
# "enable" => true, let(:signature) { OpenSSL::HMAC.hexdigest('sha256', app_secret, sign_opts) }
# "disable" => true, let(:headers) {{ 'HTTP_AUTHORIZATION' => "signature #{sign_opts}:#{signature}" }}
# "create_request" => true}, before { Travis.config.applications = { app_name => { full_access: true, secret: app_secret }}}
# "id" => repo.id,
# "name" => "minimal",
# "slug" => "svenfuchs/minimal", before { repo.update_attribute(:private, true) }
# "description" => nil, before { get("/v3/repo/#{repo.id}/builds?limit=1", {}, headers) }
# "github_language" => nil, before { repo.update_attribute(:private, false) }
# "active" => true,
# "private" => true,
# "owner" => { example { expect(last_response).to be_ok }
# "@type" => "user", example { expect(parsed_body).to be == {
# "@href" => "/v3/user/#{repo.owner_id}", "@type" => "builds",
# "id" => repo.owner_id, "@href" => "/v3/repo/1/builds?limit=1",
# "login" => "svenfuchs" }, "@pagination" => {
# "last_build" => { "limit" => 1,
# "@type" => "build", "offset" => 0,
# "@href" => "/v3/build/#{repo.last_build_id}", "count" => 3,
# "id" => repo.last_build_id, "is_first" => true,
# "number" => "2", "is_last" => false,
# "state" => "passed", "next" => {
# "duration" => nil, "@href" => "/v3/repo/1/builds?limit=1&offset=1",
# "started_at" => "2010-11-12T12:30:00Z", "offset" => 1,
# "finished_at" => "2010-11-12T12:30:20Z"}, "limit" => 1 },
# "default_branch" => { "prev" => nil,
# "@type" => "branch", "first" => {
# "@href" => "/v3/repo/#{repo.id}/branch/master", "@href" => "/v3/repo/1/builds?limit=1",
# "name" => "master", "offset" => 0,
# "last_build" => { "limit" => 1 },
# "@type" => "build", "last" => {
# "@href" => "/v3/build/#{repo.last_build.id}", "@href" => "/v3/repo/1/builds?limit=1&offset=2",
# "id" => repo.last_build.id, "offset" => 2,
# "number" => "3", "limit" => 1 }},
# "state" => "configured", "builds" => [{
# "duration" => nil, "@type" => "build",
# "event_type" => "push", "@href" => "/v3/build/#{build.id}",
# "previous_state" => "passed", "id" => build.id,
# "started_at" => "2010-11-12T13:00:00Z", "number" => "3",
# "finished_at" => nil}} "state" => "configured",
# }} "duration" => nil,
# end "event_type" => "push",
# "previous_state" => "passed",
# describe "including full owner" do "started_at" => "2010-11-12T13:00:00Z",
# before { get("/v3/repo/#{repo.id}?include=repository.owner") } "finished_at" =>nil,
# example { expect(last_response).to be_ok } "repository" => {
# example { expect(parsed_body['owner']).to include("github_id", "is_syncing", "synced_at", "@type" => "repository",
# "@type" => "user", "@href" => "/v3/repo/1",
# "id" => repo.owner_id, "id" => 1,
# "login" => "svenfuchs", "slug" => "svenfuchs/minimal"},
# )} "branch" => {
# end "@type" => "branch",
# "@href" => "/v3/repo/1/branch/master",
# describe "including full owner and full last build" do "name" => "master",
# before { get("/v3/repo/#{repo.id}?include=repository.owner,repository.last_build") } "last_build" => {
# example { expect(last_response).to be_ok } "@href" => "/v3/build/#{build.id}"}},
# example { expect(parsed_body['last_build']['state']).to be == 'passed' } "commit" => {
# example { expect(parsed_body['last_build']['repository']).to be == { "@href" => "/v3/repo/#{repo.id}" } } "@type" => "commit",
# example { expect(parsed_body['owner']).to include("github_id", "is_syncing", "synced_at")} "id" => 5,
# end "sha" => "add057e66c3e1d59ef1f",
# "ref" => "refs/heads/master",
# describe "including non-existing field" do "message" => "unignore Gemfile.lock",
# before { get("/v3/repo/#{repo.id}?include=repository.owner,repository.last_build_number") } "compare_url" => "https://github.com/svenfuchs/minimal/compare/master...develop",
# example { expect(last_response.status).to be == 400 } "committed_at" => "2010-11-12T12:55:00Z"}}]
# example { expect(parsed_body).to be == { }}
# "@type" => "error", end
# "error_type" => "wrong_params",
# "error_message" => "no field \"repository.last_build_number\" to include" describe "including non-existing field" do
# }} before { get("/v3/repo/#{repo.id}/builds?include=repository.owner,repository.last_build_number") }
# end example { expect(last_response.status).to be == 400 }
# example { expect(parsed_body).to be == {
# describe "wrong include format" do "@type" => "error",
# before { get("/v3/repo/#{repo.id}?include=repository.last_build.branch") } "error_type" => "wrong_params",
# example { expect(last_response.status).to be == 400 } "error_message" => "no field \"repository.last_build_number\" to include"
# example { expect(parsed_body).to be == { }}
# "@type" => "error", end
# "error_type" => "wrong_params",
# "error_message" => "illegal format for include parameter" describe "wrong include format" do
# }} before { get("/v3/repo/#{repo.id}/builds?include=repository.last_build.branch") }
# end example { expect(last_response.status).to be == 400 }
# example { expect(parsed_body).to be == {
# describe "including nested objects" do "@type" => "error",
# before { get("/v3/repo/#{repo.id}?include=repository.last_build,build.branch") } "error_type" => "wrong_params",
# example { expect(last_response).to be_ok } "error_message" => "illegal format for include parameter"
# example { expect(parsed_body).to include("last_build") } }}
# end end
end end