suzanne.soy/travis-web
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Fix logs displaying when a restart happens

Browse Source 
When a user restarts a job, we should not try fetching the log again. In
order to do this I added a guard in job-log component, which checks if
attributes changed in didReceiveAttrs callback. If the old job value is
the same as the new value, we don't need to do anything.
This commit is contained in:
Piotr Sarnacki 2016-02-11 13:42:31 +01:00
parent 238969bc51
commit 20e8a47576
1 changed files with 10 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

15
app/components/job-log.js
View File

@ -6,12 +6,17 @@ export default Ember.Component.extend({
didReceiveAttrs: function(options) {
this._super(...arguments);
if(options.oldAttrs && options.oldAttrs.job && options.oldAttrs.job.value) {
this.teardownLog(options.oldAttrs.job.value);
}
let oldJob = options.oldAttrs && options.oldAttrs.job && options.oldAttrs.job.value,
newJob = options.newAttrs && options.newAttrs.job && options.newAttrs.job.value;
if(options.newAttrs && options.newAttrs.job && options.newAttrs.job.value) {
this.setupLog(options.newAttrs.job.value);
if(newJob !== oldJob) {
if(newJob) {
this.setupLog(newJob);
}
if(oldJob) {
this.teardownLog(oldJob);
}
}
},