suzanne.soy/travis-web
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Use el.innerHTML = ''; instead of $(el).empty()

Browse Source 
innerHTML is faster than empty(), especially on some versions of
firefox. This change was already commited before, but it was somehow
lost while converting project to JS.
This commit is contained in:
Piotr Sarnacki 2016-01-29 14:14:01 +01:00
parent b1aead7577
commit 24465e634f
1 changed files with 10 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

18
app/components/log-content.js
View File

@ -80,7 +80,7 @@ export default Ember.Component.extend({
},
teardownLog(log) {
var logElement, parts, ref;
var parts, ref;
if (log || (log = this.get('log'))) {
parts = log.get('parts');
parts.removeArrayObserver(this, {
@ -92,18 +92,20 @@ export default Ember.Component.extend({
if ((ref = this.lineSelector) != null) {
ref.willDestroy();
}
if (logElement = this.$('#log')) {
return logElement.empty();
}
this.clearLogElement();
}
},
clearLogElement() {
var logElement = this.$('#log');
if (logElement && logElement[0]) {
logElement[0].innerHTML = '';
}
},
createEngine(log) {
var logElement;
if (log || (log = this.get('log'))) {
if (logElement = this.$('#log')) {
logElement.empty();
}
this.clearLogElement();
log.onClear(() => {
this.teardownLog();
return this.createEngine();