suzanne.soy/travis-web
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

add empty href otherwise iOS does not fire a tap event correctly

Browse Source
This commit is contained in:
Lisa P 2016-01-25 15:25:33 +01:00
parent 069f7ddbeb
commit 2882c8ca96
2 changed files with 4 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
app/components/log-content.js
View File

@ -60,6 +60,7 @@ Object.defineProperty(Log.Limit.prototype, 'limited', {
export default Ember.Component.extend({
popup: Ember.inject.service(),
classNameBindings: ['logIsVisible:is-open'],
logIsVisible: false,
currentUserBinding: 'auth.currentUser',
@ -226,7 +227,5 @@ export default Ember.Component.extend({
toggleLog() {
this.toggleProperty('logIsVisible');
}
},
noop() {}
}
});

4
app/templates/components/log-content.hbs
View File

@ -27,13 +27,13 @@
{{#if job.notStarted}}
<div class="log-notice">Hang tight, the log cannot be shown until the build has started.</div>
{{else}}
<a class="toggle-log-button {{if logIsVisible 'hidden'}}" title="Display the log" {{action "toggleLog"}}>
<a href="#" class="toggle-log-button {{if logIsVisible 'hidden'}}" title="Display the log" {{action "toggleLog"}}>
{{eye-icon}}
<span class="label-align">View log</span></a>
<div class="log-main {{if logIsVisible 'is-visible'}} {{if job.notStarted 'hidden'}}">
<div class="log-header">
<a class="toggle-log-button--dark {{unless logIsVisible 'hidden'}}" title="Display the log" {{action "toggleLog"}}>{{eye-icon}}Hide log</a>
<a href="#" class="toggle-log-button--dark {{unless logIsVisible 'hidden'}}" title="Display the log" {{action "toggleLog"}}>{{eye-icon}}Hide log</a>
{{#if canRemoveLog}}
<a class="remove-log-button open-popup" {{action "removeLogPopup"}} title="Remove the log">
<span class="icon-remove-log" aria-hidden="true"></span>Remove log</a>