suzanne.soy/travis-web
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Fix some of the issues with duration sometimes not showing up

Browse Source 
* duration was not actually defined in Travis.Job, which may have caused
  bugs when combined with partial record loading (so for example it was
  ok on a refresh, but may have been broken on update)
* notStarted was not a dependency of duration
This commit is contained in:
Piotr Sarnacki 2014-08-14 22:10:11 +02:00
parent 615edb5686
commit 2ccade46a4
2 changed files with 2 additions and 1 deletions
assets/scripts/app/models
extensions.coffeejob.coffee

2
assets/scripts/app/models/extensions.coffee
View File

@ -6,7 +6,7 @@ Travis.DurationCalculations = Ember.Mixin.create
duration duration
else else
Travis.Helpers.durationFrom(@get('startedAt'), @get('finishedAt')) Travis.Helpers.durationFrom(@get('startedAt'), @get('finishedAt'))
).property('_duration', 'finishedAt', 'startedAt') ).property('_duration', 'finishedAt', 'startedAt', 'notStarted')
updateTimes: -> updateTimes: ->
unless @get('isFinished') unless @get('isFinished')

1
assets/scripts/app/models/job.coffee
View File

@ -21,6 +21,7 @@ require 'travis/model'
annotations: Ember.hasMany('Travis.Annotation') annotations: Ember.hasMany('Travis.Annotation')
_config: Ember.attr('object', key: 'config') _config: Ember.attr('object', key: 'config')
_duration: Ember.attr(Number, key: 'duration')
log: ( -> log: ( ->
@set('isLogAccessed', true) @set('isLogAccessed', true)