suzanne.soy/travis-web
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

[deprecations] Don't use second argument in a property

Browse Source 
This makes Ember.js think that we're trying to use the property as
setter and it's deprecated
This commit is contained in:
Piotr Sarnacki 2016-01-07 11:16:13 +01:00
parent e7ca2c8bfe
commit 4b71704b1c
2 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
app/components/env-var.js
View File

@ -8,7 +8,7 @@ export default Ember.Component.extend({
actionType: 'Save',
showValueField: Ember.computed.alias('public'),
value: function(key, value) {
value: function(key) {
if (this.get('envVar.public')) {
return this.get('envVar.value');
} else {

2
config/deprecation-workflow.js
View File

@ -13,6 +13,7 @@ window.deprecationWorkflow.config = {
{ handler: "log", matchMessage: "RestAdapter#find has been deprecated and renamed to `findRecord`." },
{ handler: "log", matchMessage: "Usage of `typeKey` has been deprecated and will be removed in Ember Data 2.0. It has been replaced by `modelName` on the model class." },
{ handler: "log", matchMessage: "Using store.dematerializeRecord() has been deprecated since it was intended for private use only. You should use store.unloadRecord() instead." },
{ handler: "log", matchMessage: "Using the same function as getter and setter is deprecated." },
// TODO
{ handler: "silence", matchMessage: "Ember.View is deprecated. Consult the Deprecations Guide for a migration strategy." },
@ -22,7 +23,6 @@ window.deprecationWorkflow.config = {
{ handler: "silence", matchMessage: "`Ember.ArrayController` is deprecated." },
{ handler: "silence", matchMessage: "Ember.removeBeforeObserver is deprecated and will be removed in the near future." },
{ handler: "silence", matchMessage: "The default behavior of `shouldBackgroundReloadRecord` will change in Ember Data 2.0 to always return true. If you would like to preserve the current behavior please override `shouldBackgroundReloadRecord` in your adapter:application and return false." },
{ handler: "silence", matchMessage: "Using the same function as getter and setter is deprecated." },
{ handler: "silence", matchMessage: "Using DS.Snapshot.get() is deprecated. Use .attr(), .belongsTo() or .hasMany() instead." },
]
};