suzanne.soy/travis-web
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Keep elements fully within a single element.

Browse Source 
{{if}} is implemented as an Ember.View (without an element), and
children must be valid DOM.
This commit is contained in:
Robert Jackson 2014-11-05 12:48:26 -05:00
parent 2faca2e9d6
commit 89a3c20217
No known key found for this signature in database
GPG Key ID: B3D10EF8171F7219
2 changed files with 15 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

17
assets/scripts/app/templates/jobs/list.hbs
View File

@ -1,15 +1,14 @@
{{#if view.jobs.length}} {{#if view.jobs.length}}
<table {{bind-attr id=view.jobTableId}} class="list">
{{#if view.required}} {{#if view.required}}
<table id="jobs" class="list"> <caption>
<caption> Build Matrix
Build Matrix </caption>
</caption>
{{else}} {{else}}
<table id="allowed_failure_jobs" class="list"> <caption>
<caption> Allowed Failures
Allowed Failures <a title="What's this?" class="help open-popup" name="help-allowed_failures" {{action "popup" target="view"}}></a>
<a title="What's this?" class="help open-popup" name="help-allowed_failures" {{action "popup" target="view"}}></a> </caption>
</caption>
{{/if}} {{/if}}
<thead> <thead>
<tr> <tr>

7
assets/scripts/app/views/job.coffee
View File

@ -3,6 +3,13 @@ Travis.reopen
templateName: 'jobs/list' templateName: 'jobs/list'
buildBinding: 'controller.build' buildBinding: 'controller.build'
jobTableId: Ember.computed(->
if @get('required')
'jobs'
else
'allowed_failure_jobs'
)
JobsItemView: Travis.View.extend JobsItemView: Travis.View.extend
tagName: 'tr' tagName: 'tr'
classNameBindings: ['color'] classNameBindings: ['color']