suzanne.soy/travis-web
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Fix viewing repo after viewing all repos on safari

Browse Source 
When transitioning from recent route to a specific repo deactivate is
not called for some reason on Safari. It seems like a bug in Ember.js,
but I need to investigate more.

A solution is to also try to remove observer in reset controller
This commit is contained in:
Piotr Sarnacki 2015-02-18 16:32:43 +01:00
parent a446344096
commit bf7c4e1464
1 changed files with 3 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
app/routes/main-tab.coffee
View File

@ -17,6 +17,9 @@ Route = TravisRoute.extend
deactivate: -> deactivate: ->
@controllerFor('repos').removeObserver('firstObject', this, 'currentRepoDidChange') @controllerFor('repos').removeObserver('firstObject', this, 'currentRepoDidChange')
resetController: ->
@controllerFor('repos').removeObserver('firstObject', this, 'currentRepoDidChange')
currentRepoDidChange: -> currentRepoDidChange: ->
if repo = @controllerFor('repos').get('firstObject') if repo = @controllerFor('repos').get('firstObject')
@controllerFor('repo').set('repo', repo) @controllerFor('repo').set('repo', repo)