suzanne.soy/travis-web
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Mark invalid concurrent setting input properly.

Browse Source 
This adds a CSS class if the content is invalid.
This commit is contained in:
Mathias Meyer 2014-06-17 17:32:33 +02:00
parent ce9322443c
commit d3b13d8238
3 changed files with 9 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
assets/scripts/app/controllers.coffee
View File

@ -58,10 +58,11 @@ Travis.RepoSettingsController = Em.ObjectController.extend
settingsChanged: (-> settingsChanged: (->
if parseInt(@get('settings.maximum_number_of_builds')) > 0 if parseInt(@get('settings.maximum_number_of_builds')) > 0
@set('settings.maximum_number_of_builds_valid', '')
@get('model').saveSettings(@get('settings')).then null, -> @get('model').saveSettings(@get('settings')).then null, ->
Travis.flash(error: 'There was an error while saving settings. Please try again.') Travis.flash(error: 'There was an error while saving settings. Please try again.')
else else
Travis.flash(error: 'The maximum number of concurrent builds needs to be a number greater than zero.') @set('settings.maximum_number_of_builds_valid', 'invalid')
).observes('settings.maximum_number_of_builds') ).observes('settings.maximum_number_of_builds')
save: -> save: ->

2
assets/scripts/app/templates/repo/settings.hbs
View File

@ -34,7 +34,7 @@
</div> </div>
<div class="settings-row"> <div class="settings-row">
<div class="short-settings-element"> <div class="short-settings-element" {{bind-attr class="settings.maximum_number_of_builds_valid"}}>
{{input value=settings.maximum_number_of_builds size="4" pattern='/^[0-9]+$/'}} {{input value=settings.maximum_number_of_builds size="4" pattern='/^[0-9]+$/'}}
</div> </div>
<label> <label>

6
assets/styles/settings.sass
View File

@ -21,4 +21,10 @@
margin: 0px 15px margin: 0px 15px
display: inline-block display: inline-block
.invalid
input
border-width: 1px
border-color: red
background: #ffb6c1