suzanne.soy/travis-web
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Remove view.state checks (in favor of _state).

Browse Source
This commit is contained in:
Robert Jackson 2014-11-05 12:50:40 -05:00
parent 89a3c20217
commit e66ccfdfcd
No known key found for this signature in database
GPG Key ID: B3D10EF8171F7219
2 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
assets/scripts/app/views/log.coffee
View File

@ -37,12 +37,12 @@ Travis.reopen
@lineSelector?.willDestroy() @lineSelector?.willDestroy()
versionDidChange: (-> versionDidChange: (->
@rerender() if @get('state') == 'inDOM' @rerender() if @get('_state') == 'inDOM'
).observes('log.version') ).observes('log.version')
logDidChange: (-> logDidChange: (->
console.log 'log view: log did change: rerender' if Log.DEBUG console.log 'log view: log did change: rerender' if Log.DEBUG
@rerender() if @get('state') == 'inDOM' @rerender() if @get('_state') == 'inDOM'
).observes('log') ).observes('log')
createEngine: -> createEngine: ->

4
assets/scripts/app/views/repo/show.coffee
View File

@ -17,9 +17,9 @@ Travis.reopen
# TODO: look into fixing it in more general way # TODO: look into fixing it in more general way
Ember.run.schedule('afterRender', this, -> Ember.run.schedule('afterRender', this, ->
pane = Ember.get('_outlets.pane') pane = Ember.get('_outlets.pane')
if @get('controller.repo.isLoaded') && @state == 'inDOM' && if @get('controller.repo.isLoaded') && @_state == 'inDOM' &&
@get('controller.repo.lastBuild') && @get('controller.repo.lastBuild') &&
@get('controller.tab') == 'current' && (!pane || pane.state == 'destroyed') @get('controller.tab') == 'current' && (!pane || pane._state == 'destroyed')
view = @get('controller.container').lookup('view:build') view = @get('controller.container').lookup('view:build')
view.set('controller', @get('controller.container').lookup('controller:build')) view.set('controller', @get('controller.container').lookup('controller:build'))
Ember.run.next => Ember.run.next =>