suzanne.soy/travis-web
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Don't destroy parts on cleanup

Browse Source 
Destroying parts on cleanup can have weird effects, because we observe parts in
log view.
This commit is contained in:
Piotr Sarnacki 2014-12-30 11:58:56 +01:00
parent eb9eac2b09
commit fbcfa04859
2 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
assets/scripts/app/models/log.coffee
View File

@ -33,8 +33,7 @@ require 'travis/log_chunks'
clearParts: -> clearParts: ->
parts = @get('parts') parts = @get('parts')
@notifyPropertyChange('parts') parts.set('content', [])
parts.destroy()
fetch: -> fetch: ->
console.log 'log model: fetching log' if Log.DEBUG console.log 'log model: fetching log' if Log.DEBUG

1
assets/scripts/app/views/log.coffee
View File

@ -68,6 +68,7 @@ Travis.reopen
parts = log.get('parts') parts = log.get('parts')
parts.removeArrayObserver(@, didChange: 'partsDidChange', willChange: 'noop') parts.removeArrayObserver(@, didChange: 'partsDidChange', willChange: 'noop')
parts.destroy() parts.destroy()
log.notifyPropertyChange('parts')
@lineSelector?.willDestroy() @lineSelector?.willDestroy()
createEngine: -> createEngine: ->