Commit Graph

7 Commits

Author SHA1 Message Date
Curtis Ekstrom
142a7217d4
Remove *Binding(s) from project
These bindings can be replaced wholesale with the more idiomatic
alternative: aliases.

In addition, avoid passing in user to components where it can be injected directly.

One of the perceived downsides of dependency injection can be
that it can make debugging feel more difficult because it's not
immediately clear where the value is coming from, which the explicit
variant we previously used does not suffer from. It might also be
argued that we also lose out on a seam that could be useful in the
future where a component doesn't care about the specific type of
user, just that one is passed in.

While explicitness is often a virtue, it comes at the cost of increased
noise that pervades multiple layers of components. I'd argue this makes
the parent components more difficult to understand, given they are
littered with unnecessary references to data they themselves do not
need.

This decreases the noise/ceremony around accessing
userPermissions/auth data and restricts access to that data to
the child components that actually need to know about it.

As to losing a seam, it appears 1) that this isn't
currently necessary and 2) we can use an internal computed
property should the need arise in the future.
2016-04-13 13:54:51 +02:00
Lisa P
de26ed2091 fix error handling for log 2016-03-07 13:27:48 +01:00
Piotr Sarnacki
20e8a47576 Fix logs displaying when a restart happens
When a user restarts a job, we should not try fetching the log again. In
order to do this I added a guard in job-log component, which checks if
attributes changed in didReceiveAttrs callback. If the old job value is
the same as the new value, we don't need to do anything.
2016-02-11 13:43:59 +01:00
Piotr Sarnacki
4bbf114e82 Check also for value in attrs for job-log 2016-01-15 15:15:59 +01:00
Piotr Sarnacki
13d2eba016 [deprecations] Remove the need to use beforeObserver in job-log component 2016-01-12 18:27:24 +01:00
Piotr Sarnacki
03332a8654 [deprecations] Don't run Ember.set directly in didInsertElement 2016-01-07 10:40:14 +01:00
Piotr Sarnacki
fafaf65043 Convert project to JavaScript 2016-01-04 13:15:14 +01:00