suzanne.soy/travis-web
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
bind_voyage
travis-web/app/components
History
Curtis Ekstrom 142a7217d4
Remove *Binding(s) from project 
These bindings can be replaced wholesale with the more idiomatic
alternative: aliases.

In addition, avoid passing in user to components where it can be injected directly.

One of the perceived downsides of dependency injection can be
that it can make debugging feel more difficult because it's not
immediately clear where the value is coming from, which the explicit
variant we previously used does not suffer from. It might also be
argued that we also lose out on a seam that could be useful in the
future where a component doesn't care about the specific type of
user, just that one is passed in.

While explicitness is often a virtue, it comes at the cost of increased
noise that pervades multiple layers of components. I'd argue this makes
the parent components more difficult to understand, given they are
littered with unnecessary references to data they themselves do not
need.

This decreases the noise/ceremony around accessing
userPermissions/auth data and restricts access to that data to
the child components that actually need to know about it.

As to losing a seam, it appears 1) that this isn't
currently necessary and 2) we can use an internal computed
property should the need arise in the future.
2016-04-13 13:54:51 +02:00
..
.gitkeep Add ember-cli version of the Ember.js app 2015-02-03 09:48:22 +01:00
add-env-var.js Convert project to JavaScript 2016-01-04 13:15:14 +01:00
add-ssh-key.js Add missing semicolon 2016-01-14 11:28:25 +01:00
branch-row.js Convert project to JavaScript 2016-01-04 13:15:14 +01:00
broadcast-tower.js Convert project to JavaScript 2016-01-04 13:15:14 +01:00
build-header.js Fix mixin typo 2016-02-25 14:51:31 +01:00
build-repo-actions.js Convert project to JavaScript 2016-01-04 13:15:14 +01:00
build-tile.js show build number on hover in branch tiles 2016-01-12 13:10:15 +01:00
build-wrapper.js [deprecations] Remove all of the views from the app 2016-01-12 16:55:22 +01:00
builds-item.js Convert project to JavaScript 2016-01-04 13:15:14 +01:00
builds-wrapper.js [deprecations] Remove all of the views from the app 2016-01-12 16:55:22 +01:00
caches-item.js Convert project to JavaScript 2016-01-04 13:15:14 +01:00
dashboard-row.js make it a util 2016-03-22 12:41:28 +01:00
env-var.js [deprecations] Don't use second argument in a property 2016-01-07 11:18:05 +01:00
eye-icon.js Convert project to JavaScript 2016-01-04 13:15:14 +01:00
flash-display.js Remove *Binding(s) from project 2016-04-13 13:54:51 +02:00
flash-item.js Convert project to JavaScript 2016-01-04 13:15:14 +01:00
hook-switch.js Remove *Binding(s) from project 2016-04-13 13:54:51 +02:00
hooks-list-item.js Convert project to JavaScript 2016-01-04 13:15:14 +01:00
job-log.js Remove *Binding(s) from project 2016-04-13 13:54:51 +02:00
job-repo-actions.js Convert project to JavaScript 2016-01-04 13:15:14 +01:00
job-wrapper.js Remove *Binding(s) from project 2016-04-13 13:54:51 +02:00
jobs-item.js Fix jshint errors after conversion to JS 2016-01-04 13:15:15 +01:00
jobs-list.js Convert project to JavaScript 2016-01-04 13:15:14 +01:00
lastbuild-tile.js dashboard row styles 2016-03-09 11:05:51 +01:00
limit-concurrent-builds.js Convert project to JavaScript 2016-01-04 13:15:14 +01:00
loading-indicator.js Convert project to JavaScript 2016-01-04 13:15:14 +01:00
log-content.js Remove *Binding(s) from project 2016-04-13 13:54:51 +02:00
no-builds.js Convert project to JavaScript 2016-01-04 13:15:14 +01:00
no-repos.js Convert project to JavaScript 2016-01-04 13:15:14 +01:00
not-active.js Remove *Binding(s) from project 2016-04-13 13:54:51 +02:00
org-item.js Remove *Binding(s) from project 2016-04-13 13:54:51 +02:00
orgs-filter.js start fresh markup for prgs filter 2016-02-19 18:40:18 +01:00
owner-repo-tile.js Convert project to JavaScript 2016-01-04 13:15:14 +01:00
owner-sync-button.js Convert project to JavaScript 2016-01-04 13:15:14 +01:00
popup-click-handler.js [deprecations] Remove all of the views from the app 2016-01-12 16:55:22 +01:00
profile-accounts-wrapper.js [deprecations] Remove all of the views from the app 2016-01-12 16:55:22 +01:00
queued-jobs.js Update time also for finished builds, but only every minute 2016-01-25 17:55:48 +01:00
remove-log-popup.js Convert project to JavaScript 2016-01-04 13:15:14 +01:00
repo-actions.js fix tests, refactor repo-actions component 2016-02-01 13:09:16 +01:00
repo-show-tabs.js Convert project to JavaScript 2016-01-04 13:15:14 +01:00
repo-show-tools.js Remove *Binding(s) from project 2016-04-13 13:54:51 +02:00
repo-wrapper.js [deprecations] Remove all of the views from the app 2016-01-12 16:55:22 +01:00
repos-empty.js Convert project to JavaScript 2016-01-04 13:15:14 +01:00
repos-list-item.js Remove click handler overriding default link behavior 2016-02-15 23:40:09 +01:00
repos-list-tabs.js Remove *Binding(s) from project 2016-04-13 13:54:51 +02:00
repos-list.js Sort repos in repos controller, not in the component 2015-12-08 10:18:08 +01:00
request-icon.js dashboard row styles 2016-03-09 11:05:51 +01:00
requests-item.js make isGHPages a proper property 2016-01-05 15:01:38 +01:00
running-jobs-item.js Convert project to JavaScript 2016-01-04 13:15:14 +01:00
running-jobs.js Update time also for finished builds, but only every minute 2016-01-25 17:55:48 +01:00
settings-switch.js Convert project to JavaScript 2016-01-04 13:15:14 +01:00
show-more-button.js Remove *Binding(s) from project 2016-04-13 13:54:51 +02:00
ssh-key.js Convert project to JavaScript 2016-01-04 13:15:14 +01:00
status-icon.js remove coffee file 2016-01-05 13:25:48 +01:00
status-image-input.js [deprecations] Remove all of the views from the app 2016-01-12 16:55:22 +01:00
status-images.js Remove *Binding(s) from project 2016-04-13 13:54:51 +02:00
subscribe-button.js Convert project to JavaScript 2016-01-04 13:15:14 +01:00
sync-button.js Remove *Binding(s) from project 2016-04-13 13:54:51 +02:00
team-member.js Convert project to JavaScript 2016-01-04 13:15:14 +01:00
travis-layout.js [deprecations] Remove all of the views we use just for layouts 2016-01-12 16:55:22 +01:00
travis-status.js Convert project to JavaScript 2016-01-04 13:15:14 +01:00
travis-switch.js Convert project to JavaScript 2016-01-04 13:15:14 +01:00
user-avatar.js fix user avatar/ status icon spacing 2016-03-14 13:09:32 +01:00