check tvars are ids before using free-identifier=? #12

2019-04-03T21:10:57+01:00

AlexKnauth commented

2019-04-03 21:10:57 +01:00

(Migrated from github.com)

This PR fixes an internal error like this:

(define-type (A 5) String)
;free-identifier=?: contract violation expected: identifier? given: #<syntax 5>`

And changes the error message to this, highlighting the 5 in the user program as wrong:

(define-type (A 5) String)
;define-type: expected identifier in: 5

This PR fixes an internal error like this: ```racket (define-type (A 5) String) ;free-identifier=?: contract violation expected: identifier? given: #<syntax 5>` ``` And changes the error message to this, highlighting the `5` in the user program as wrong: ```racket (define-type (A 5) String) ;define-type: expected identifier in: 5 ```

coveralls commented

2019-04-03 21:27:18 +01:00

(Migrated from github.com)

Coverage increased (+0.8%) to 96.6% when pulling 6482fb0049 on AlexKnauth:patch-1 into 215036e059 on jsmaniac:master.

[![Coverage Status](https://coveralls.io/builds/22585136/badge)](https://coveralls.io/builds/22585136) Coverage increased (+0.8%) to 96.6% when pulling **6482fb004948cf1dec17443df2dd83e112e33364 on AlexKnauth:patch-1** into **215036e059db349d91d54468dcd2c0ef4937236c on jsmaniac:master**.

SuzanneSoy (Migrated from github.com) approved these changes 2019-04-04 17:47:03 +01:00

SuzanneSoy (Migrated from github.com) left a comment

LGTM

SuzanneSoy commented

2019-04-04 17:47:52 +01:00

(Migrated from github.com)

Thanks :)

Sign in to join this conversation.

No reviewers

SuzanneSoy