Simplify deleteCacheObjectVersions() query

This commit is contained in:
Dan Stillman 2017-05-03 03:54:54 -04:00
parent 5b0b874435
commit 2588a0a651

View File

@ -1082,10 +1082,9 @@ Zotero.Sync.Data.Local = {
* @param {Integer} [maxVersion] * @param {Integer} [maxVersion]
*/ */
deleteCacheObjectVersions: function (objectType, libraryID, key, minVersion, maxVersion) { deleteCacheObjectVersions: function (objectType, libraryID, key, minVersion, maxVersion) {
var sql = "DELETE FROM syncCache WHERE libraryID=? AND key=? " var syncObjectTypeID = Zotero.Sync.Data.Utilities.getSyncObjectTypeID(objectType);
+ "AND syncObjectTypeID IN (SELECT syncObjectTypeID FROM " var sql = "DELETE FROM syncCache WHERE libraryID=? AND key=? AND syncObjectTypeID=?";
+ "syncObjectTypes WHERE name=?)"; var params = [libraryID, key, syncObjectTypeID];
var params = [libraryID, key, objectType];
if (minVersion && minVersion == maxVersion) { if (minVersion && minVersion == maxVersion) {
sql += " AND version=?"; sql += " AND version=?";
params.push(minVersion); params.push(minVersion);