suzanne.soy/zotero
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

don't use getters, since they probably don't save much memory and they don't seem to work with Fx3.6 wrappers

Browse Source
This commit is contained in:
Simon Kornblith 2010-11-06 21:35:06 +00:00
parent e531493ba0
commit 4df28f93cb
1 changed files with 3 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
chrome/content/zotero/xpcom/translation/item_local.js
View File

@ -623,10 +623,6 @@ Zotero.Translate.ItemGetter.prototype = {
* Converts an item to array format
*/
"_itemToArray":function(returnItem) {
const makeGetter = function(returnItemArray, fieldName) {
return function() { return returnItemArray[fieldName] };
}
// TODO use Zotero.Item#serialize()
var returnItemArray = returnItem.toArray();
@ -652,10 +648,10 @@ Zotero.Translate.ItemGetter.prototype = {
}
if(baseName) {
returnItemArray.__defineGetter__(baseName, makeGetter(returnItemArray, fieldName));
returnItemArray.uniqueFields.__defineGetter__(baseName, makeGetter(returnItemArray, fieldName));
returnItemArray[baseName] = returnItemArray[fieldName];
returnItemArray.uniqueFields[baseName] = returnItemArray[fieldName];
} else {
returnItemArray.uniqueFields.__defineGetter__(fieldName, makeGetter(returnItemArray, fieldName));
returnItemArray.uniqueFields[fieldName] = returnItemArray[fieldName];
}
}
}