suzanne.soy/zotero
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Fix Item.numNotes() and Item.getNotes() to work on items not yet in the DB (return 0 and [], respectively)

Browse Source
This commit is contained in:
Dan Stillman 2006-06-16 21:33:03 +00:00
parent bf0626cb58
commit 936ef86584
1 changed files with 8 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
chrome/chromeFiles/content/scholar/xpcom/data_access.js
View File

@ -737,6 +737,10 @@ Scholar.Item.prototype.removeNote = function(noteID){
* Returns number of notes in item * Returns number of notes in item
**/ **/
Scholar.Item.prototype.numNotes = function(){ Scholar.Item.prototype.numNotes = function(){
if (!this.getID()){
return 0;
}
var sql = "SELECT COUNT(*) FROM itemNotes WHERE itemID=" + this.getID(); var sql = "SELECT COUNT(*) FROM itemNotes WHERE itemID=" + this.getID();
return parseInt(Scholar.DB.valueQuery(sql)); return parseInt(Scholar.DB.valueQuery(sql));
} }
@ -754,6 +758,10 @@ Scholar.Item.prototype.getNote = function(noteID){
* Returns an array of noteIDs for this item * Returns an array of noteIDs for this item
**/ **/
Scholar.Item.prototype.getNotes = function(){ Scholar.Item.prototype.getNotes = function(){
if (!this.getID()){
return [];
}
var sql = "SELECT noteID FROM itemNotes WHERE itemID=" + this.getID() var sql = "SELECT noteID FROM itemNotes WHERE itemID=" + this.getID()
+ " ORDER BY dateCreated"; + " ORDER BY dateCreated";
return Scholar.DB.columnQuery(sql); return Scholar.DB.columnQuery(sql);