DeepSOIC
2625233dff
PartDesign: disable migration
...
Temporary. Later, a way to manually invoke it should be made.
2016-04-12 18:12:14 +02:00
Alexander Golubev
f509e1b0f1
remove unneeded sketcher tools from part design
...
Previously similar patch was commited by Stefan Tröger <stefantroeger@gmx.net> but lost during rebase.
2016-04-12 18:12:14 +02:00
Stefan Tröger
a8bd2f6f7f
prevent part design features from accidently cross referencing
2016-04-12 18:12:14 +02:00
Stefan Tröger
318c65eafd
fix independent copy and cross reference
2016-04-12 18:12:14 +02:00
Stefan Tröger
a35c231d2a
first take on enhanced feature pick task
2016-04-12 18:12:14 +02:00
Stefan Tröger
45aca9fb55
fix loft top face location
2016-04-12 18:12:13 +02:00
Stefan Tröger
986623f462
fix loft tool naming
2016-04-12 18:12:13 +02:00
Stefan Tröger
d2f4410c1e
fix datum crash when origin is selected
2016-04-12 18:12:13 +02:00
Stefan Tröger
e876d9aa81
fix loft result orientation
2016-04-12 18:12:13 +02:00
Stefan Tröger
ef11b75c79
fix pipe tool result orientation
2016-04-12 18:12:13 +02:00
Stefan Tröger
45861b4f92
remove linear and S-shape scaling from pipe
...
They worked and are nice feature, but the handling with properties must be worked out better. To avoid any incompatibility due to property changes the functionality is removed now.
2016-04-12 18:12:13 +02:00
Stefan Tröger
d980952d31
fix body and part tool texts
2016-04-12 18:12:13 +02:00
Stefan Tröger
7d759a5793
delete features when deleting body
2016-04-12 18:12:13 +02:00
Stefan Tröger
ecfe545b3b
add part tool to task dialog for no selection
2016-04-12 18:12:13 +02:00
Stefan Tröger
0606e767cd
fix pipe task dialog icon
2016-04-12 18:12:13 +02:00
Stefan Tröger
939286ca3e
add shaft wizard only when building fem
2016-04-12 18:12:13 +02:00
Stefan Tröger
12c5e1f92f
remove hole feature
...
A hole feature is something needed, however, the current implementation does not use the attacher code which would made it intuitive and compatibel to other workbench tools. A reimplementation is needed.
2016-04-12 18:12:13 +02:00
DeepSOIC
72c70bcc50
Datum UI: fixes
...
* fix messagebox not popping when clicking OK but status is error
* accept preselection
* unify code for all datum commands
* edit selected datum if type matches, instead of creating new one
2016-04-12 18:12:13 +02:00
DeepSOIC
a48f9a682c
Sketcher: use Selection's getAsPropertyLinkSubList
2016-04-12 18:12:13 +02:00
DeepSOIC
03e354f7ac
PartDesign: fix porting procedure...
...
...that caused an assert in attacher that back/front subshape strings
were used for attachment to App::Plane.
2016-04-12 18:12:13 +02:00
DeepSOIC
4e57b1a2ec
Datum UI: fixes
...
* fix highlighting of reference buttons when active
* fix selection of whole objects
* fix some other logic
2016-04-12 18:12:13 +02:00
Stefan Tröger
de0768af80
fix crash on datum point preselect
...
It is unclear why the coordinates are NULL. This fix prevents the crash but does not fix the reason why this unnormality occurs.
2016-04-12 18:12:13 +02:00
Stefan Tröger
7deb6393cc
no temporaries at by reference parameter
2016-04-12 18:12:12 +02:00
Stefan Tröger
4e295c03ed
fix crash in boolean op if no base feature exists
2016-04-12 18:12:12 +02:00
DeepSOIC
98717f010a
Attacher: proximity modes
...
The modes that base on distToShape:
* a line that connects the closest points,
* the actual points
2016-04-12 18:12:12 +02:00
DeepSOIC
a3d9907e8c
PartDesign: adapt Datum UI to work using Attacher
...
* adapt
* introduce mode selection
* kill selection gate to allow selecting whole objects (selection gate
should be reintroduced to disallow references between parts, no
restrictions is a temporary state)
* prevent auto-switchover to next ref after an explicit push of a button
* fix highlighting of buttons when selecting corresponding reference
* allow creation of a feature, even if no mode fits references. With a
warning.
2016-04-12 18:12:12 +02:00
DeepSOIC
a5d38c9a99
PartDesign: patch old partdesign porting for changes in Datums
2016-04-12 18:12:12 +02:00
DeepSOIC
9e440b955c
PartDesign: transfer Datums to become AttachableObjects
...
Crude and quick, needs cleanup.
2016-04-12 18:12:12 +02:00
DeepSOIC
40592e6055
Attacher: line and point AttachEngines. Other changes.
...
* propose attachment modes
* refactor setUp and Copy
* split off postprocessing from 3D to reuse in 1D and 0D calculations
* AttachableObject: fix error printout in onChange
* AttachableObject: no more defaults to Attacher3D
* implementation of lines and points attachment (some of the proposed modes).
* refactor getShapeType, add getShapeType(obj, sub); add a flag to eRefType enum, indicating that referenced thing is a whole object that has placement.
* change readLinks to be static, and obtain shape types in the process.
* test mode enums lengths equality
* extend ObjectXY to work on conics.
* Fix upside-down sketches attached as TangentPlane on most shapes.
* Fix crash when a shape of unlisted type is in the links.
* fix attaching to datum lines go crazy because of infinities.
* abs->fabs
* support for App::Line
* Add namespace qualifiers to TYPESYSTEM_SOURCE-like stuff
2016-04-12 18:12:12 +02:00
DeepSOIC
4800957858
Attacher: change Part2DObject's MapMode default to mmDeactivated, and set mode to mmFlatFace only when reading files of old format.
...
PartDesign, Sketcher: set mapping mode when setting support
Mapping mode mmFlatFace is no longer default, so an explicit assignment
is required.
2016-04-12 18:12:12 +02:00
DeepSOIC
fa441a9623
PropertyLinkSubList, Sketcher: move legacy Support readout from PropertyContainer to Part2DObject
2016-04-12 18:12:12 +02:00
DeepSOIC
ad01411efc
Attacher: fix crash of suggestor on compounds
2016-04-12 18:12:12 +02:00
DeepSOIC
34784b2d29
PartDesign: Fix revolution
...
It failed to close task if starting a body.
2016-04-12 18:12:12 +02:00
DeepSOIC
f688546106
InvoluteGear: positionBySupport
2016-04-12 18:12:12 +02:00
DeepSOIC
acac286cd0
Sketch: expose positionBySupport python func
2016-04-12 18:12:12 +02:00
DeepSOIC
4cc9b32e32
PartDesign: accomodating to sketch's multisupport
...
* FeatureSketchBased getSupportFace check for mapping mode
* Fixes failure to place sketches on DatumPlanes
2016-04-12 18:12:12 +02:00
DeepSOIC
2a390660c8
Sketcher: minimalistic UI for new attachment engine
2016-04-12 18:12:12 +02:00
DeepSOIC
42ecc24ec5
Sketcher: new attachment engine
2016-04-12 18:12:12 +02:00
DeepSOIC
061747f367
Sketcher: change Support from PropertyLinkSub to PropertyLinkSubList
...
Note: may fail to build after this commit...
2016-04-12 18:12:12 +02:00
DeepSOIC
eccff10d90
PartDesign: fix refuse to pad
...
When something was depending on a sketch (another sketch, for example),
padding (revolving, pocketing, etc) it was impossible. This is fixed.
Also, padding or revolving a single sketch twice was allowed (with a
warning msg displayed).
2016-04-12 18:12:11 +02:00
Alexander Golubev
445c26f658
PartDesign/Body: make insert/removeFeature treat NULL in a less special way
2016-04-12 18:12:11 +02:00
Alexander Golubev
bf58a7be2a
PartDesign: make MoveFeatureInTree command use new insert functions
2016-04-12 18:12:11 +02:00
Alexander Golubev
9c113357c5
PartDesign: add migrating sketch support to MoveFeature command
2016-04-12 18:12:11 +02:00
Alexander Golubev
03d3f45277
PartDesign/Workbench: make a message more translation-frendly
2016-04-12 18:12:11 +02:00
Alexander Golubev
ad461fc472
PartDesign: fix spacing in several files
2016-04-12 18:12:11 +02:00
Alexander Golubev
7e1a76eb37
PartDesign/Workbench: move fix of sketch support into separate function
...
Outside PartDesign sketches can have no support plane for them. But
PartDesign doesn't allow that.
Move the code for migration of "free" sketches of planes
into a separate fuction so it may be reused.
2016-04-12 18:12:11 +02:00
Alexander Golubev
7c2413b0aa
PartDesign/Body: add methodes to insert features into specific place
...
Add a Body::insertFeature() methodes as well as python API for it.
2016-04-12 18:12:11 +02:00
DeepSOIC
ec2bbc4c34
Loft: fix build with MSVC2013
2016-04-12 18:12:11 +02:00
DeepSOIC
4b48362ec6
PartDesign: refactor positionBySketch
...
Rename it to positionByPrevious. Rewrite.
Rewrite SketchBased::transformPlacement.
2016-04-12 18:12:11 +02:00
DeepSOIC
03be8e1bba
PartDesign: tidy up sketch support and base feature confusion
...
Not complete, transformPlacement and positionBySketch are pending...
2016-04-12 18:12:11 +02:00
Alexander Golubev
b67c8bd34d
PartDesign/FeatureDraft: fix a wronly placed NOT
2016-04-12 18:12:11 +02:00
Alexander Golubev
b9f4e10fa5
PartDesign: fix a couple of crashes
...
The first crash was reported here:
http://forum.freecadweb.org/viewtopic.php?f=20&t=11205&start=50#p91052
The second one accures then moving a feature from a body without solid
features.
2016-04-12 18:12:11 +02:00
Stefan Tröger
08e4151ea1
make hole feature work again
2016-04-12 18:12:11 +02:00
Stefan Tröger
7f80e711f6
better active part and document tip handling
2016-04-12 18:12:10 +02:00
Stefan Tröger
d435e15a97
make part design loft functional
2016-04-12 18:12:10 +02:00
Stefan Tröger
987880fffa
add loft viewprovider
2016-04-12 18:12:10 +02:00
Stefan Tröger
c82e4117e9
add feature loft
2016-04-12 18:12:10 +02:00
Alexander Golubev
f4a5bf6acd
PartDesign: remove Body::isFeature() because it's the same as BodyBase::hasFeature()
2016-04-12 18:12:10 +02:00
DeepSOIC
36fe5994b9
Revolution: fix crash when selecting stuff during task
2016-04-12 18:12:10 +02:00
Danny Lepage
8aecb00a8d
Fix Debug Assert in CmdPartDesignDuplicateSelection::activated
...
Under Windows, "Edit/Duplicate selected object" raised a
Debug Assertion Failed "Expression: sequence not ordered".
2016-04-12 18:12:10 +02:00
Danny Lepage
63bdbe5561
Fix Boolean operation tooltip text.
...
As reported by triplus
2016-04-12 18:12:10 +02:00
DeepSOIC
578f038cf9
Fix programming error in DatumCS
2016-04-12 18:12:10 +02:00
DeepSOIC
7653d2d48f
Fix build on Windows
2016-04-12 18:12:10 +02:00
Stefan Tröger
ab2cc10ac7
add missing return value
2016-04-12 18:12:09 +02:00
Stefan Tröger
c0e850cd0d
remove import dependency on assembly workbench
2016-04-12 18:12:09 +02:00
Stefan Tröger
84cd1588d0
Update pipe icon and add it to the taskwatcher
2016-04-12 18:12:09 +02:00
Stefan Tröger
20d551bc88
fix part and body search for invalid objects
2016-04-12 18:12:09 +02:00
Stefan Tröger
3aae4ce011
respect part design placement rules in pipe
2016-04-12 18:12:09 +02:00
Stefan Tröger
620b2bb5d7
simple bugfixes
2016-04-12 18:12:09 +02:00
Stefan Tröger
68ee7f4f27
add two scaling modes
2016-04-12 18:12:09 +02:00
Stefan Tröger
df386cc3c1
make multisection work
2016-04-12 18:12:09 +02:00
Stefan Tröger
d796ca2bf9
better pipe view handling
2016-04-12 18:12:09 +02:00
Stefan Tröger
a727a9b93d
prevent inverted pipes and correct camera adjustment
2016-04-12 18:12:09 +02:00
Stefan Tröger
342ba89afd
generalize preview mode
2016-04-12 18:12:09 +02:00
Stefan Tröger
68d172687b
implement faster pipes with inner wires
2016-04-12 18:12:09 +02:00
Stefan Tröger
0db83e816a
allow sketches with inner wires as pipe profiles
2016-04-12 18:12:09 +02:00
Stefan Tröger
9c4e1070eb
add options for pipe tool
2016-04-12 18:12:09 +02:00
Stefan Tröger
e7803eca61
add basic part design pipe infrastructure
2016-04-12 18:12:09 +02:00
Stefan Tröger
54646ef5bd
fix wrong torus addition
2016-04-12 18:12:08 +02:00
Stefan Tröger
a8f27937de
fix sketch editing within transformed parts
2016-04-12 18:12:08 +02:00
Stefan Tröger
e7284ecde8
fix crash on cancel primitive
2016-04-12 18:12:08 +02:00
Stefan Tröger
6347fe8c86
make origin work correct with multiple parts
2016-04-12 18:12:08 +02:00
Stefan Tröger
ec68192fcf
fix primitive following cs in edit mode and add python console output when closing the task
2016-04-12 18:12:08 +02:00
Stefan Tröger
a19eaf201e
add command for adding a new part
...
note that the icon is a placeholder as currently parts have a system icon which can not be set for commands
2016-04-12 18:12:08 +02:00
Stefan Tröger
d8a0e398a9
make origin lines usable in groove
2016-04-12 18:12:08 +02:00
Stefan Tröger
ec125cf9f2
make origin lines usable in revolution
2016-04-12 18:12:08 +02:00
Stefan Tröger
c5ae4530ab
add primitive preview visualization
2016-04-12 18:12:08 +02:00
Stefan Tröger
0a82185b66
add more point possibilities for cs references
2016-04-12 18:12:08 +02:00
Stefan Tröger
4087ffaef7
make datum feedback more prominent
2016-04-12 18:12:08 +02:00
Stefan Tröger
d3a7e9a928
fix selection error on datum exception
...
and add user feedback for failed selections
2016-04-12 18:12:08 +02:00
Stefan Tröger
7cb6606dc2
add remaining coordinate system selections
2016-04-12 18:12:08 +02:00
Stefan Tröger
96584f776a
viewprovider for coordinate system update
2016-04-12 18:12:08 +02:00
Stefan Tröger
42264b43ca
add a few coordinate system reference systems
2016-04-12 18:12:08 +02:00
Stefan Tröger
c3f35d9f05
add part design thickness
2016-04-12 18:12:08 +02:00
Stefan Tröger
7971bdbb8e
delete primitive if initial task is canceled
2016-04-12 18:12:07 +02:00
Stefan Tröger
fc1e8b8d17
allow to add faces to fillet and chamfer
2016-04-12 18:12:07 +02:00
Stefan Tröger
329064d671
don't create unneeded second body if part is created
2016-04-12 18:12:07 +02:00
Stefan Tröger
49973895f9
fix primitive offset setting issues
2016-04-12 18:12:07 +02:00
Stefan Tröger
6067c64060
allow subtractive primitive only if base available
2016-04-12 18:12:07 +02:00
Stefan Tröger
49eb5467f7
add gui for remaining primitives
2016-04-12 18:12:07 +02:00
Stefan Tröger
3be4939bcc
add remaining primitive features
2016-04-12 18:12:07 +02:00
blobfish
c61718c63b
PartDesign: Gui: build error. couldn't find ui generated file in part build directory.
2016-04-12 18:12:07 +02:00
Stefan Tröger
fec86abc09
visualize the primitive add/sub shape in edit
2016-04-12 18:12:07 +02:00
Stefan Tröger
1f180a11da
make primitive task box work
2016-04-12 18:12:07 +02:00
Stefan Tröger
7654659c18
add primitive widget to task dialog
2016-04-12 18:12:07 +02:00
Stefan Tröger
296339f980
allow shapes as coordinate system references
2016-04-12 18:12:07 +02:00
Stefan Tröger
a7396dcb74
adopt code to new getBody parameter
2016-04-12 18:12:07 +02:00
Stefan Tröger
0385734339
primitive bug fixes, add cylinder and sphere
2016-04-12 18:12:07 +02:00
Stefan Tröger
8fdde38e75
add coordinate system datum
2016-04-12 18:12:07 +02:00
Stefan Tröger
d923bebccc
make transform features work with non-sketch based features
2016-04-12 18:12:07 +02:00
Stefan Tröger
cf83242f5b
fix basic additive box
2016-04-12 18:12:07 +02:00
DeepSOIC
31e4fd8994
Sketcher: fix free-standing sketches
...
See forum thread, Sketch support == NULL
http://forum.freecadweb.org/viewtopic.php?f=20&t=10942
2016-04-12 18:12:07 +02:00
DeepSOIC
439f392e88
Fix crash when adding datum and there's no active body
...
Plus fix double messageboxes about the lack of the body,
2016-04-12 18:12:07 +02:00
DeepSOIC
fe59e5286e
assert before crashing
2016-04-12 18:12:07 +02:00
DeepSOIC
83777a9610
Fix revolution and groove that mistakenly made a pocket.
2016-04-12 18:12:06 +02:00
DeepSOIC
f31aed1c40
Sketcher: Fix duplicate external avoidance false positives
...
Attempting to link to Edge1 of one object failed when there was already
an Edge1 linked from another object.
2016-04-12 18:12:06 +02:00
DeepSOIC
05b9dd60e3
fix build with MSVC11 aka 2012
2016-04-12 18:12:06 +02:00
Stefan Tröger
52c8a19d4d
basic infrastructure for part design primitives
2016-04-12 18:12:06 +02:00
Stefan Tröger
0e8b78d2fb
make bodies, origins, planes and lines unmovable
2016-04-12 18:12:06 +02:00
Stefan Tröger
1880d46ec6
don't show placement for part design features
2016-04-12 18:12:06 +02:00
Stefan Tröger
9a2f5eea65
allow non-sketch based additive and subtractive features
2016-04-12 18:12:06 +02:00
blobfish
fab4ec990c
PartDesign: Workbench: comment out switchToDocument inside 'slots'
...
This causing a crash when opening a previous versioned file while already in part design.
Can't predict timing of migration call from signals.
2016-04-12 18:12:06 +02:00
blobfish
8fffa8b564
Part: BodyBase: typo in property header macro
2016-04-12 18:12:06 +02:00
Stefan Tröger
051e93238b
fix body boolean placements
2016-04-12 18:12:06 +02:00
Stefan Tröger
f99b0031d3
adopt mirror feature to base plane selection
2016-04-12 18:12:06 +02:00
Stefan Tröger
2aa4d2c210
switch polar pattern to coordinate system axis
2016-04-12 18:12:06 +02:00
Stefan Tröger
d6440b4143
switch linear pattern to coordinate system axis
2016-04-12 18:12:05 +02:00
Stefan Tröger
4c29efea1f
allow origin lines in datum features
2016-04-12 18:12:05 +02:00
Stefan Tröger
63015c769e
allow pick task selection from 3d view
2016-04-12 18:12:05 +02:00
Stefan Tröger
c7555eaa63
interactively show origin objects for feature pick
2016-04-12 18:12:05 +02:00
Stefan Tröger
4b545f9e6f
remove unneeded files
2016-04-12 18:12:05 +02:00
Stefan Tröger
83ab03a491
move feature pick dialog into the task view
2016-04-12 18:12:05 +02:00
blobfish
45844c2fd2
Part Design: Gui: Workbench: assign activePart and activeBody when doc has tip
2016-04-12 18:12:05 +02:00
blobfish
40d144b11b
Part Design: Datum Task: recompute document upon dialog rejections
2016-04-12 18:12:05 +02:00
blobfish
e826e7a683
Part Design: Fillet: Task: cleanup upon dialog rejection
2016-04-12 18:12:05 +02:00
blobfish
c161ffaf44
Part Design: Workbench: commonize construciton of default part and body
2016-04-12 18:12:04 +02:00
blobfish
4a1978aae9
Part Design: add temp PartDesign_MoveTip icon to stop error
2016-04-12 18:12:04 +02:00
blobfish
cd9fcc58ba
PartDesign: Gui: Update doc after setuppart
2016-04-12 18:12:04 +02:00
Stefan Tröger
f873fb80e9
Remove BasePlanes from part design
2016-04-12 18:12:04 +02:00
Stefan Tröger
eb226967f3
Show feature choose dialog for sketch if nothing is selected
2016-04-12 18:12:04 +02:00
Stefan Tröger
13fea20cdd
fix datum plane transparency
...
one can not change the transparany type in the scene graph. Furthermore no normals are used, hence no normal binding is needed.
2016-04-12 18:12:04 +02:00
Stefan Tröger
f357e045de
fix blocking datum plane
...
BrepFaceSet implementation was faulty, if normal cache locks have been aquired they need to be released
2016-04-12 18:12:04 +02:00
blobfish
10a7f15c37
Part Design: adding const char PDBODYKEY and using. No functional change.
2016-04-12 18:12:04 +02:00
blobfish
56af3ca44d
PartDesign: adding some asserts to workbench
2016-04-12 18:12:04 +02:00
blobfish
7248888e05
PartDesign: Workbench: set active body post migration
2016-04-12 18:12:04 +02:00
blobfish
d90fec4de1
Part Design: Workbench: don't try to remove active body
2016-04-12 18:12:04 +02:00
blobfish
baa0fa97b9
Part Design: Sketch: command find planes with app::Part::BaseplaneTypes
2016-04-12 18:12:04 +02:00
blobfish
7be3e654f8
not typo
2016-04-12 18:12:03 +02:00
blobfish
6877cbbd51
updating to setActiveObject call
2016-04-12 18:12:03 +02:00
jriegel
884ae139fa
Several enhancements
...
+ PLMXML Reader
+ Some meta information sorting
+ Making ProductRefs invisibly in Tree
2016-04-12 18:12:03 +02:00