Commit Graph

14 Commits

Author SHA1 Message Date
Curtis Ekstrom
142a7217d4
Remove *Binding(s) from project
These bindings can be replaced wholesale with the more idiomatic
alternative: aliases.

In addition, avoid passing in user to components where it can be injected directly.

One of the perceived downsides of dependency injection can be
that it can make debugging feel more difficult because it's not
immediately clear where the value is coming from, which the explicit
variant we previously used does not suffer from. It might also be
argued that we also lose out on a seam that could be useful in the
future where a component doesn't care about the specific type of
user, just that one is passed in.

While explicitness is often a virtue, it comes at the cost of increased
noise that pervades multiple layers of components. I'd argue this makes
the parent components more difficult to understand, given they are
littered with unnecessary references to data they themselves do not
need.

This decreases the noise/ceremony around accessing
userPermissions/auth data and restricts access to that data to
the child components that actually need to know about it.

As to losing a seam, it appears 1) that this isn't
currently necessary and 2) we can use an internal computed
property should the need arise in the future.
2016-04-13 13:54:51 +02:00
Piotr Sarnacki
7764479c14 Schedule inserting elements afterRender
It will ensure that log element is already loaded.
2016-01-29 14:31:16 +01:00
Piotr Sarnacki
24465e634f Use el.innerHTML = ''; instead of $(el).empty()
innerHTML is faster than empty(), especially on some versions of
firefox. This change was already commited before, but it was somehow
lost while converting project to JS.
2016-01-29 14:31:16 +01:00
Piotr Sarnacki
9a9d3805d8 Bring back noop function which was accidentally destroyed 2016-01-27 12:32:53 +01:00
Lisa P
2882c8ca96 add empty href otherwise iOS does not fire a tap event correctly 2016-01-25 15:25:33 +01:00
Piotr Sarnacki
a6087d4fcd [deprecations] Use Component#_state instead of Component#state 2016-01-07 11:18:00 +01:00
Piotr Sarnacki
03332a8654 [deprecations] Don't run Ember.set directly in didInsertElement 2016-01-07 10:40:14 +01:00
Lisa P
1233eba3e8 fix log 2016-01-05 14:44:27 +01:00
Lisa P
10b0c62fc2 make log toggle on mobile 2016-01-05 14:15:25 +01:00
Piotr Sarnacki
737685a7c0 Fix ajax callbacks after javascript conversion 2016-01-04 13:15:15 +01:00
Piotr Sarnacki
e60b0a0224 Fix jshint errors after conversion to JS 2016-01-04 13:15:15 +01:00
Piotr Sarnacki
fafaf65043 Convert project to JavaScript 2016-01-04 13:15:14 +01:00
Piotr Sarnacki
21285bbe8b Use el.innerHTML = ''; instead of $(el).empty()
It turns out that jQuery's empty method can be really slow in Firefox,
which can freeze the browser when cleaning the log.
2015-12-30 10:36:18 +01:00
Piotr Sarnacki
6e73923fbb Convert log-content component to js 2015-12-30 10:36:08 +01:00