OK, it's ugly, but I think it works (on OS X at least). Make the Zotero pane's min-height dependent on the height of the tag selector, which means that for now, at least, the tag selector has to be resized or hidden before the Z-pane can be shrunk down.
Fixed some subtle tag issues, hopefully without causing new ones:
1) If no tags visible after a delete, deselect all
2) If a selected tag is deleted, deselect it
3) If a selected tag goes out of scope in Display All mode, deselect it (otherwise a tag stays selected after removing an item with that tag from the current collection)
We could perhaps be smarter about this and, say, jump back only if the item was visible before the modification. The best solution, probably, would be a keystroke to show the active item, like Command-L in iTunes, but I don't know what keystroke is worth stealing for that purpose...
Similarly, removing items from collections now uses collection-item remove instead of item remove
This was done to prevent some problems that resulted from the tag selector using item modify events to update itself (which caused the items pane to refresh itself before itemTreeView.notify() got a chance to do the things it likes to do).
This should also help out utility writers.
- "Display All" => "Display all tags"
- "No tags to display" message when no matching tags
- "# tags selected" in bottom left
- Dropped "Deselect Visible"
- Added vertical pipe on bottom line
- "Deselect All" => "Deselect all"
This makes the quicksearch considerably more useful, as you can search for a child item in the library, select it, and then clear the search to view the item in context. (Works for multiple items as well, even of different parents.)
Add Document item type. Just the type -- no magical properties for now.
Fields: title, publisher, date, and the globals (callNumber, archiveLocation, repository, rights, url, accessDate, extra).
Creator types: author, contributor, editor, translator, reviewedAuthor (should these all be here?)
(Moved redundant string manipulation out of the sort() callback. I put it there by mistake in r831 when namespacing all the XUL ids right before b2.r2.)
There might be some regressions from this, but it seems to work fine.
Also:
- Fixed JS strict warnings in popup note window
- Use Zotero.Notes.add() when using toolbar button instead of a two-stage save with ZP.newItem('note')
CSS updates from Jeremy with some streamlining by me (consistency of print style, removal of unnecessary lines, and some other fixes)
Changed doctype to XHTML 1.0 Strict from 1.1
Adding /html/report.html to end of URL to provide a filename hint for Firefox (instead of the file being called 12345-34567-84573-42632.xhtml)
x-moz-url was listed as a supported flavour in both panes but not actually supported
Also fixed a typo (= instead of ==) in collectionTreeView's canDrop()
If an edit causes a note to stop matching the quicksearch, clear the search
Also:
- Select text in quicksearch when using shortcut key instead of just focusing
- Fixed strict warning
But don't break the independent note tags view
Also fix another tags error in that view
A lot of item pane logic really needs to be put in bindings, somehow...
(As noted in the ticket, this bug applied to clicking between any fields (not just "extra") without changing a value -- it also kept the second textbox from focusing properly on click.)
Not entirely sure how I broke this, but here's a fix.
Closes#471, Tag selector should update when tags are added/removed
Tag Selector overhaul:
- Right-click to rename/delete tags globally
- Filter tags to only those associated with currently visible items, with a Display All checkbox to show others in gray -- scope list set via new callback mechanism in the items tree
- Drag and drop items onto tags to batch assign
- Tag Notifier events, currently unused (tag selector currently just refreshes on all item events, since doing granular tag updates is considerably more complicated)
- Performance improvements, offset by the new features that make it slower
There should probably be an option to use either an ANY or an ALL search in the tag selector... (It's ALL by default now.)
New methods:
- Zotero.hasValues(obj) -- return true if an object (/associative array) has at least one value, false if not
- Zotero.Item.addTagByID()
- Zotero.Item.hasTag()
- Zotero.Tags.getAllWithinSearch(search)
- Zotero.Tags.rename(tagID, tag)
- Zotero.Tags.remove(tagID)
- ItemTreeView.addCallback()
- ItemTreeView.setFilter('search'|'tags', data) -- replaces searchText()
- CollectionTreeView.getSearchObject() -- search object used to generate the items list
- CollectionTreeView.getChildTags()
