Commit Graph

5793 Commits

Author SHA1 Message Date
wmayer
08df5cbc59 + remove 'using namespace Part' inside header file 2016-04-13 16:20:31 +02:00
wmayer
df48d1668b + remove 'using namespace Attacher' inside header file 2016-04-13 15:57:49 +02:00
wmayer
0a7ab4e1ff + add missing license text 2016-04-13 15:20:41 +02:00
wmayer
5de9696365 + fix warnings:
-Wsign-compare, -Wunused-variable, -Wunused-function, -Wswitch
+ fix Qt issues
2016-04-13 14:26:38 +02:00
wmayer
e3b609b309 + consistent naming 2016-04-13 11:37:09 +02:00
Stefan Tröger
483e64f368 remove unneeded orig files 2016-04-12 19:10:19 +02:00
Stefan Tröger
4119bb7adc Fix compilation issue in Attacher code 2016-04-12 18:12:24 +02:00
Stefan Tröger
cd2da9fe6d Fix test cases by adopting to new behavior
Pad now does not have a Sketch property anymore but a profile property. Also due to changes in PropertyLinkSubList it ispossible that PropertyLinks get an empty list assigned, this must be supportet now.
2016-04-12 18:12:24 +02:00
Stefan Tröger
788035b80e Part: Recalculate tessellation when requested 2016-04-12 18:12:23 +02:00
Stefan Tröger
5f45bcbc94 PartDesign: Fix body command 2016-04-12 18:12:23 +02:00
Stefan Tröger
8b0d53358a PartDesign: Adopt primitive preview
The preview was developed when the "one feature only" visibility rule was not yet introduced. This commit maks it work again.
2016-04-12 18:12:23 +02:00
Stefan Tröger
6bf31e841e PartDesign: Fix attachment external references 2016-04-12 18:12:23 +02:00
Stefan Tröger
306611e8f8 Fix rebase error 2016-04-12 18:12:23 +02:00
Stefan Tröger
036d0691dd Fix Windows build errors 2016-04-12 18:12:23 +02:00
Stefan Tröger
e9b9d285ac PartDesign: Unify datum and shapebuilder visuals 2016-04-12 18:12:23 +02:00
Stefan Tröger
666a5968cb Override mode works with non-toplevel viewprovider
And adopt the part design body to handle the override mode correctly
2016-04-12 18:12:23 +02:00
Stefan Tröger
048c374080 PartDesign: body is responsible for visuals
-Hide all visual properties of features when they are part of a body
-Propagate all body visual changes to features
-Separate display mode from body mode to enable setting display mode for both "tip" and "through" modes
-Use default visuals for body shape and only make "through" a new display mask mode for the children
2016-04-12 18:12:23 +02:00
Stefan Tröger
03b08a311c Fix sketch positioning with part and body 2016-04-12 18:12:23 +02:00
Stefan Tröger
d7e52f11a7 PartDesign: Fix context menus 2016-04-12 18:12:23 +02:00
Stefan Tröger
64de3b64e1 PartDesign: prevent claiming features 2016-04-12 18:12:23 +02:00
Stefan Tröger
90debce159 Fix rebase error 2016-04-12 18:12:23 +02:00
Stefan Tröger
3b27def228 PartDesign: prevent crash on delete and add body 2016-04-12 18:12:23 +02:00
Stefan Tröger
e7d8a1a9a4 Remove ShapeBinder2D
As profile based features can work with faces and wires now ShapeBinder can do everything that needed ShapeBinder2D before.
2016-04-12 18:12:23 +02:00
Stefan Tröger
2b0e6883c3 Fix workflow manager crash on windows 2016-04-12 18:12:23 +02:00
Stefan Tröger
4ec7fe6303 PartDesign: Adopt pattern to face based features 2016-04-12 18:12:22 +02:00
Stefan Tröger
f712f5e4ac PartDesign: Modeling features work with faces
-Rename Sketchbased to ProfileBased to show new behavior
-Adopt ProfileBased to make the relevant helper functions work with faces too
-Adopt features for unified use of helper functions
-Adopt commands to allow face selection
2016-04-12 18:12:22 +02:00
Stefan Tröger
7dea66872e Datums not selectable during edit 2016-04-12 18:12:22 +02:00
Stefan Tröger
5002e8e430 Fix crash on aborted pattern external axis 2016-04-12 18:12:22 +02:00
Stefan Tröger
7d30833349 PartDesign: Adopt to new property status bits 2016-04-12 18:12:22 +02:00
Stefan Tröger
a6c8f38cf0 no body allowed as body base feature 2016-04-12 18:12:22 +02:00
Stefan Tröger
7cd20adc9a ShapeBinder: fix Null shape on recompute for copy 2016-04-12 18:12:22 +02:00
Stefan Tröger
e88b042a26 Fix shape binder placement
-- hidden for user
-- inherited by linked part
2016-04-12 18:12:22 +02:00
Stefan Tröger
4164f8fc4c Ensure only a single PartDesign feature is visible 2016-04-12 18:12:22 +02:00
Stefan Tröger
24bdc173f7 PartDesign mirror must work with base planes 2016-04-12 18:12:22 +02:00
Stefan Tröger
99ef8e756d Fix transform feature crash on apply
-Redundant "reset edit" and command commit removed
-Redundant apply call removed
2016-04-12 18:12:22 +02:00
Stefan Tröger
16433939e1 Add missing files 2016-04-12 18:12:22 +02:00
Stefan Tröger
c0b2568091 fix reference selection of origin features 2016-04-12 18:12:22 +02:00
Stefan Tröger
4be81b01e4 Handle external references for revolution et all
The reference selection, used in multiple part design features, treated body external references not corectly.
2016-04-12 18:12:22 +02:00
Stefan Tröger
3792f38191 Fix shutdown crash with primitives in the document
and cleanup the header
2016-04-12 18:12:22 +02:00
Stefan Tröger
4d12023f17 Prevent dressup crash due to multi command commit
the same functionality is provided by upstream accept functions
2016-04-12 18:12:21 +02:00
Stefan Tröger
28965457aa Active view may not be 3d viewer
When for example the spreadsheet is open and an recompute is issued, the active view is not the 3d viewer which leads to crash if used for scene graph calculations.
2016-04-12 18:12:21 +02:00
Alexander Golubev
d43525370c PartDesignGui: small rework to sketch-based task parameters
This done mostly for thurther unification them with other task
parameters/dialogs.
2016-04-12 18:12:21 +02:00
Alexander Golubev
96486cc4ed PartDesign/App: a small fix to offset constraint syntax for Pad and Pocket 2016-04-12 18:12:21 +02:00
Alexander Golubev
6b75141514 Suppress a couple more warnings 2016-04-12 18:12:21 +02:00
Alexander Golubev
0cfc0cd424 Fix warnings introduced in new PartDesign
Mostly unused wariables and compare of signed & unsigned
2016-04-12 18:12:21 +02:00
DeepSOIC
81015b3f44 Fix problems with unlimited external geometry
Caused by recent changes by abdullah, which assumes there is external
geometry only if sketch has support.
http://forum.freecadweb.org/viewtopic.php?f=3&t=12746&p=102087#p102087
2016-04-12 18:12:21 +02:00
Stefan Tröger
e675c43ddf Simplify the feature pick dialog
less options are easier to grasp for the user
2016-04-12 18:12:21 +02:00
Stefan Tröger
005c3db946 fix sketch classification for other body
hasObject does search recursive only in groups, but a body is not a group. Hence for sketches within a body this will always return false. Annother logic must be used to detect sketches in bodies.
2016-04-12 18:12:21 +02:00
Stefan Tröger
80fe971b55 fix sketch selection in part design
validateSketch was faulty: as every sketch is valid (non is removed) it could happen that the returned number was >0 but the iterator firstValidSketch was NULL nontheless. The routine needed to be udated to make snese and the usage in prepareSketchbased together with it.
2016-04-12 18:12:21 +02:00
Stefan Tröger
76c8cb3b69 add only a single reference copy 2016-04-12 18:12:21 +02:00
Stefan Tröger
2ab25ea414 Fix incorrect ShapeBinder recalculation 2016-04-12 18:12:21 +02:00
Stefan Tröger
4ed0302404 Ensure correct sketch placement calculation
As bodies are movable now they need to be taken into account for calculating the sketch placement.
2016-04-12 18:12:21 +02:00
Stefan Tröger
ef2437bb5c Fix sketch on face of other body or part
The shapebinder object reduces the number of faces to 1, hence the subshape to select is always Face1 and not the original face name
2016-04-12 18:12:21 +02:00
Stefan Tröger
e7a96ac26f fix body booleans 2016-04-12 18:12:20 +02:00
Stefan Tröger
585e4cebb5 PartDesign/Gui: minor fix sWhatsThis of text 2016-04-12 18:12:20 +02:00
Stefan Tröger
2ff2d29f02 Fix crossreference handling 2016-04-12 18:12:20 +02:00
Stefan Tröger
83eedba043 crossreferences only with ctrl button and fix missing return value 2016-04-12 18:12:20 +02:00
DeepSOIC
e2f70e5e5b Sketcher: when refusing to link external, print why (in statusbar) 2016-04-12 18:12:20 +02:00
DeepSOIC
3df305cc4e Sketcher: allow referencing everything; add testing for circular references 2016-04-12 18:12:20 +02:00
Stefan Tröger
5725dd7721 handle independent copies more gracefully 2016-04-12 18:12:20 +02:00
Stefan Tröger
3bd09ea570 change point of reference feedback for datums
On datum creation it is better to ask the user on OK than on tool activation, as he might hit cancel (and then the created references are till there) or even more important, he could add additional external references within the dialog. The disadvantae is that if the user sets "cross reference" ge gets asked again every time he opens and leaves the dialog.
2016-04-12 18:12:20 +02:00
Alexander Golubev
1f3d2df4d5 PartDesign/Body: add ability to store facebinders inside a body 2016-04-12 18:12:20 +02:00
Stefan Tröger
d5e035741a ask user if he creates inter part/body references 2016-04-12 18:12:20 +02:00
Stefan Tröger
655bf961be add task for datum shape features 2016-04-12 18:12:19 +02:00
Stefan Tröger
34541dea2f PartDesign/Plane: several enhancements to plane icon 2016-04-12 18:12:19 +02:00
Stefan Tröger
e58ae2b616 Setup ShapeBinder Viewprovider and command 2016-04-12 18:12:19 +02:00
Stefan Tröger
811ccc410c PartDesign: Reorder datum commands 2016-04-12 18:12:19 +02:00
Stefan Tröger
9969aac671 fix dependent copy references
to make them work with sketches an additional Part2DObject reference needed to be created
2016-04-12 18:12:19 +02:00
Alexander Golubev
36fbf73011 PartDesign/TaskLoftParameters: Added UpdateView checkbox +cleanup 2016-04-12 18:12:19 +02:00
Alexander Golubev
efef23d8e2 PartDesign/Gui: prevent Task*PatternParameters not crash on non sketchBased features 2016-04-12 18:12:19 +02:00
Alexander Golubev
aa7d054d47 PartDesign/TaskLoftParameters: removed unused hidden widgets 2016-04-12 18:12:19 +02:00
Alexander Golubev
0ff24fd618 Part/Gui: remove ViewProviderPart::onDelete which handled unnecessary body housekeaping
Also do some headers cleanup
2016-04-12 18:12:19 +02:00
Alexander Golubev
ba57a843ad PartDesign/ViewProviderBody: reduce number of recalculations in the body 2016-04-12 18:12:19 +02:00
Alexander Golubev
3be2f99b52 PartDesign/Gui: rework of ViewProviderDatumCS 2016-04-12 18:12:19 +02:00
Alexander Golubev
fa29bfa667 PartDesign/ViewProviderDatum: minor enhancements
- added defaultSize constant
 - fixed typo in margin{g,}Factor function name
2016-04-12 18:12:19 +02:00
Alexander Golubev
d4c67c0366 GeoFeaturertDesign/Gui: Add recompute sizes and datums to the body vp 2016-04-12 18:12:19 +02:00
Alexander Golubev
bceec93a92 PartDesign/Gui: rework ViewProviderDatumPlane 2016-04-12 18:12:19 +02:00
Alexander Golubev
7ac1ab6a6d PartDesign/Gui: make Datums use general material interface
- Make Datums colorable and transparent
 - Change default datums color to yellow and transparency to 60%
 - Rework Lines and Points datum view provider
 - Add ViewProviderDatum::defaultBoundBox()
2016-04-12 18:12:19 +02:00
Alexander Golubev
118f1cec6a PartDesign/App: cleanup datum's classes and headers 2016-04-12 18:12:19 +02:00
Alexander Golubev
04f3ae0605 PartDesign/CommandBody: a minor fix in MoveTip command 2016-04-12 18:12:19 +02:00
Alexander Golubev
26fb01b429 PartDesign/Gui: add origin sizing and rework datums sizing 2016-04-12 18:12:18 +02:00
Alexander Golubev
1a26f7551f PartDesign: add Origin to the Body and unstrap the module from the Parts 2016-04-12 18:12:18 +02:00
Alexander Golubev
2c2d155ee9 OriginGroup: add new abstraction layer between the Part and the GeoFeatureGroup 2016-04-12 18:12:18 +02:00
Alexander Golubev
8bca27463e Part/Attacher: remove a couple of no more valid asserts 2016-04-12 18:12:18 +02:00
Alexander Golubev
797d6d3a11 App/Origin: big refactoring
- Rebase App::Origin on App::DocumentObject
 - Keep all control over the Origin structure inside the Origin and it's
   ViewProvider
 - Add OriginFeature class as common base for App::Plane and App::Line
 - Rebase App::Plane and App::Line on top of newly created class and
   move to the file.
 - Change Origin's ViewProvider API associated with temporary display
 - Lots of associated changes to files
 - Several minor fixes
 - Lots of new bugs
2016-04-12 18:12:18 +02:00
Alexander Golubev
c6797b6c29 Revert "part deletion handling"
This reverts commit 6ab2002021ac1df26ebe77f488f5cd94e1df0b26.
2016-04-12 18:12:17 +02:00
Alexander Golubev
76b4685b5f Commented out a portion of code cosed a segfault 2016-04-12 18:12:17 +02:00
Alexander Golubev
5016054a8b PartDesign/Body: move deletion of subobjects to view provider 2016-04-12 18:12:17 +02:00
Alexander Golubev
abc925b62e PartDesign/Gui: Make partDesign's add sketch command Workflow-aware 2016-04-12 18:12:17 +02:00
Alexander Golubev
492f1d24a4 PartDesign/Gui: initial migration command implementation 2016-04-12 18:12:17 +02:00
Alexander Golubev
c4f094bba4 PartDesign/Gui: rename some fonctions in ReferenceSelection.cpp
e.g. getPythonStr -> buildLinkListPythonStr etc
2016-04-12 18:12:17 +02:00
Alexander Golubev
f9e67626ec PartDesign/Body: remowe Part::Feature from isAllowed() 2016-04-12 18:12:17 +02:00
Alexander Golubev
c388a84424 PartDisign/WorkflowManager: initial implementation 2016-04-12 18:12:17 +02:00
Alexander Golubev
8a2d4289f6 PartDesign/FeaturePrimitive: suppress a -Woverloaded-virtual warning 2016-04-12 18:12:17 +02:00
Alexander Golubev
c782a11aab PartDesign/Gui: Move various utility stuff from Workbench to a separate file
Also do some header cleanup.
2016-04-12 18:12:17 +02:00
Alexander Golubev
a5fcd5775e PartDesign: update body management commands according to the changes in body paradigms 2016-04-12 18:12:16 +02:00
Alexander Golubev
8b62680fe7 Sketcher: minor enhance in sketch interaction with body 2016-04-12 18:12:16 +02:00
Alexander Golubev
bf94c3ebf7 PartDesign: fix negative Offset property in pad and pocket 2016-04-12 18:12:16 +02:00
Alexander Golubev
444986e88a PartDesign/Gui: move body commands to a separate file 2016-04-12 18:12:16 +02:00
Alexander Golubev
8c5d514b18 PartDesign: Body rework - add BaseFeature property and make Tip always point to solid 2016-04-12 18:12:16 +02:00
Alexander Golubev
e3c00ce650 PartDesign/ViewProviderPad: removed a TODO 2016-04-12 18:12:16 +02:00
Alexander Golubev
1b1bd5f17e PartDesign/Gui: make Transformed ViewProviders use common code with other 2016-04-12 18:12:16 +02:00
Alexander Golubev
9cba6c48ea PartDesign/TaskMultiTransformParameters: fix a segfault
The segfault was caused by premature delete of object
TaskMultiTransformParameter::subFeature refered to.
Steps to reproduce:
1. Create a multitransform
2. Add a sub transfurmation to it
3. Press cancel
2016-04-12 18:12:16 +02:00
Alexander Golubev
113c10a2b7 PartDesign: make transform parameter dialogs use common base code with other dialogs
subj;
Make PasrtDesign::Transformed provide common for all features
classes interface getBaseObject() instead of specific getSupportObject ();
Refactor some TransformedParameters methods.
2016-04-12 18:12:16 +02:00
Alexander Golubev
e6a99ce96f PartDesign/Workbench: fix a crash 2016-04-12 18:12:16 +02:00
Alexander Golubev
147aff0395 PartDesign/Feature: minor gramma fix 2016-04-12 18:12:16 +02:00
Alexander Golubev
da1fb99dc5 PartDesign/ViewProvider: minor enhancements 2016-04-12 18:12:16 +02:00
Alexander Golubev
e28aaf4592 PartDesign/TaskDressUpParameters: disable edit of dressup features with broken supports
Also remove unused headers and fix spacing.

A final fixup for issues addressed in:
cb05b01 PartDesign/TaskDressUpParameters: fix a crash when editing a broken object
2016-04-12 18:12:15 +02:00
Alexander Golubev
1876c76f3c PartDesign/Gui: make DressUp view providers use the common code. 2016-04-12 18:12:15 +02:00
Alexander Golubev
55f3f52f54 PartDesign/Feature: add an optional parameter to getBaseObject() to prevent it from throwing exceptions
In most cases getBaseObject() is used with an exception handler which
only detects if it failed but not the reason. This modification allows
to use it without excess exception handlers.
Also add the same parameter to SketchBased::getVerifiedSketch().
2016-04-12 18:12:15 +02:00
Alexander Golubev
013381ccb6 PartDesign/Gui: share code for revolution and groove view providers 2016-04-12 18:12:15 +02:00
Alexander Golubev
5ee0cea467 PartDesign/Gui: start to unify view providers code
- Moved all common code for part design features view providers to a base
   class.
 - Move shared code for Sketch based features to newly created
   ViewProviderSketchBased class
 - Add ViewProviderSketchBased to initialization
 - Make Pad and Pocket ViewProviders to use the shared code
 - Minor fixes to TaskFeatureParameters and some derived classes
2016-04-12 18:12:15 +02:00
Alexander Golubev
6266d514d3 PartDesign/ViewProviderDatum: minor fix in a comment 2016-04-12 18:12:15 +02:00
Alexander Golubev
5f6f16e757 PartDesign/FeatureDressUp: implement a proper getBaseObject()
The function getBaseShape() is removed and replaced with getBaseObject()
because it doesn't make a lot of scense: getBaseShape() masked the
base's class implementation (rather than redefine a virtual) which was
better in words of code reuse.

Also BaseFeature and Base properties relations are defined now in a
little another way.
2016-04-12 18:12:15 +02:00
Alexander Golubev
9feff04aad PartDesign/TaskDressUpParameters: fix a crash when editing a broken object 2016-04-12 18:12:15 +02:00
Alexander Golubev
0ca40ed48b PartDesign/Task{Pad,Pocket}Parameters: massive refactoring
Give a massive refactoring to Task dialogs for pocket and pad.
This commit features:
 * Make Task dialogs for pocket and pad look nice in side-by side diff and
   cross import features missing in each other.
 * As a result it fixes several minor bugs.
 * Gives a rework to the UpdateUI function.
 * This one also fixes offset option support and migrates it to use unit
   framework.
2016-04-12 18:12:15 +02:00
Alexander Golubev
143760c8d3 PartDesign/ViewProviderPad: removed unfinished reimplementation of doubleClick()
This one resulted in non proper reject of pad dialog. Because the
command transaction haven't started.
2016-04-12 18:12:15 +02:00
Alexander Golubev
11a71d46e3 PartDesignGui: move signal connections in several parameter dialogs after ui initialization 2016-04-12 18:12:15 +02:00
Alexander Golubev
f16829baee PartDesignGui: Make DressUp and SketchSupport propertie dialogs use common accept() structure 2016-04-12 18:12:15 +02:00
Alexander Golubev
12742d94de PartDesign/TaskThicknessParameters: fix copy-paste mistake in dialog 2016-04-12 18:12:15 +02:00
Alexander Golubev
9db8afd716 PartDesignGui: move shared code for all dressUp features into common place.
Also this allows the old workflow for thickness and draft features.
2016-04-12 18:12:15 +02:00
Alexander Golubev
b14d7c2e14 PartDesign: move common code for TaskDlg{SketcherBased,DressUp}Parameters into new base class
Added a new class: TaskDlgFeatureBased which currently contains common
code for TaskDlgSketcherBasedParameters::reject() as well as the same
methode for TaskDlgDressUpParameters.
It's likely that other Feature task dialogs will inherit this class too.
2016-04-12 18:12:15 +02:00
Alexander Golubev
0208a3667d PartDesign/FeatureDressUp: make Base and BaseFeature properties track the same feature
Also remove reseting of read-only flag on placement properties on
removing Base feature: it doesn't make any scense for dressup features.
2016-04-12 18:12:15 +02:00
Alexander Golubev
98a0e30582 PartDesign: fix a crash in the loft 2016-04-12 18:12:14 +02:00
Alexander Golubev
86db4c3215 PartDesign/Gui: enable sketches on datum planes inside bodies 2016-04-12 18:12:14 +02:00
Alexander Golubev
e586f55fb2 PartDesign/Gui: more old workflow support
* remove an error message if adding a sketchbased feature without a body
* add champfer or fillet old workflow support

Also rework finishFeature() so at least champfer and fillet may be
inserted into any place of any apropriate body(not only the active one) of the body.
2016-04-12 18:12:14 +02:00
Alexander Golubev
a6ebfa496f PartDesign/Gui/TaskDlgSketchBasedParameters: emhance object hiding/unhiding on reject() 2016-04-12 18:12:14 +02:00
Alexander Golubev
4590305921 PartDesign/Gui: enhance the TaskFeaturePick with new cotegory of sketches: notInBody
Also add option tp show already used sketches and fix some spacing.
2016-04-12 18:12:14 +02:00
Alexander Golubev
ffc6cc2f23 Share code for finding a body containing a feature 2016-04-12 18:12:14 +02:00
DeepSOIC
16e4ce20f0 PartDesign workflow without part/body
PartDesign: make datum features work outside of body/part
PartDesign old workflow: remove a few messageboxes about no part
PartDesign: old workflow: multitransform without body

Still has visibility issues, but generally works.
2016-04-12 18:12:14 +02:00
DeepSOIC
c3da141020 Revolution: fix failure on sketch edges used as an axis
PartDesign Revolution used to fail, when an edge of a sketch was
selected as an axis of revolution. This is fixed by this commit.
Also, made it support selecting an edge from the sketch the revolution
itself is made from.
2016-04-12 18:12:14 +02:00
DeepSOIC
125dda4d70 PartDesign: Make groove work via Revolution ui
Purpose: remove duplicate code.
Remaining: wrong title and icon in task dialog.
2016-04-12 18:12:14 +02:00
DeepSOIC
9776d30b87 PartDesign: rework axis and plane comboboxes and make it work without part.
Rework combobox filling and link hadling for revolution and transformed features, in order to get rid of hard-coded item indexes and make the lists more dynamic.
2016-04-12 18:12:14 +02:00
DeepSOIC
2625233dff PartDesign: disable migration
Temporary. Later, a way to manually invoke it should be made.
2016-04-12 18:12:14 +02:00
Alexander Golubev
f509e1b0f1 remove unneeded sketcher tools from part design
Previously similar patch was commited by Stefan Tröger <stefantroeger@gmx.net> but lost during rebase.
2016-04-12 18:12:14 +02:00
Stefan Tröger
a8bd2f6f7f prevent part design features from accidently cross referencing 2016-04-12 18:12:14 +02:00
Stefan Tröger
318c65eafd fix independent copy and cross reference 2016-04-12 18:12:14 +02:00
Stefan Tröger
a35c231d2a first take on enhanced feature pick task 2016-04-12 18:12:14 +02:00
Stefan Tröger
45aca9fb55 fix loft top face location 2016-04-12 18:12:13 +02:00
Stefan Tröger
986623f462 fix loft tool naming 2016-04-12 18:12:13 +02:00
Stefan Tröger
d2f4410c1e fix datum crash when origin is selected 2016-04-12 18:12:13 +02:00
Stefan Tröger
e876d9aa81 fix loft result orientation 2016-04-12 18:12:13 +02:00
Stefan Tröger
ef11b75c79 fix pipe tool result orientation 2016-04-12 18:12:13 +02:00
Stefan Tröger
45861b4f92 remove linear and S-shape scaling from pipe
They worked and are nice feature, but the handling with properties must be worked out better. To avoid any incompatibility due to property changes the functionality is removed now.
2016-04-12 18:12:13 +02:00
Stefan Tröger
d980952d31 fix body and part tool texts 2016-04-12 18:12:13 +02:00
Stefan Tröger
7d759a5793 delete features when deleting body 2016-04-12 18:12:13 +02:00
Stefan Tröger
ecfe545b3b add part tool to task dialog for no selection 2016-04-12 18:12:13 +02:00
Stefan Tröger
0606e767cd fix pipe task dialog icon 2016-04-12 18:12:13 +02:00
Stefan Tröger
939286ca3e add shaft wizard only when building fem 2016-04-12 18:12:13 +02:00
Stefan Tröger
12c5e1f92f remove hole feature
A hole feature is something needed, however, the current implementation does not use the attacher code which would made it intuitive and compatibel to other workbench tools. A reimplementation is needed.
2016-04-12 18:12:13 +02:00
DeepSOIC
72c70bcc50 Datum UI: fixes
* fix messagebox not popping when clicking OK but status is error
* accept preselection
* unify code for all datum commands
* edit selected datum if type matches, instead of creating new one
2016-04-12 18:12:13 +02:00
DeepSOIC
a48f9a682c Sketcher: use Selection's getAsPropertyLinkSubList 2016-04-12 18:12:13 +02:00
DeepSOIC
03e354f7ac PartDesign: fix porting procedure...
...that caused an assert in attacher that back/front subshape strings
were used for attachment to App::Plane.
2016-04-12 18:12:13 +02:00
DeepSOIC
4e57b1a2ec Datum UI: fixes
* fix highlighting of reference buttons when active
* fix selection of whole objects
* fix some other logic
2016-04-12 18:12:13 +02:00
Stefan Tröger
de0768af80 fix crash on datum point preselect
It is unclear why the coordinates are NULL. This fix prevents the crash but does not fix the reason why this unnormality occurs.
2016-04-12 18:12:13 +02:00
Stefan Tröger
7deb6393cc no temporaries at by reference parameter 2016-04-12 18:12:12 +02:00
Stefan Tröger
4e295c03ed fix crash in boolean op if no base feature exists 2016-04-12 18:12:12 +02:00
DeepSOIC
98717f010a Attacher: proximity modes
The modes that base on distToShape:
* a line that connects the closest points,
* the actual points
2016-04-12 18:12:12 +02:00
DeepSOIC
a3d9907e8c PartDesign: adapt Datum UI to work using Attacher
* adapt
* introduce mode selection
* kill selection gate to allow selecting whole objects (selection gate
should be reintroduced to disallow references between parts, no
restrictions is a temporary state)
* prevent auto-switchover to next ref after an explicit push of a button
* fix highlighting of buttons when selecting corresponding reference
* allow creation of a feature, even if no mode fits references. With a
warning.
2016-04-12 18:12:12 +02:00
DeepSOIC
a5d38c9a99 PartDesign: patch old partdesign porting for changes in Datums 2016-04-12 18:12:12 +02:00
DeepSOIC
9e440b955c PartDesign: transfer Datums to become AttachableObjects
Crude and quick, needs cleanup.
2016-04-12 18:12:12 +02:00
DeepSOIC
40592e6055 Attacher: line and point AttachEngines. Other changes.
* propose attachment modes
* refactor setUp and Copy
* split off postprocessing from 3D to reuse in 1D and 0D calculations
* AttachableObject: fix error printout in onChange
* AttachableObject: no more defaults to Attacher3D
* implementation of lines and points attachment (some of the proposed modes).
* refactor getShapeType, add getShapeType(obj, sub); add a flag to eRefType enum, indicating that referenced thing is a whole object that has placement.
* change readLinks to be static, and obtain shape types in the process.
* test mode enums lengths equality
* extend ObjectXY to work on conics.
* Fix upside-down sketches attached as TangentPlane on most shapes.
* Fix crash when a shape of unlisted type is in the links.
* fix attaching to datum lines go crazy because of infinities.
* abs->fabs
* support for App::Line
* Add namespace qualifiers to TYPESYSTEM_SOURCE-like stuff
2016-04-12 18:12:12 +02:00
DeepSOIC
4800957858 Attacher: change Part2DObject's MapMode default to mmDeactivated, and set mode to mmFlatFace only when reading files of old format.
PartDesign, Sketcher: set mapping mode when setting support

Mapping mode mmFlatFace is no longer default, so an explicit assignment
is required.
2016-04-12 18:12:12 +02:00
DeepSOIC
fa441a9623 PropertyLinkSubList, Sketcher: move legacy Support readout from PropertyContainer to Part2DObject 2016-04-12 18:12:12 +02:00
DeepSOIC
ad01411efc Attacher: fix crash of suggestor on compounds 2016-04-12 18:12:12 +02:00
DeepSOIC
34784b2d29 PartDesign: Fix revolution
It failed to close task if starting a body.
2016-04-12 18:12:12 +02:00
DeepSOIC
f688546106 InvoluteGear: positionBySupport 2016-04-12 18:12:12 +02:00
DeepSOIC
acac286cd0 Sketch: expose positionBySupport python func 2016-04-12 18:12:12 +02:00
DeepSOIC
4cc9b32e32 PartDesign: accomodating to sketch's multisupport
* FeatureSketchBased getSupportFace check for mapping mode
* Fixes failure to place sketches on DatumPlanes
2016-04-12 18:12:12 +02:00
DeepSOIC
2a390660c8 Sketcher: minimalistic UI for new attachment engine 2016-04-12 18:12:12 +02:00
DeepSOIC
42ecc24ec5 Sketcher: new attachment engine 2016-04-12 18:12:12 +02:00
DeepSOIC
061747f367 Sketcher: change Support from PropertyLinkSub to PropertyLinkSubList
Note: may fail to build after this commit...
2016-04-12 18:12:12 +02:00
DeepSOIC
eccff10d90 PartDesign: fix refuse to pad
When something was depending on a sketch (another sketch, for example),
padding (revolving, pocketing, etc) it was impossible. This is fixed.

Also, padding or revolving a single sketch twice was allowed (with a
warning msg displayed).
2016-04-12 18:12:11 +02:00
Alexander Golubev
445c26f658 PartDesign/Body: make insert/removeFeature treat NULL in a less special way 2016-04-12 18:12:11 +02:00
Alexander Golubev
bf58a7be2a PartDesign: make MoveFeatureInTree command use new insert functions 2016-04-12 18:12:11 +02:00
Alexander Golubev
9c113357c5 PartDesign: add migrating sketch support to MoveFeature command 2016-04-12 18:12:11 +02:00
Alexander Golubev
03d3f45277 PartDesign/Workbench: make a message more translation-frendly 2016-04-12 18:12:11 +02:00
Alexander Golubev
ad461fc472 PartDesign: fix spacing in several files 2016-04-12 18:12:11 +02:00
Alexander Golubev
7e1a76eb37 PartDesign/Workbench: move fix of sketch support into separate function
Outside PartDesign sketches can have no support plane for them. But
PartDesign doesn't allow that.
Move the code for migration of "free" sketches of planes
into a separate fuction so it may be reused.
2016-04-12 18:12:11 +02:00
Alexander Golubev
7c2413b0aa PartDesign/Body: add methodes to insert features into specific place
Add a Body::insertFeature() methodes as well as python API for it.
2016-04-12 18:12:11 +02:00
DeepSOIC
ec2bbc4c34 Loft: fix build with MSVC2013 2016-04-12 18:12:11 +02:00
DeepSOIC
4b48362ec6 PartDesign: refactor positionBySketch
Rename it to positionByPrevious. Rewrite.
Rewrite SketchBased::transformPlacement.
2016-04-12 18:12:11 +02:00
DeepSOIC
03be8e1bba PartDesign: tidy up sketch support and base feature confusion
Not complete, transformPlacement and positionBySketch are pending...
2016-04-12 18:12:11 +02:00
Alexander Golubev
b67c8bd34d PartDesign/FeatureDraft: fix a wronly placed NOT 2016-04-12 18:12:11 +02:00
Alexander Golubev
b9f4e10fa5 PartDesign: fix a couple of crashes
The first crash was reported here:
http://forum.freecadweb.org/viewtopic.php?f=20&t=11205&start=50#p91052

The second one accures then moving a feature from a body without solid
features.
2016-04-12 18:12:11 +02:00
Stefan Tröger
08e4151ea1 make hole feature work again 2016-04-12 18:12:11 +02:00
Stefan Tröger
7f80e711f6 better active part and document tip handling 2016-04-12 18:12:10 +02:00
Stefan Tröger
d435e15a97 make part design loft functional 2016-04-12 18:12:10 +02:00
Stefan Tröger
987880fffa add loft viewprovider 2016-04-12 18:12:10 +02:00
Stefan Tröger
c82e4117e9 add feature loft 2016-04-12 18:12:10 +02:00
Alexander Golubev
f4a5bf6acd PartDesign: remove Body::isFeature() because it's the same as BodyBase::hasFeature() 2016-04-12 18:12:10 +02:00
DeepSOIC
36fe5994b9 Revolution: fix crash when selecting stuff during task 2016-04-12 18:12:10 +02:00
Danny Lepage
8aecb00a8d Fix Debug Assert in CmdPartDesignDuplicateSelection::activated
Under Windows, "Edit/Duplicate selected object" raised a
Debug Assertion Failed "Expression: sequence not ordered".
2016-04-12 18:12:10 +02:00
Danny Lepage
63bdbe5561 Fix Boolean operation tooltip text.
As reported by triplus
2016-04-12 18:12:10 +02:00
DeepSOIC
578f038cf9 Fix programming error in DatumCS 2016-04-12 18:12:10 +02:00
DeepSOIC
7653d2d48f Fix build on Windows 2016-04-12 18:12:10 +02:00
Stefan Tröger
ab2cc10ac7 add missing return value 2016-04-12 18:12:09 +02:00
Stefan Tröger
c0e850cd0d remove import dependency on assembly workbench 2016-04-12 18:12:09 +02:00
Stefan Tröger
84cd1588d0 Update pipe icon and add it to the taskwatcher 2016-04-12 18:12:09 +02:00
Stefan Tröger
20d551bc88 fix part and body search for invalid objects 2016-04-12 18:12:09 +02:00
Stefan Tröger
3aae4ce011 respect part design placement rules in pipe 2016-04-12 18:12:09 +02:00
Stefan Tröger
620b2bb5d7 simple bugfixes 2016-04-12 18:12:09 +02:00
Stefan Tröger
68ee7f4f27 add two scaling modes 2016-04-12 18:12:09 +02:00
Stefan Tröger
df386cc3c1 make multisection work 2016-04-12 18:12:09 +02:00
Stefan Tröger
d796ca2bf9 better pipe view handling 2016-04-12 18:12:09 +02:00
Stefan Tröger
a727a9b93d prevent inverted pipes and correct camera adjustment 2016-04-12 18:12:09 +02:00
Stefan Tröger
342ba89afd generalize preview mode 2016-04-12 18:12:09 +02:00
Stefan Tröger
68d172687b implement faster pipes with inner wires 2016-04-12 18:12:09 +02:00
Stefan Tröger
0db83e816a allow sketches with inner wires as pipe profiles 2016-04-12 18:12:09 +02:00
Stefan Tröger
9c4e1070eb add options for pipe tool 2016-04-12 18:12:09 +02:00
Stefan Tröger
e7803eca61 add basic part design pipe infrastructure 2016-04-12 18:12:09 +02:00
Stefan Tröger
54646ef5bd fix wrong torus addition 2016-04-12 18:12:08 +02:00
Stefan Tröger
a8f27937de fix sketch editing within transformed parts 2016-04-12 18:12:08 +02:00
Stefan Tröger
e7284ecde8 fix crash on cancel primitive 2016-04-12 18:12:08 +02:00
Stefan Tröger
6347fe8c86 make origin work correct with multiple parts 2016-04-12 18:12:08 +02:00
Stefan Tröger
ec68192fcf fix primitive following cs in edit mode and add python console output when closing the task 2016-04-12 18:12:08 +02:00
Stefan Tröger
a19eaf201e add command for adding a new part
note that the icon is a placeholder as currently parts have a system icon which can not be set for commands
2016-04-12 18:12:08 +02:00
Stefan Tröger
d8a0e398a9 make origin lines usable in groove 2016-04-12 18:12:08 +02:00
Stefan Tröger
ec125cf9f2 make origin lines usable in revolution 2016-04-12 18:12:08 +02:00
Stefan Tröger
c5ae4530ab add primitive preview visualization 2016-04-12 18:12:08 +02:00
Stefan Tröger
0a82185b66 add more point possibilities for cs references 2016-04-12 18:12:08 +02:00
Stefan Tröger
4087ffaef7 make datum feedback more prominent 2016-04-12 18:12:08 +02:00
Stefan Tröger
d3a7e9a928 fix selection error on datum exception
and add user feedback for failed selections
2016-04-12 18:12:08 +02:00
Stefan Tröger
7cb6606dc2 add remaining coordinate system selections 2016-04-12 18:12:08 +02:00
Stefan Tröger
96584f776a viewprovider for coordinate system update 2016-04-12 18:12:08 +02:00
Stefan Tröger
42264b43ca add a few coordinate system reference systems 2016-04-12 18:12:08 +02:00
Stefan Tröger
c3f35d9f05 add part design thickness 2016-04-12 18:12:08 +02:00
Stefan Tröger
7971bdbb8e delete primitive if initial task is canceled 2016-04-12 18:12:07 +02:00
Stefan Tröger
fc1e8b8d17 allow to add faces to fillet and chamfer 2016-04-12 18:12:07 +02:00
Stefan Tröger
329064d671 don't create unneeded second body if part is created 2016-04-12 18:12:07 +02:00
Stefan Tröger
49973895f9 fix primitive offset setting issues 2016-04-12 18:12:07 +02:00
Stefan Tröger
6067c64060 allow subtractive primitive only if base available 2016-04-12 18:12:07 +02:00
Stefan Tröger
49eb5467f7 add gui for remaining primitives 2016-04-12 18:12:07 +02:00
Stefan Tröger
3be4939bcc add remaining primitive features 2016-04-12 18:12:07 +02:00
blobfish
c61718c63b PartDesign: Gui: build error. couldn't find ui generated file in part build directory. 2016-04-12 18:12:07 +02:00
Stefan Tröger
fec86abc09 visualize the primitive add/sub shape in edit 2016-04-12 18:12:07 +02:00
Stefan Tröger
1f180a11da make primitive task box work 2016-04-12 18:12:07 +02:00
Stefan Tröger
7654659c18 add primitive widget to task dialog 2016-04-12 18:12:07 +02:00
Stefan Tröger
296339f980 allow shapes as coordinate system references 2016-04-12 18:12:07 +02:00
Stefan Tröger
a7396dcb74 adopt code to new getBody parameter 2016-04-12 18:12:07 +02:00
Stefan Tröger
0385734339 primitive bug fixes, add cylinder and sphere 2016-04-12 18:12:07 +02:00
Stefan Tröger
8fdde38e75 add coordinate system datum 2016-04-12 18:12:07 +02:00
Stefan Tröger
d923bebccc make transform features work with non-sketch based features 2016-04-12 18:12:07 +02:00
Stefan Tröger
cf83242f5b fix basic additive box 2016-04-12 18:12:07 +02:00
DeepSOIC
31e4fd8994 Sketcher: fix free-standing sketches
See forum thread, Sketch support == NULL
http://forum.freecadweb.org/viewtopic.php?f=20&t=10942
2016-04-12 18:12:07 +02:00
DeepSOIC
439f392e88 Fix crash when adding datum and there's no active body
Plus fix double messageboxes about the lack of the body,
2016-04-12 18:12:07 +02:00
DeepSOIC
fe59e5286e assert before crashing 2016-04-12 18:12:07 +02:00
DeepSOIC
83777a9610 Fix revolution and groove that mistakenly made a pocket. 2016-04-12 18:12:06 +02:00
DeepSOIC
f31aed1c40 Sketcher: Fix duplicate external avoidance false positives
Attempting to link to Edge1 of one object failed when there was already
an Edge1 linked from another object.
2016-04-12 18:12:06 +02:00
DeepSOIC
05b9dd60e3 fix build with MSVC11 aka 2012 2016-04-12 18:12:06 +02:00
Stefan Tröger
52c8a19d4d basic infrastructure for part design primitives 2016-04-12 18:12:06 +02:00
Stefan Tröger
0e8b78d2fb make bodies, origins, planes and lines unmovable 2016-04-12 18:12:06 +02:00
Stefan Tröger
1880d46ec6 don't show placement for part design features 2016-04-12 18:12:06 +02:00
Stefan Tröger
9a2f5eea65 allow non-sketch based additive and subtractive features 2016-04-12 18:12:06 +02:00
blobfish
fab4ec990c PartDesign: Workbench: comment out switchToDocument inside 'slots'
This causing a crash when opening a previous versioned file while already in part design.
    Can't predict timing of migration call from signals.
2016-04-12 18:12:06 +02:00
blobfish
8fffa8b564 Part: BodyBase: typo in property header macro 2016-04-12 18:12:06 +02:00
Stefan Tröger
051e93238b fix body boolean placements 2016-04-12 18:12:06 +02:00
Stefan Tröger
f99b0031d3 adopt mirror feature to base plane selection 2016-04-12 18:12:06 +02:00
Stefan Tröger
2aa4d2c210 switch polar pattern to coordinate system axis 2016-04-12 18:12:06 +02:00
Stefan Tröger
d6440b4143 switch linear pattern to coordinate system axis 2016-04-12 18:12:05 +02:00
Stefan Tröger
4c29efea1f allow origin lines in datum features 2016-04-12 18:12:05 +02:00
Stefan Tröger
63015c769e allow pick task selection from 3d view 2016-04-12 18:12:05 +02:00
Stefan Tröger
c7555eaa63 interactively show origin objects for feature pick 2016-04-12 18:12:05 +02:00
Stefan Tröger
4b545f9e6f remove unneeded files 2016-04-12 18:12:05 +02:00
Stefan Tröger
83ab03a491 move feature pick dialog into the task view 2016-04-12 18:12:05 +02:00
blobfish
45844c2fd2 Part Design: Gui: Workbench: assign activePart and activeBody when doc has tip 2016-04-12 18:12:05 +02:00
blobfish
40d144b11b Part Design: Datum Task: recompute document upon dialog rejections 2016-04-12 18:12:05 +02:00
blobfish
e826e7a683 Part Design: Fillet: Task: cleanup upon dialog rejection 2016-04-12 18:12:05 +02:00
blobfish
c161ffaf44 Part Design: Workbench: commonize construciton of default part and body 2016-04-12 18:12:04 +02:00
blobfish
4a1978aae9 Part Design: add temp PartDesign_MoveTip icon to stop error 2016-04-12 18:12:04 +02:00
blobfish
cd9fcc58ba PartDesign: Gui: Update doc after setuppart 2016-04-12 18:12:04 +02:00
Stefan Tröger
f873fb80e9 Remove BasePlanes from part design 2016-04-12 18:12:04 +02:00
Stefan Tröger
eb226967f3 Show feature choose dialog for sketch if nothing is selected 2016-04-12 18:12:04 +02:00
Stefan Tröger
13fea20cdd fix datum plane transparency
one can not change the transparany type in the scene graph. Furthermore no normals are used, hence no normal binding is needed.
2016-04-12 18:12:04 +02:00
Stefan Tröger
f357e045de fix blocking datum plane
BrepFaceSet implementation was faulty, if normal cache locks have been aquired they need to be released
2016-04-12 18:12:04 +02:00
blobfish
10a7f15c37 Part Design: adding const char PDBODYKEY and using. No functional change. 2016-04-12 18:12:04 +02:00
blobfish
56af3ca44d PartDesign: adding some asserts to workbench 2016-04-12 18:12:04 +02:00
blobfish
7248888e05 PartDesign: Workbench: set active body post migration 2016-04-12 18:12:04 +02:00
blobfish
d90fec4de1 Part Design: Workbench: don't try to remove active body 2016-04-12 18:12:04 +02:00
blobfish
baa0fa97b9 Part Design: Sketch: command find planes with app::Part::BaseplaneTypes 2016-04-12 18:12:04 +02:00
blobfish
7be3e654f8 not typo 2016-04-12 18:12:03 +02:00
blobfish
6877cbbd51 updating to setActiveObject call 2016-04-12 18:12:03 +02:00
jriegel
884ae139fa Several enhancements
+ PLMXML Reader
+ Some meta information sorting
+ Making ProductRefs invisibly in Tree
2016-04-12 18:12:03 +02:00
jriegel
b38f63f391 + add PlmXmlParser
+ add test data for PLMXML and JT
2016-04-12 18:12:03 +02:00
jriegel
45f7c99c1c Changing active object handling in PartDesign 2016-04-12 18:12:03 +02:00
jriegel
775744c1ac some fixes in Active object handling on Viewer 2016-04-12 18:12:03 +02:00
jriegel
842604a2f8 small warning fix 2016-04-12 18:12:03 +02:00
jriegel
240f2f7428 fix Jt merge 2016-04-12 18:12:03 +02:00
jriegel
1e01f8c223 fix errors from merge of master 2016-04-12 18:12:03 +02:00
jriegel
ade02b5643 implementing Element reading 2016-04-12 18:12:03 +02:00
jriegel
1ca23c33c7 tchnical commit 2016-04-12 18:12:03 +02:00
jriegel
81b4bcd4af further implementing 2016-04-12 18:12:03 +02:00
jriegel
248b228dbf start new Jt Reader 2016-04-12 18:12:02 +02:00
jriegel
5271a24476 [Assembly] fixing the commands and some import 2016-04-12 18:12:02 +02:00
jriegel
d59904fd37 some fixes 2016-04-12 18:12:02 +02:00
jriegel
dc4fdc2c53 Assembly: Rename to setActiveBody and make link indeipendant Part initialization 2016-04-12 18:12:02 +02:00
jriegel
51b46e1e37 Assembly: Add GeoFeatureGroup and helpers 2016-04-12 18:12:02 +02:00
jriegel
0013374818 Assembly: Document handling and some fixes 2016-04-12 18:12:02 +02:00
jriegel
0feabcc8ff Assembly: Add non PartDesign feature group to Part also 2016-04-12 18:12:02 +02:00
jriegel
952d598ca9 Assembly: Add warning on conversion 2016-04-12 18:12:02 +02:00
jriegel
e9744c842d Make Part working 2016-04-12 18:12:02 +02:00
jriegel
1f1f6f81ce Moving Part creation into PartDesign Workbench 2016-04-12 18:12:02 +02:00
jriegel
015183a0d7 Error handling if NumPy is not there 2016-04-12 18:12:02 +02:00
jriegel
104d94ae0f compiles on LibPack 10 2016-04-12 18:12:02 +02:00
jriegel
608dddd998 Restructure the Assembly data model (again)... 2016-04-12 18:12:01 +02:00
jriegel
09fe593ae0 small fix 2016-04-12 18:12:01 +02:00
Jan Rheinländer
72b6d02a43 Allow selecting sketch axes in Polarpattern, same as in LinearPattern and Mirrored 2016-04-12 18:12:01 +02:00
Jan Rheinländer
0ddff2419f Fixed bugs in Transformed features 2016-04-12 18:12:01 +02:00
jriegel
35e35527db Start of rework of class structure 2016-04-12 18:12:01 +02:00
jriegel
9d25c717b4 Add additional loging 2016-04-12 18:12:01 +02:00
jriegel
14efce0655 fix #1348 2016-04-12 18:12:01 +02:00
jriegel
43eab0c491 Implement some diagnostics 2016-04-12 18:12:01 +02:00
jriegel
6344c42525 Open new track for importing Assembly structures with OCSF reader. 2016-04-12 18:12:01 +02:00
jriegel
4ad93594a6 Fixes some merge Bugs 2016-04-12 18:12:01 +02:00
jriegel
91196ee244 dripping Body in Assembly (ongoing) 2016-04-12 18:12:01 +02:00
jriegel
a08fdaa648 New Dialog for Quenstions and Warnings and the usage in Assembly 2016-04-12 18:12:01 +02:00
Stefan Troeger
ad8ae753d9 fix the precompiled redefinition problem 2016-04-12 18:12:01 +02:00
Stefan Troeger
32e6091366 add assembly item destructor to avoid strange linker problemn 2016-04-12 18:12:01 +02:00
Stefan Tröger
de9c61e150 restore externalisation behaviour with gcc/clang compilers 2016-04-12 18:12:01 +02:00
Stefan Troeger
c070d41e1e fix wrong conditional statement 2016-04-12 18:12:01 +02:00
Stefan Troeger
5fd47ad881 fix typo in preprocessor else if statement 2016-04-12 18:12:01 +02:00
Stefan Troeger
5ef6fb5dd5 msvc and gcc/clang are not satisfiable with the same code... 2016-04-12 18:12:01 +02:00
Stefan Troeger
3b4db93332 resolve windows issues 2016-04-12 18:12:01 +02:00
Stefan Tröger
18aceffce8 dissallow cyclic system until they work reliabe
l
2016-04-12 18:12:01 +02:00
Stefan Tröger
9bd19328ca multiple debug updates 2016-04-12 18:12:00 +02:00
jmaustpc
cdd83966b1 update remaining Assembly constraint icons to new theme
update remaining Assembly constraint icons
to new cylinder theme

Also increase the emphasis on the constriants
by thickening them, in the
Assembly_constraints_tree icon
2016-04-12 18:12:00 +02:00
jmaustpc
1de931355e update Assembly constraint icons to cylinder theme 2016-04-12 18:12:00 +02:00
jmaustpc
8be5d0eb3e update Assembly Workbench icon in InitGui.py 2016-04-12 18:12:00 +02:00
jmaustpc
38b1d497dd Update icon references in Task Assembly Constraint
to include the new sub-directory "constraints" in the path
for the Assembly constraints icons
2016-04-12 18:12:00 +02:00
Jan Rheinländer
4c9b9adde6 Fixed usage of std::abs() in polar pattern 2016-04-12 18:12:00 +02:00
blobfish
4b2f107cc1 Part Design: support for overlapping and coincident patterns
Fixed crash after rejecting a MultiTransform dialog
    remove overlap check
    adding getSolid to cut operation
    add extrema method to part::checkinterference
    move refineshape call out of loops
    divideTools functions
2016-04-12 18:12:00 +02:00
Jan Rheinländer
deb9e85d03 Fixed crash after rejecting a MultiTransform dialog 2016-04-12 18:12:00 +02:00
Jan Rheinländer
af25c0c793 Reference highlighting for fillets and chamfers 2016-04-12 18:12:00 +02:00
Jan Rheinländer
1772eb70bc PartDesign::Transformed: Transformed shapes that touch are now rejected as overlapping in the interest of boolean operation stability 2016-04-12 18:12:00 +02:00
Jan Rheinländer
7839099fea Fix bug in PartDesign conversion that choked on unconsumed sketches 2016-04-12 18:12:00 +02:00
Stefan Tröger
4b5e387da4 extend debug facilities with state writing and add externalisation to make it compile with a decent amout of memory 2016-04-12 18:12:00 +02:00
Stefan Tröger
fce34e05fc avoid rescales when scale value is in allowed range 2016-04-12 18:12:00 +02:00
jmaustpc
0f1ae0d95b Add new icons to Assembly work bench
Including new body icons for the treeview and
PartDesign create new body command.
Move all Assembly constrains icons into their
own sub directory of the icons directory
add "STEP, IGES or BREP" to the tool tip
of Assembly add existing Component command
2016-04-12 18:12:00 +02:00
Stefan Tröger
2737db260c calculate geometry point on the correct storage 2016-04-12 18:12:00 +02:00
Stefan Tröger
34921ff034 don't rescale on rotation solver 2016-04-12 18:12:00 +02:00
Stefan Tröger
1f99cb347b fix full system failure when using the fix constrain 2016-04-12 18:11:59 +02:00
Stefan Tröger
894249473b make nonrigid subbassemblys work when they hold subassemblys themself 2016-04-12 18:11:59 +02:00
Stefan Tröger
4441d9d2c7 make subassembly constraints always accessible 2016-04-12 18:11:59 +02:00
Stefan Tröger
0a750b1bc5 only use scale value for rotation-only solving, not the transformed clusters. This gives the more expected results 2016-04-12 18:11:59 +02:00
Stefan Tröger
66f9afbef3 fix unsupported geometry crashs, add visual feedback for unsupported geometry and fix crash on both parts in subassemblys 2016-04-12 18:11:59 +02:00
Stefan Tröger
61a47d7c22 improve solvability of seperated rotation/translation 2016-04-12 18:11:59 +02:00
Stefan Tröger
81ccdeb331 further distinguish between rotation and translation solving 2016-04-12 18:11:59 +02:00
Stefan Tröger
ee5d3be3cc implement subsystem callbacks 2016-04-12 18:11:59 +02:00
Stefan Tröger
d4fdb92957 new openDCM version 2016-04-12 18:11:59 +02:00
jriegel
9d196708b1 small fixes after merge from master 2016-04-12 18:11:59 +02:00
Jan Rheinländer
273e0f0b71 Fixed bug that did not allow selecting datum planes as external references in sketches 2016-04-12 18:11:59 +02:00
jriegel
0b28a757ab Workaround for a wired linker problem on Windows. Actually still not solved... 2016-04-12 18:11:59 +02:00
Stefan Tröger
054dba0847 rename the add commands 2016-04-12 18:11:59 +02:00
Stefan Troeger
f0ed9c81c3 include dcm core directly to use the warning supression 2016-04-12 18:11:59 +02:00
Stefan Tröger
8b0fe845bf use freecad resource, not local one 2016-04-12 18:11:59 +02:00
Stefan Troeger
aa5d84196c supress useless msvc warnings 2016-04-12 18:11:58 +02:00
Stefan Tröger
dce4061ee6 treat multiple assignment operator warning on msvc 2016-04-12 18:11:58 +02:00
jrheinlaender
9851450174 Fixed bug in Body conversion code 2016-04-12 18:11:58 +02:00
jrheinlaender
53189fd36f Cosmetic change in FemConstraint.cpp 2016-04-12 18:11:58 +02:00
Stefan Tröger
bd484ca7ca suppress useless msvc warning 2016-04-12 18:11:58 +02:00
Stefan Tröger
348f4c5476 make sure active assembly object extern variable is always the same type, as visual studio can't find it if derived classes are used 2016-04-12 18:11:58 +02:00
Stefan Tröger
ab4ca88fef placehoder text not supported in libpack qt version 2016-04-12 18:11:58 +02:00
Stefan Tröger
bc8d2d2294 reduce solver calls and fix cylinder-cylinder coincident options 2016-04-12 18:11:58 +02:00
Stefan Tröger
e9540eadcc let assembly part numbering use standart freecad sheme 2016-04-12 18:11:58 +02:00
Stefan Tröger
ad855d1cf5 remove exeption on solver error 2016-04-12 18:11:58 +02:00
Stefan Tröger
dd1044a5e8 slightly better error reporting from app to gui 2016-04-12 18:11:58 +02:00
Stefan Tröger
932c4b5e11 fix perpendicular initial position issue and add better tooltips 2016-04-12 18:11:58 +02:00
Stefan Tröger
0099bfd0fd fix failing angle constraint on bad starting position: treat LGZ before first error check 2016-04-12 18:11:58 +02:00
Stefan Tröger
9fdeef50fe update logging to be used with boost1.54 and make it a compile option 2016-04-12 18:11:58 +02:00
Stefan Tröger
c1d799e831 prevent dangling pointers by clearing the active assembly after it was deleted 2016-04-12 18:11:57 +02:00
Stefan Tröger
64ec142d61 Fix solution space behaviour and further distinguish alignment/coincident 2016-04-12 18:11:57 +02:00
Stefan Tröger
45a3f149c3 make solution spaces accessible from GUI and fix some solver implementation errors 2016-04-12 18:11:57 +02:00
Stefan Tröger
3abda4dd67 new dcm version 2016-04-12 18:11:57 +02:00
jrheinlaender
5376e3a3e5 Fixed bugs in various features that reversed the list of selections 2016-04-12 18:11:57 +02:00
Stefan Tröger
f91d5013a3 revidsed assembly constraint gui interaction 2016-04-12 18:11:57 +02:00
jrheinlaender
9569dd3beb Fix bug in PartDesignGui Workbench that may cause a crash 2016-04-12 18:11:57 +02:00
Stefan Tröger
acd4109d5b add missing template specifier (gcc error) 2016-04-12 18:11:57 +02:00
Stefan Tröger
5dea42c995 multiple files added 2016-04-12 18:11:57 +02:00
Stefan Tröger
e8dda0b25a add core defines file 2016-04-12 18:11:57 +02:00
Stefan Tröger
8ec3907a03 test commit 2016-04-12 18:11:57 +02:00
Stefan Tröger
710540c0b0 line line distance works with parallel lines too 2016-04-12 18:11:57 +02:00
Stefan Tröger
b3058a4f5a windows adoptions 2016-04-12 18:11:57 +02:00
jrheinlaender
7981edd639 Allow selecting and removing fillet and chamfer references in the dialog (part 2) 2016-04-12 18:11:57 +02:00
jrheinlaender
ee7f50a554 Allow selecting and removing fillet and chamfer references in the dialog 2016-04-12 18:11:56 +02:00
jrheinlaender
8b19d2cf16 Unify code of Dressup features (part 2: Draft) 2016-04-12 18:11:56 +02:00
jrheinlaender
3229b322ec Fix some errors in the PartDesign ViewProvider code 2016-04-12 18:11:56 +02:00
jrheinlaender
a2359adb2e Unify code of Dressup features (part 1: Draft) 2016-04-12 18:11:56 +02:00
Stefan Tröger
6c494157f5 updated dcm version 2016-04-12 18:11:56 +02:00
Stefan Tröger
913ec86fdd treat gradient zeros at residual!=0 2016-04-12 18:11:56 +02:00
jrheinlaender
fcea39b0d8 Enable multiple originals for the transformed features 2016-04-12 18:11:56 +02:00
jrheinlaender
a59901ee4b Some code unification for DressUp features 2016-04-12 18:11:56 +02:00
jrheinlaender
d32317229d Fix bug in workbench 2016-04-12 18:11:56 +02:00
jrheinlaender
904799d462 Color already selected faces of Draft feature when adding more or removing faces 2016-04-12 18:11:56 +02:00
Stefan Tröger
a15fbf3db6 add parts and components to the selected or active assembly only and add user information 2016-04-12 18:11:56 +02:00
Stefan Tröger
f007608c81 throw exception at unsuported geometrie instead of crashing 2016-04-12 18:11:56 +02:00
jrheinlaender
3ff550f977 Fixed double clicking bug in the viewprovider 2016-04-12 18:11:56 +02:00
jrheinlaender
0a743b27da Python code of Hole Feature 2016-04-12 18:11:56 +02:00
jrheinlaender
45ce3b7822 Enable Python to read the value of a sketcher constraint 2016-04-12 18:11:55 +02:00
jrheinlaender
f6958f391c Fix bug where external reference was ignored without an error message 2016-04-12 18:11:55 +02:00
jrheinlaender
37a8c02bc6 Improved SketchObject error reporting 2016-04-12 18:11:55 +02:00
jrheinlaender
0ab6a77442 Update SketchObject Placement when the Support property changes 2016-04-12 18:11:55 +02:00
jrheinlaender
5c18e947e6 getActivePart() python function as complement to setActivePart() 2016-04-12 18:11:55 +02:00
jrheinlaender
f7874306b9 Allow Pyton features inside bodies 2016-04-12 18:11:55 +02:00
jrheinlaender
ae1890f56b Python functions to intersect curves and surfaces 2016-04-12 18:11:55 +02:00
jrheinlaender
8e1ea4ac14 Removed some old code 2016-04-12 18:11:55 +02:00
jrheinlaender
853adf7d9d Highlighting for datum features 2016-04-12 18:11:55 +02:00
jrheinlaender
e993480ca0 Made Body::claimChildren() stabler against NULL items 2016-04-12 18:11:55 +02:00
jrheinlaender
4623f3a7d3 Some code cosmetics 2016-04-12 18:11:55 +02:00
jrheinlaender
cdb49c28e5 Allow datum point and line from circular reference 2016-04-12 18:11:55 +02:00
jrheinlaender
b6932b0bdb Allow datum points and lines to have offsets from their references 2016-04-12 18:11:55 +02:00
jrheinlaender
22e3aaa2d6 Fix bug in SketchObject::execute() that throws exception instead of returning an error 2016-04-12 18:11:55 +02:00
jrheinlaender
a4ad9a6a55 ViewProviderBody::claimChildren() : Claim all children not claimed by another object 2016-04-12 18:11:55 +02:00
jrheinlaender
02ce7395aa Centralize the check for valid external geometry to ensure consistency (part 2) 2016-04-12 18:11:55 +02:00
jrheinlaender
be9365679f Centralize the check for valid external geometry to ensure consistency 2016-04-12 18:11:55 +02:00
jrheinlaender
2c37723217 Fixed bug in external geometry selection of sketcher 2016-04-12 18:11:55 +02:00
jrheinlaender
99fe9b6178 Moved Body::isAfterTip() to BodyBase 2016-04-12 18:11:55 +02:00
jrheinlaender
9dba4c01e2 Added some comments about things to be fixed in the future 2016-04-12 18:11:55 +02:00
jrheinlaender
010761d162 Fix bug that did not show the correct shape to select a reference (e.g. face) from when editing a SketchBased feature in the tree 2016-04-12 18:11:54 +02:00
jrheinlaender
8a041ffc8e Fix bug that didn't allow to select base plane to create a sketch on it 2016-04-12 18:11:54 +02:00
jrheinlaender
92d51a6e1d Fixed bug that prevented proper switching to PartDesign workbench 2016-04-12 18:11:54 +02:00
jrheinlaender
c21f21666f Fixed bug that didn't clean up the Body when deleting an object from it 2016-04-12 18:11:54 +02:00
jrheinlaender
f9b0e5908a Allow transforming a Pattern feature into a MultiTransform feature 2016-04-12 18:11:54 +02:00
jrheinlaender
5d39df88ee Prevent user from selecting a sketch plane that is not in the active body 2016-04-12 18:11:54 +02:00
Stefan Tröger
6a6997087f windows: add type specifier 2016-04-12 18:11:54 +02:00
Stefan Tröger
30e8fc7b8c revert solving precission to 1e-6 dou to too much cases failing 2016-04-12 18:11:54 +02:00
Stefan Tröger
483357de77 set solving precission to 1e-8 2016-04-12 18:11:54 +02:00
Stefan Tröger
5ce6c68a57 avoid transformation of highlighted constraint 2016-04-12 18:11:54 +02:00
Stefan Tröger
3dafb038b2 remove unneeded display modes from viewprovider 2016-04-12 18:11:54 +02:00
Stefan Tröger
9a50535a4b adopt correct default colors and avoid crash due to context menu 2016-04-12 18:11:54 +02:00
Stefan Tröger
f61ae2e90c allow to set rigid property via context menu 2016-04-12 18:11:54 +02:00
Stefan Tröger
e9e1b45280 allow non-rigid subassemblies 2016-04-12 18:11:54 +02:00
Stefan Tröger
bf8d5e7aa9 fix subassembly transformation bug 2016-04-12 18:11:54 +02:00
Stefan Tröger
14c20fbe89 remove console messages 2016-04-12 18:11:54 +02:00
Stefan Tröger
7fe1d94a21 fix rotational/translational solver bugs in cylce detection and mapping 2016-04-12 18:11:54 +02:00
Stefan Tröger
98d81ed483 make subproduct solving work 2016-04-12 18:11:54 +02:00
Stefan Tröger
26cd6de30f avoid drawing artefacts when adding new constraint 2016-04-12 18:11:54 +02:00
Stefan Tröger
e0efc30893 add visualisation to the constraints 2016-04-12 18:11:53 +02:00
Stefan Tröger
46700422fd make constaints and group not greyed in tree 2016-04-12 18:11:53 +02:00
Stefan Tröger
61430e67e1 put constraint selection message in dialog window 2016-04-12 18:11:53 +02:00
jrheinlaender
d550506f28 Fix handling of MultiTransform features when migrating to Body 2016-04-12 18:11:53 +02:00
jrheinlaender
f3fbf6f285 Improved migration of PartDesign parts to the new Body structure 2016-04-12 18:11:53 +02:00
jrheinlaender
b8dc8181bc Added menu item to move a feature in the tree inside a body 2016-04-12 18:11:53 +02:00
jrheinlaender
6a02b5849f Body: Transformed Features inside a MultiTransform are not considered to be solid features 2016-04-12 18:11:53 +02:00
jrheinlaender
36a00f45b6 PartDesign Body migration: Fix migration of MultiTransform sub-features 2016-04-12 18:11:53 +02:00
jrheinlaender
b2dd70e635 PartDesign Body migration: Handle sketch planes offset from base planes 2016-04-12 18:11:53 +02:00
jrheinlaender
7174a259f0 Two minor fixes 2016-04-12 18:11:53 +02:00
jrheinlaender
4d674831d3 Fix broken placement of boolean operations 2016-04-12 18:11:53 +02:00
jrheinlaender
38ab82a94d Allow external references from other body but not from same body outside the support 2016-04-12 18:11:53 +02:00
jrheinlaender
e735cf7c3a Allow moving features between bodies from context menu of tree view 2016-04-12 18:11:53 +02:00
jrheinlaender
f1b5a6044d Allow extruding from a datum plane to another face or plane, optionally with an offset 2016-04-12 18:11:53 +02:00